Git commits in Moodle 1.8.x by piers

commit 306e9a5057c5f6e73f90f78192b6c5a7f79a943e
Author: piers <piers>
Date:   Tue, 03 Mar 2009 08:23:19 +0900
Tag:    v1.8.9

MDL-18412 - fixed incorrect config var name. thanks Anthony.  backport 1.8.

commit a7e39a4f82e519de390a3c9cdb701411bd1db92a
Author: piers <piers>
Date:   Fri, 27 Feb 2009 01:39:40 +0900
Tag:    v1.8.9

MDL-18148 - AICC compliance fixes from Martin Holden. backport 1.8.

commit 10b7c5f95c02bc1d94eacaa505ad7ccb6eeace47
Author: piers <piers>
Date:   Thu, 26 Feb 2009 08:13:53 +0900
Tag:    v1.8.9

MDL-18212 - switch to addslashes_js - thanks Tim.  Backport 1.8.

commit d104b078a4cb694a5ec98bc4a26937f137dd8d59
Author: piers <piers>
Date:   Thu, 05 Feb 2009 04:01:43 +0900
Tag:    v1.8.9

MDL-17832 - consistent adding and removing of slashes for track data. backport 1.8.

commit 40ab2ed04bc1e12c12d177e48c9e4e25a42e10e4
Author: piers <piers>
Date:   Thu, 05 Feb 2009 03:43:00 +0900
Tag:    v1.8.9

MDL-18023 - add type check to check against default to avoid 0 error. backport 1.8.

commit c97c2b4ae93f3808e56b46981e2d7a2a9107c078
Author: piers <piers>
Date:   Thu, 29 Jan 2009 04:24:54 +0900
Tag:    v1.8.9

MDL-17821 - fix incorrect data validation regexs for 2004. thanks Peter Chamberlin. backport to 1.8. fix typing error on patch.

commit bec21485975d6a43454bd5a76fe5d9046f0fbdd8
Author: piers <piers>
Date:   Thu, 29 Jan 2009 04:23:38 +0900
Tag:    v1.8.9

MDL-17821 - fix incorrect data validation regexs for 2004. thanks Peter Chamberlin. backport to 1.8.

commit 80b4f1e8d2a7635acf996d80b35c40dfa106f3a1
Author: piers <piers>
Date:   Wed, 10 Dec 2008 07:04:48 +0900
Tag:    v1.8.8

MDL-17572 - remove php short tags. backport to 1.8.

commit b9aa74c7f533dea218c89cbfade7391c326d7278
Author: piers <piers>
Date:   Fri, 14 Nov 2008 09:10:10 +0900
Tag:    v1.8.8

MDL-16949 - fix wrong addition of times in SCORM API, thanks Xabi Martin. backport 1.8.

commit 516ca02e7e1f05c507dd2cb743e0c0ddd204144e
Author: piers <piers>
Date:   Sat, 01 Nov 2008 08:05:46 +0900
Tag:    v1.8.8

MDL-7068 - SCORM 2004 compliance - fix mod/scorm to handle core data elements correctly - now passes test DMI.  backport 1.8.

commit 054ff00c617b50bcd76007991b8557b838768dcc
Author: piers <piers>
Date:   Thu, 30 Oct 2008 01:16:51 +0900
Tag:    v1.8.8

MDL-17052 - remove use of $_POST. backport to 1.8.

commit 1846d0a2c27f68136770f156f93e2d8396aee194
Author: piers <piers>
Date:   Tue, 14 Oct 2008 12:43:25 +0800
Tag:    v1.8.7

MDL-16810 - fix typo on function name. thanks to Jason Hardin.  Backport to 1.8.

commit 0b32c364a1319926144bc2beeb09b6cf6212a573
Author: piers <piers>
Date:   Fri, 26 Sep 2008 08:37:10 +0800
Tag:    v1.8.7

MDL-7068 - SCORM 2004 compliance.  Handle cmi.interactions hydration (scorm 1.2 to as well).  Backport to 1.8 - rerun compliance test.

commit 254dfd1f0fe6180d8ffdfec6d6e8e78b955fa782
Author: piers <piers>
Date:   Wed, 17 Sep 2008 10:13:32 +0800
Tag:    v1.8.7

MDL-7097 - API debug. Add ability to manually poke the SCORM API for 1.2 and 2004. backport 1.8.

commit f0e870d0cf5361ea902682bc636281ee61ddc14d
Author: piers <piers>
Date:   Tue, 09 Sep 2008 04:08:17 +0800
Tag:    v1.8.7

MDL-11734 - cmi.comments_from_learner not read - write.  revamp the handling of array style elements. Backport to 1.8.

commit 3da1e9c5f4976bfb58ef6d987664edf99d305412
Author: piers <piers>
Date:   Mon, 08 Sep 2008 08:35:54 +0800
Tag:    v1.8.7

MDL-16299 - Javascript error during scorm player load.  SCOID should not be populated - TOC figures this out. Backport to 1.8.

commit 7d80c9a0fe19041fdcfb58d35482feef3f6fb5c9
Author: piers <piers>
Date:   Wed, 03 Sep 2008 08:43:02 +0800
Tag:    v1.8.7

MDL-16299 - Javascript error during scorm player load.  Ensure SCOID is always populated.  Backport 1.8.

commit b95a25b7a80425e353f2a53ddd0454e1093564c9
Author: piers <piers>
Date:   Fri, 29 Aug 2008 12:14:34 +0800
Tag:    v1.8.7

MDL-14492 - Provide feedback to user about redirect delay in loadsco.php.  Add sanity checking for scorm_resize() as it tries to set -ve heights if user specifies a small area. Thanks francois.  backport 1.8.

commit 522e4ab8c331ad607f089a6665daa8d8a33dcd8c
Author: piers <piers>
Date:   Thu, 28 Aug 2008 07:30:05 +0800
Tag:    v1.8.7

MDL-4746 - Course 01 of the ADL SCORM 1.2 test suite fails on point 4.  only set browsed status if the SCO hasn't set a status.  Backport 1.8.

commit 906faa5a1f90cc2eff5f8bef7175c800ef0dad79
Author: piers <piers>
Date:   Wed, 27 Aug 2008 12:08:55 +0800
Tag:    v1.8.7

MDL-4746 - Course 01 of the ADL SCORM 1.2 test suite fails on point 4.  gramatical error - thanks Dan. Backport 1.8.

commit fff59beb906cd252ce9fc2268c2505209722d4eb
Author: piers <piers>
Date:   Wed, 27 Aug 2008 10:53:27 +0800
Tag:    v1.8.7

MDL-4746 - Course 01 of the ADL SCORM 1.2 test suite fails on point 4.  Fix cmi.comments, and mastery_score checking.  Backport to 1.8.

commit d448df5a1c8ccf3e32ef55d161b9e30b3e3697b9
Author: piers <piers>
Date:   Wed, 27 Aug 2008 07:32:11 +0800
Tag:    v1.8.7

MDL-16111 - SCORM grade not updated in Grader Report. Reverse out 1.8 only portion of patch as it break SCORM compliance - regression testing.

commit 345a24669bbea64644af618d3b15726e2123362b
Author: piers <piers>
Date:   Mon, 25 Aug 2008 07:04:43 +0800
Tag:    v1.8.7

MDL-15881 - Probable bug: Not able to update SCORM.  Backport 1.8.

commit 87806bd4bc5db14640a8b08adc9c7b6471fd2ca7
Author: piers <piers>
Date:   Mon, 25 Aug 2008 05:26:02 +0800
Tag:    v1.8.7

MDL-16111 - SCORM grade not updated in Grader Report.  Include grading by learning objects if status is complete.  Backport to 1.8.

commit 571709c4484f681b086cf3077944ee324d174399
Author: piers <piers>
Date:   Fri, 22 Aug 2008 11:23:13 +0800
Tag:    v1.8.7

MDL-16111 - SCORM grade not updated in Grader Report. Make sure that lastattempt does not exceed maxattempts.  Backport 1.8.

commit e88e09a1f10ff4c823bec7b362909321914b081d
Author: piers <piers>
Date:   Fri, 22 Aug 2008 09:41:48 +0800
Tag:    v1.8.7

MDL-13431 - SCORM results not transferring to Gradebook.  SCORM API debugging tool - add reference to SCORM, and SCO identifier. backport 1.8.

commit dc5f29bf8cc996c7cc3703b4417fb5782bc5095a
Author: piers <piers>
Date:   Thu, 21 Aug 2008 16:31:28 +0800
Tag:    v1.8.7

MDL-13431 - SCORM results not transferring to Gradebook.  SCORM API debugging tool. Backport to 1.8.  remove add_to_log.

commit c9af47a03133fbde3174871f3ce50138cd155988
Author: piers <piers>
Date:   Thu, 21 Aug 2008 09:32:10 +0800
Tag:    v1.8.7

MDL-13431 - SCORM results not transferring to Gradebook.  SCORM API debugging tool. Backport to 1.8 + XHTML problems that stop the debug from working.

commit f7a197e8facf6db0b0104792253d8cdf5683589a
Author: piers <piers>
Date:   Thu, 21 Aug 2008 08:36:12 +0800
Tag:    v1.8.7

file debug.js.php was added on branch MOODLE_18_STABLE on 2008-08-21 01:32:11 +0000

commit 623e2d59d143c16bd4376c627af77e79a364bc7a
Author: piers <piers>
Date:   Thu, 21 Aug 2008 07:33:07 +0800
Tag:    v1.8.7

MDL-13431 - SCORM results not transferring to Gradebook.  Add logging mechanism so that launched URI can be traced. Backport 1.8.

commit e0260731dce65baa46af4833aeef0e579efac455
Author: piers <piers>
Date:   Thu, 21 Aug 2008 07:15:21 +0800
Tag:    v1.8.7

MDL-15859  [PATCH] Fixes for tests of '' on Oracle. Backport 1.8.

commit 1282d923295ddb6b28a6a31dc78aeef484e37b8c
Author: piers <piers>
Date:   Thu, 21 Aug 2008 06:39:34 +0800
Tag:    v1.8.7

MDL-13431 - SCORM results not transferring to Gradebook.  Add logging mechanism so that SCORM API interaction with Moodle can be traced.  Backport 1.8.

commit 1fdfed864f489b238a576f58ebb5e294f5b0fb5e
Author: piers <piers>
Date:   Thu, 21 Aug 2008 06:34:34 +0800
Tag:    v1.8.7

MDL-13431 - SCORM results not transferring to Gradebook.  Use the correct method for getting the course object.  Backport 1.8.

commit 4c9c6f0ddb35176093bdb03f876696fdab780716
Author: piers <piers>
Date:   Fri, 15 Aug 2008 09:10:16 +0800
Tag:    v1.8.7

MDL-13904 Scorm structure isn't respected after an update of the package.  Incorrectly named table in a delete. backport 1.8.

commit 4bea11eae503186b7f073f0042dc412a7f6b2aa7
Author: piers <piers>
Date:   Fri, 15 Aug 2008 08:21:40 +0800
Tag:    v1.8.7

MDL-16055 PHP warning when creating new scorm activity.  backport 1.8.

commit a9aaede659caf76f5cd7d18ee3163c73efd4884a
Author: piers <piers>
Date:   Thu, 14 Aug 2008 07:20:35 +0800
Tag:    v1.8.7

MDL-13904 Scorm structure isn't respected after an update of the package.  This is a large change to the handling of SCORM package update - all SCOes are issued with a new id, and all references to the old ones are deleted.  The scorm_scoes_track data is preserved by being reattached to the new SCO ids (unless they have been deleted).  backport to 1.8.

commit d2436bf26bc308fd0524e97788133b113fc834bb
Author: piers <piers>
Date:   Thu, 14 Aug 2008 06:44:03 +0800
Tag:    v1.8.7

MDL-11188 SCORM module does not respect "prerequisites" like it used to. MDL-12342 & signs in CDATA sections are imported as &amp;.  This is a rewrite of the prerequisite handling. backport to 1.8.

commit 3fa20034ae3763d61be9c128c1f1999b90c911f1
Author: piers <piers>
Date:   Thu, 14 Aug 2008 06:32:05 +0800
Tag:    v1.8.7

MDL-14492 Provide feedback to user about redirect delay in loadsco.php.  Add lang text for please wait.  backport 1.8.

commit 983927938ae91216836c8e7a88db9f606606fb26
Author: piers <piers>
Date:   Mon, 11 Aug 2008 06:37:04 +0800
Tag:    v1.8.7

MDL-14492 Provide feedback to user about redirect delay in loadsco.php.   backport to 1.8.

commit e19a4892a9b27d797ea509ac60da8869229b90ae
Author: piers <piers>
Date:   Thu, 07 Aug 2008 07:56:46 +0800
Tag:    v1.8.7

MDL-10425 and MDL-12872 Firefox bugs String() handling on replace. enhanced rege xfor CMI data types. MDL-8193  Incorrect handling of quotes in SetValue processing - recoded so that it escapes all values passed from tracks. backport to 1.8.  Plus - fixed a back dated problem with determining the next sco in sequence with the navigation buttons.

commit 5f75ca701eb06630c09cdeb6fb04a4794343ec3b
Author: piers <piers>
Date:   Wed, 06 Aug 2008 13:09:15 +0800
Tag:    v1.8.7

MDL-15950 MDL-15640 MDL-15943  - SCORM player.php not inserting footer, Showing SCORM participation report. (thanks Urs Hunkler and Mitsuhiro Yoshida). Warning are displayed in a SCORM activity (thanks Dan). Backport to 1.8.

commit 1f3ef341bd763257c01dc0ea95ce53e9ca6f78c7
Author: piers <piers>
Date:   Mon, 04 Aug 2008 06:20:20 +0800
Tag:    v1.8.7

MDL-14457 SCORM module creating extra windows when opening module in a new window. Backport to 1.8 (thanks Jo Matthews).

commit 43d67c7d221304d45172340dd8bb757fb0f398af
Author: piers <piers>
Date:   Fri, 01 Aug 2008 12:35:38 +0800
Tag:    v1.8.7

MDL-14902 Missing column 'whatgrade' in prefix_scorm table.  Is a DB patch  (thanks Hans de Zwart). backport 1.8.

commit 8fc7b487083615788687ddb6fd1ad16520b30ccf
Author: piers <piers>
Date:   Fri, 01 Aug 2008 06:33:33 +0800
Tag:    v1.8.7

MDL-15899 JavaScript error In IE7 when opening SCORM content in a new window.  Fix spaces in popup name for fussy IE. backported to 1.8.

commit f02cc7bf03c6ed71b18de040bae1f10c87ddd1b3
Author: piers <piers>
Date:   Tue, 29 Jul 2008 09:27:12 +0800
Tag:    v1.8.7

MDL-9378 New visualisation for SCORM - modify CSS class names to make them more specific. sorry to commit so close to review day, just fixing a regression - 1.8.

commit 8e3391e166db61199e455072764434baf6a2deab
Author: piers <piers>
Date:   Tue, 29 Jul 2008 06:46:37 +0800
Tag:    v1.8.7

MDL-11892 JavaScript error on SCORM tree list - bapckport to 1.8 for AICC.

commit 7527707dd5b31ff41f6b97fd67fe683a8daedb48
Author: piers <piers>
Date:   Mon, 28 Jul 2008 08:49:22 +0800
Tag:    v1.8.7

MDL-9378 New visualisation for SCORM - back ported to 1.8.

commit 2eedb5babdf38b53ae8537283e34b96424632f72
Author: piers <piers>
Date:   Mon, 28 Jul 2008 05:26:07 +0800
Tag:    v1.8.7

MDL-11137 Unable to locate API error - add check for empty array from DB interface (ksort complains) - backport to 1.8.

commit 8e3cb4882954c3b07600c621f9689a442e5ea04c
Author: piers <piers>
Date:   Fri, 25 Jul 2008 10:33:10 +0800
Tag:    v1.8.7

MDL-11137 Unable to locate API error - remove comment code with bad characters. backport to 1.8.

commit 19161949aa43c71493ed5530bf8dea6697d41418
Author: piers <piers>
Date:   Fri, 25 Jul 2008 09:58:44 +0800
Tag:    v1.8.7

MDL-11137 Unable to locate API error - force a sort order on the cmi elements, and ensure correct type comparison when determining whether we have seen this objective id before.  affects aicc, 1.2 and 1.3. propagate to 1.8.

commit 39a3b2af0f63463a6d76919e4e9448af0288fea9
Author: piers <piers>
Date:   Thu, 24 Jul 2008 09:44:29 +0800
Tag:    v1.8.7

MDL-9077 switch from client to server side validation for reference field as client side not supported for this type (file upload name) - propogate to 1.8.

commit 94446a8d68168cdc54dcfe92033624e23cb9c550
Author: piers <piers>
Date:   Thu, 24 Jul 2008 09:30:26 +0800
Tag:    v1.8.7

MDL-7323 AICC Import does not handle Core_Vendor + remove tabs and ambiguous else - propogated to 1.8.

commit b2c11833162f9ed406945d0bb495c607ac28b0f7
Author: piers <piers>
Date:   Fri, 18 Jul 2008 14:28:41 +0800
Tag:    v1.8.7

MDL-11892 Propogate Fixes for 'calls to expand javascript' to SCORM 1.2, and 1.3 code.