Git commits in Moodle 1.8.4 by tjhunt

commit 51f90f88393678e5dbecb7c969b45b4b41d9c002
Author: tjhunt <tjhunt>
Date:   Wed, 09 Jan 2008 03:28:51 +0900
Tag:    v1.8.4

MDL-12785 - Partially correct tick icon not displayed for MULTICHOICE, single answer questions. Fix thanks to Joseph Rzeau.

commit b12c6f2b1c4747eb85456eec136bb347f50a631f
Author: tjhunt <tjhunt>
Date:   Wed, 19 Dec 2007 01:12:27 +0900
Tag:    v1.8.4

MDL-12635 - Manual grading report does not check capabilites - also, only show the tabs for the reports people can access. Backported from MOODLE_19_STABLE.

commit bbe0467bff58c7eeb8e60a5889498b2239e06ee9
Author: tjhunt <tjhunt>
Date:   Thu, 13 Dec 2007 03:10:47 +0900
Tag:    v1.8.4

Fix Javascript error from essay questions on the review page.

commit b2744afe617eca5ad73084f2eb618ae8dd69869a
Author: tjhunt <tjhunt>
Date:   Wed, 12 Dec 2007 00:55:42 +0900
Tag:    v1.8.4

MDL-12542 - backup_todb not called on restore on date before it is inserted into mdl_user. This would cause a backup from a pre 1.7 site (or a pre 1.7 that has been upgraded to 1.9) to a 1.9 fresh install, to fail sometimes. Backported from MOODLE_19_STABLE.

commit 3b37251a8ae586ec3cb7057e77a385cb97a9d782
Author: tjhunt <tjhunt>
Date:   Wed, 21 Nov 2007 01:56:53 +0900
Tag:    v1.8.4

MDL-12282 - Numerical question type - the units are displayed on the editing form with a stupidly large number of decimal places.

commit 3a041e458c71448bef58e12a96201364e0b44392
Author: tjhunt <tjhunt>
Date:   Wed, 14 Nov 2007 23:48:13 +0900
Tag:    v1.8.4

Delete commented-out code that was actually not commented out properly, and so caused warnings.

commit c28f197deb88fb6fbd1bf56fa318b12208423dc6
Author: tjhunt <tjhunt>
Date:   Thu, 01 Nov 2007 02:08:38 +0900
Tag:    v1.8.4

MDL-10284 - wrong language string used on the quiz view page to inform students of the quiz deadline. I took the opportunity to strip out an unnecessary HTML table, and reviewing uses of the string /quiz(open|close)s?/ found one other inconsistency on the quiz editing form.

commit b63b4c2c1993c5453c3adac2b93578ede9bac33e
Author: tjhunt <tjhunt>
Date:   Thu, 01 Nov 2007 01:41:42 +0900
Tag:    v1.8.4

MDL-11624 - /mod/quiz/index.php too dependant on individual course format names. I basically changed it to do the same as the forum module.

commit cc701ed0214d9704d54eef33d0f1ec2fd7828ad4
Author: tjhunt <tjhunt>
Date:   Wed, 31 Oct 2007 03:22:28 +0900
Tag:    v1.8.4

MDL-9375 (and dups) - Each attempt builds on last with multi-page quizzes gives the wrong score on the second attempt. It turns out that this was already fixed in Moodle 1.9 (part of commit 1.115 -> 1.116) so I have just backported the relevant changes. I have tested that this fixes the reported problem. I have not had time to test that it does not break one of the other billion possible combinations of settings possible with the quiz. Code review and testing welcome.

commit 06ff2489ae2aaaf793d57319a12b30e92b4b989f
Author: tjhunt <tjhunt>
Date:   Wed, 31 Oct 2007 02:52:43 +0900
Tag:    v1.8.4

Fix notice.

commit aac7fcb6fe770b74b5c86544e0b4e0b991e30f7a
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 19:46:01 +0900
Tag:    v1.8.4

Unit tests for MDL-9295 - clean_param with PARAM_URL/PARAM_LOCALURL.

commit 9f34d8341a591714224516787767abfb5e7ee1e5
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 19:15:02 +0900
Tag:    v1.8.4

MDL-9295 - PARAM_URL/PARAM_LOCALURL does not accept http://localhost/ or other hosts on lans.

commit 921899fc203edec9cf0c3b89c55bcccd9e70b0ce
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 19:11:24 +0900
Tag:    v1.8.4

MDL-11462 fixed PARAM_URL inline focs, uncommented old regex in URL validation library - official TLD not required anymore. Backported from MOODLE_19_STABLE.

commit 2628f0bc161fc2b93caaea29f65a182a27dbafb6
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 00:25:09 +0900
Tag:    v1.8.4

MDL-11416 - Support for nonsortable columns in table lib. Backported from MOODLE_19_STABLE so that the fix for MDL-5262 works.

commit f312622c4e28e3a7f659ebedbadd27e68f9e16c7
Author: tjhunt <tjhunt>
Date:   Thu, 25 Oct 2007 17:42:19 +0800
Tag:    v1.8.4

MDL-11825 - Force penaltyfactor to 1 for truefalse questions on GIFT import, as is done on the editing form.

commit dc99997eac63b9976f0b9f008a8537ca2e2f7ab0
Author: tjhunt <tjhunt>
Date:   Tue, 23 Oct 2007 00:56:24 +0800
Tag:    v1.8.4

MDL-11708 - Zero answers are not allowed in Matching questions - sometimes I hate PHP.

commit 32a6bb301e90c0f70e235bdd5821b2b69cd471b3
Author: tjhunt <tjhunt>
Date:   Mon, 22 Oct 2007 23:36:50 +0800
Tag:    v1.8.4

MDL-11824 - Literal asterisk (\*) in shortanswer question not handled correctly by get_correct_responses + Unit tests.

commit 3c7d829b2236f5429b793aa9068ddfeffd69d420
Author: tjhunt <tjhunt>
Date:   Wed, 17 Oct 2007 05:26:38 +0800
Tag:    v1.8.4

MDL-5262 - PHP notice when sorting on R% coloumn in the Item analysis report - I adopted the simple solution of stopping people sorting on that column, since it is the same as sorting on rcount, I think. Backported from MOODLE_19_STABLE.