Sam probably, but he's off til the end of September I think.
Get him to send them over anyway, and I'm sure some-one'll have a look!
Get him to send them over anyway, and I'm sure some-one'll have a look!
The version I was using is in git://git.catalyst.net.nz/moodle-r2, with the ou blog branch merged in.
All the files refered to are in mod/oublog/
In the file lib.php, the function oublog_delete_instance makes a call to oublog_search_installed. But, oublog_search_installed is in locallib.php, which is not included in lib.php.
I will need to double check the next one; my skills at understanding commitdiff in git are still in development. In deletepost.php, around line 50, it should be class_exists('transaction_wrapper'), not class_exists(transaction_wrapper). $tw should also be set to null before the if statement to prevent warnings.
All the files refered to are in mod/oublog/
In the file lib.php, the function oublog_delete_instance makes a call to oublog_search_installed. But, oublog_search_installed is in locallib.php, which is not included in lib.php.
I will need to double check the next one; my skills at understanding commitdiff in git are still in development. In deletepost.php, around line 50, it should be class_exists('transaction_wrapper'), not class_exists(transaction_wrapper). $tw should also be set to null before the if statement to prevent warnings.
Seems the file got corrupted somehow. Here is the good patch. The other is in progress.
ack! Sorry for not responding to this earlier - I was away until yesterday (and have still not finished dealing with my emails).
I think I have actually fixed those bugs (at least first one). Catalyst's version of oublog is not the latest - we (OU) have been looking after it internally since they originally wrote and delivered it.
I am hoping to really, truly, honestly release oublog - complete with quite a few bugfixes since the catalyst version, as it's actually live on our systems so has seen at least a little bit of real use now. The official location for it will be in Moodle contrib cvs. I know I've promised it a lot but I'm about to actually start working on it right now... so maybe today...
[Thanks to Jenny for pointing out this post to me.]
--sam
I think I have actually fixed those bugs (at least first one). Catalyst's version of oublog is not the latest - we (OU) have been looking after it internally since they originally wrote and delivered it.
I am hoping to really, truly, honestly release oublog - complete with quite a few bugfixes since the catalyst version, as it's actually live on our systems so has seen at least a little bit of real use now. The official location for it will be in Moodle contrib cvs. I know I've promised it a lot but I'm about to actually start working on it right now... so maybe today...
[Thanks to Jenny for pointing out this post to me.]
--sam
OK - that went better than I thought. (I was expecting problems when I ran it on MySQL and without all the OU extensions, but in fact I only spotted two minor issues which were easily solved.)
oublog is now sort of released
But the page in the plugin database hasn't been approved yet and the download link won't work quite yet. So I'll post about it tomorrow by which time it hopefully will all be in place. If anyone's really desperate to get it THIS INSTANT though, look in contrib cvs, MOODLE_19 branch, plugins/mod/oublog.
--sam
oublog is now sort of released
--sam
Thanks Sam, your OU blog entry is now approved. 
Is there a public SCM repo where we can track your changes, commit by commit?
Tarun is basing his work on your, and I will be wanting to do the same. Relying on blind updates forces us to do a ton of stupid work, and we cannot see your commits to understand the reasons behind the changes. It's like coding in the dark ages
Tarun is basing his work on your, and I will be wanting to do the same. Relying on blind updates forces us to do a ton of stupid work, and we cannot see your commits to understand the reasons behind the changes. It's like coding in the dark ages
Sorry Martin (and Tarun, again) - until yesterday I didn't realise anyone from Catalyst still had any involvement in it or intended to use it elsewhere. I thought you'd delivered it and that was that!
There isn't public access to our own CVS unfortunately. And as you've seen, my normal practice with contrib code has been to update things in a single chunk after it's been through our internal release testing.
However for OU blog I could try to apply all my patches to Moodle contrib cvs immediately at the same time I apply them into our local one? That should work for minor changes - I'm not expecting to make any major ones in the near future. (Incidentally, I use the MOODLE_19 branch in contrib, not HEAD).
Would that help or is a better solution necessary?
Welcome to the dark ages.
--sam
There isn't public access to our own CVS unfortunately. And as you've seen, my normal practice with contrib code has been to update things in a single chunk after it's been through our internal release testing.
However for OU blog I could try to apply all my patches to Moodle contrib cvs immediately at the same time I apply them into our local one? That should work for minor changes - I'm not expecting to make any major ones in the near future. (Incidentally, I use the MOODLE_19 branch in contrib, not HEAD).
Would that help or is a better solution necessary?
Welcome to the dark ages.
--sam
That'll definitely help while we wait for a generally better SCM to come our way 
- thanks!
And my bad, I should have mentioned more loudly that I was encouraging Tarun to base his work on OUBlog
"I need a course-centric blog" is a common request I hear, and I point people to oublog, if they plan to do development, even better.
Might be a good chance for you to have a quick check of the Edublog plans / goals (Edublog is Tarun's project) -- some of the patches might be of interest to you.
Tarun was talking about cleaning up the patches (which are in a one big messy commit, so I was asking him for small well commented patches too). If you think there's interest in merging some of his work, more reason for Tarun to do the clean up
(And more reason for me to help him!)
And my bad, I should have mentioned more loudly that I was encouraging Tarun to base his work on OUBlog
"I need a course-centric blog" is a common request I hear, and I point people to oublog, if they plan to do development, even better.
Might be a good chance for you to have a quick check of the Edublog plans / goals (Edublog is Tarun's project) -- some of the patches might be of interest to you.
Tarun was talking about cleaning up the patches (which are in a one big messy commit, so I was asking him for small well commented patches too). If you think there's interest in merging some of his work, more reason for Tarun to do the clean up
(And more reason for me to help him!)
Thanks.
Edublog looks like a heavily overloaded name! However I managed to find information about the changes. So basically it is designed so that you can use a modified oublog as a sort of staging post before putting content on a 'real' external blog such as Blogger etc? And either do this automatically or with teacher review.
My opinion:
1) Assuming it works fine for a local blog, the teacher review option sounds great. That sounds like something that should be in the standard system as I can definitely see it being desirable [as an option] by many other people, we might even use it internally. If the code quality is high, I'd be interested in a patch for this (please not this week or next though as I am snowed under
Only thing I don't like is the name, since it might not be 'teacher' doing the reviewing (presumably whoever has the capability). Obviously we don't use the word teacher here, it's tutor, but leaving that aside, for instance you could have a group blog of a number of academics in a faculty, where one academic is designated as the editor of the blog and will verify posts before they appear. I might prefer 'Send for review' to 'Send to teacher', etc. Just a language string issue though.
2) Maybe I could be convined but I am not so sure about the synchronize-to-remote-blog feature. This sounds a bit complicated and specialist (given that the oublog can already be a public blog, and already has RSS/Atom feeds that could be aggregated elsewhere). I'm assuming that this is maybe done because it is a 'push' operation and there are network issues related to the OLPC project?
--sam
PS Apologies if this is the wrong place to discuss this (probably is, but I thought maybe other people might be interested in the summary of the edublog thing). Obviously I can be contacted by email / moodle PM etc.
Edublog looks like a heavily overloaded name! However I managed to find information about the changes. So basically it is designed so that you can use a modified oublog as a sort of staging post before putting content on a 'real' external blog such as Blogger etc? And either do this automatically or with teacher review.
My opinion:
1) Assuming it works fine for a local blog, the teacher review option sounds great. That sounds like something that should be in the standard system as I can definitely see it being desirable [as an option] by many other people, we might even use it internally. If the code quality is high, I'd be interested in a patch for this (please not this week or next though as I am snowed under
Only thing I don't like is the name, since it might not be 'teacher' doing the reviewing (presumably whoever has the capability). Obviously we don't use the word teacher here, it's tutor, but leaving that aside, for instance you could have a group blog of a number of academics in a faculty, where one academic is designated as the editor of the blog and will verify posts before they appear. I might prefer 'Send for review' to 'Send to teacher', etc. Just a language string issue though.
2) Maybe I could be convined but I am not so sure about the synchronize-to-remote-blog feature. This sounds a bit complicated and specialist (given that the oublog can already be a public blog, and already has RSS/Atom feeds that could be aggregated elsewhere). I'm assuming that this is maybe done because it is a 'push' operation and there are network issues related to the OLPC project?
--sam
PS Apologies if this is the wrong place to discuss this (probably is, but I thought maybe other people might be interested in the summary of the edublog thing). Obviously I can be contacted by email / moodle PM etc.
Thanks for helping out!
About point 1)
As Martin mentioned, I'm in the process of cleaning up my code, and I hope I can meet Moodle (and your) coding standards with a patch for the teacher review when finished with clean up.
About point 2)
You're right, the feature is there so the XS won't have to act as a web host for the blogs.
About point 1)
As Martin mentioned, I'm in the process of cleaning up my code, and I hope I can meet Moodle (and your) coding standards with a patch for the teacher review when finished with clean up.
About point 2)
You're right, the feature is there so the XS won't have to act as a web host for the blogs.
I'm assuming that this is maybe done because it is a 'push' operation and there are network issues related to the OLPC project?
Spot on
School servers are behind NAT -- as you say, a "network issue"!