David Scotson

It's a Moodle+Bootstrap specific hack. There's a comment slightly above that, with a fuller explanation.

In Moodle the label tag is beside the radio/checkbox, but in Bootstrap they wrap the label tag around the radio/checkbox (and in version 3 they then wrap another div around that to help lay it out correctly).

So the ideal solution (from my perspective) would be for Moodle's checkboxes and radio buttons to be wrapped within the label tag (and for BS3 another div), as that gives you better HTML to work with, and can then simply inherit the Bootstrap CSS. (Note that in the past this was considered less accessible, I think that's why Moodle does it the way it does it, but is now (very slightly) more accessible).

Bootstrap puts a lot of time and effort into making all the form elements line up nicely, Moodle not so much. Getting the (various, all slightly different) Moodle forms layouts to look the same as Bootstrap was a ridiculous amount of work, and in the end it involved a lot of black magic like the dodgy hack commented above. As a result it's a bit of a house of cards, I personally wouldn't touch it, and focus on trying to get Moodle's form HTML standardised instead.

I think that value is overridden in many places anyway, so e.g. if you're saying "this looks better" or "that looks better" you'd probably be best to specify exactly which page of Moodle and which specific checkbox you are referring to (and double check that all the other ones haven't been affected by your proposed change).

I'm not sure what does it, but when in maintenance/upgrade/install the core_renderer gets swapped with core_renderer_maintenance (and not core_maintenance_renderer as the documentation in the theme/upgrade.txt calls it).

To achieve what I want, I want to extend this renderer in my theme the same way as I intend to extend the normal core_renderer (an unfortunate bit of code duplication, but there appear to be reasons for this). I've not tried it yet but I assume it will work, I just have to be careful.

Thanks Mary,

it's not that exactly, but I think it's related. The bit of comment text that says "It's ultra important that this layout file makes no use of API's unless it absolutely needs to.", I seem to recall that got enforced by some code that swaps out theme renderers with other ones and that's what I'm hitting.

By looking up that bug, I found a link to this related bug which is what I was looking for,

https://tracker.moodle.org/browse/MDL-42057

regards,

dave

Hi all,

I seem to recall that recently some work being done broke upgrade and install, and as a result now renderers get overidden in some special way during updates.

Does anyone know about this, or can point me to somewhere documenting this? I've tried Googling but I'm not finding anything relevant. Currently I seem to get upgrade screens that are half my theme, and half... something else.

In my experience IE8 (and IE9) only hang around on Windows 7 when there's someone actively stopping the updates and in education generally they don't have that much control. This makes it much less of an issue than XP, though of course every case is different and it's best to track your own users via analytics to help decision making.