FYI I've now merged in the changes from the latest version of Bootstrap, 2.10
http://blog.getbootstrap.com/2012/08/20/bootstrap-2-1-0-released/
David Scotson
Posts made by David Scotson
I've just noticed, when looking at the new Bootstrap version announcement, that their reset.css is modular since they re-use a 3rd party project. This means it should be fairly easy to remove this duplication. Still low on the todo list though.
Comparing the YUI reset and the Bootstrap reset and getting rid of any duplication is on the todo list, but rather far down it at the moment.
The Javascript parts of Bootstrap are using JQuery:
http://twitter.github.com/bootstrap/javascript.html
But there's a (work-in-progress) YUI port too:
http://jshirley.github.com/bootstrap/javascript.html
So far, it's not really the YUI stuff that's been causing me any trouble to be honest.
The Javascript parts of Bootstrap are using JQuery:
http://twitter.github.com/bootstrap/javascript.html
But there's a (work-in-progress) YUI port too:
http://jshirley.github.com/bootstrap/javascript.html
So far, it's not really the YUI stuff that's been causing me any trouble to be honest.
Thanks for your interest. I've merged your changes (or at least the ones independant of your theme) and created a place on github for it:
https://github.com/ds125v/moodle-bootstrap
Currently all the changes are in theme/bootstrap and theme/simple (a sketch of an HTML5-ized base theme that inherits from bootstrap and which I inherit in turn for our institution's theme) but I've cloned the whole Moodle as I intend to start contributing fixes to core after we launch our new Moodle. There's simply not the time to do it now, but hopefully by the time we upgrade next year I can delete a bunch of the workarounds since they'll be fixed in the core code.
If there's anything that you feel is inappropriate for the bootstrap.css if you're building a theme on top, you can let me know (or just delete it and I'll pick up the changes again) and I'll move it into the Simple theme instead. I've not always been as careful as I should about which of the three themes items belong in. Bootstrap is intended to fit in under other people's themes so more major visual changes should be in Simple and I've got a few things in our Uni theme that can probably be generalised out to one of the others too.
The biggest change since the zip I uploaded is that I stopped inheriting core.css, as I was spending to much time overriding it. I included my own copy instead and started tidying it up by just deleting the lines that I was previously overriding. (I also deleted all the rtl stuff just so I get a better overview of what's left, I'll add that back in later, but I can't test it right now)
https://github.com/ds125v/moodle-bootstrap
Currently all the changes are in theme/bootstrap and theme/simple (a sketch of an HTML5-ized base theme that inherits from bootstrap and which I inherit in turn for our institution's theme) but I've cloned the whole Moodle as I intend to start contributing fixes to core after we launch our new Moodle. There's simply not the time to do it now, but hopefully by the time we upgrade next year I can delete a bunch of the workarounds since they'll be fixed in the core code.
If there's anything that you feel is inappropriate for the bootstrap.css if you're building a theme on top, you can let me know (or just delete it and I'll pick up the changes again) and I'll move it into the Simple theme instead. I've not always been as careful as I should about which of the three themes items belong in. Bootstrap is intended to fit in under other people's themes so more major visual changes should be in Simple and I've got a few things in our Uni theme that can probably be generalised out to one of the others too.
The biggest change since the zip I uploaded is that I stopped inheriting core.css, as I was spending to much time overriding it. I included my own copy instead and started tidying it up by just deleting the lines that I was previously overriding. (I also deleted all the rtl stuff just so I get a better overview of what's left, I'll add that back in later, but I can't test it right now)
So, in the Theme settings there is an option to Allow category themes, but it's off by default and it comes with this scary but vague warning: "WARNING: Enabling category themes may affect performance."
Does anyone know how and why it affects performance? I'll have a look at the code to see if I can see what's happening but before doing so I can't think why this particular theme mode would be different from allowing user themes, course themes, or url themes, none of which have this warning. (Site designer mode also has a warning, but it's reloading the themes every time in case you've edited them, so its performance impact is fairly obvious).
I'm specifically interested in Moodle 2.3, my other option is to do things the way we did it in 1.9 which was to add code to the theme which would hit the database and add a CSS class of the root category (just as Moodle currently adds the current category as a class to the body). If I'm going to do that kind of work, I'd rather just fix the performance problem, assuming that's even possible.
Does anyone know how and why it affects performance? I'll have a look at the code to see if I can see what's happening but before doing so I can't think why this particular theme mode would be different from allowing user themes, course themes, or url themes, none of which have this warning. (Site designer mode also has a warning, but it's reloading the themes every time in case you've edited them, so its performance impact is fairly obvious).
I'm specifically interested in Moodle 2.3, my other option is to do things the way we did it in 1.9 which was to add code to the theme which would hit the database and add a CSS class of the root category (just as Moodle currently adds the current category as a class to the body). If I'm going to do that kind of work, I'd rather just fix the performance problem, assuming that's even possible.