What does "available to the community" mean in this context? The stuff I've done is available on github and there's a link (in the dropdown menu approprately enough to the source code). And although it's not a pre-packaged theme available for end-users to install, I'm very happy if the people creating those kind of themes (or Moodle core, or people creating their own them, or anyone really) re-uses the stuff I've done, in fact that's kind of the point as i don't really want to have to test and support it all myself, and more uses means less bugs.
David Scotson
Posts made by David Scotson
My custom menu renderer based on Bootstrap does multiple levels.
You can see it in action here:
http://moodle.iyware.com/?theme=bootstrap_renderers
On the other hand, I personally wouldn't even use 2 level menus if I could avoid it, and thought about only supporting a single level, but I'm trying to stick close to what people expect from Moodle (and/or Bootstrap) before going off and trying anything radical based on my opinions.
You can see it in action here:
http://moodle.iyware.com/?theme=bootstrap_renderers
On the other hand, I personally wouldn't even use 2 level menus if I could avoid it, and thought about only supporting a single level, but I'm trying to stick close to what people expect from Moodle (and/or Bootstrap) before going off and trying anything radical based on my opinions.
I'm just in the process of installing this now, as it sounds like something I've been looking for for a while.
Yes, this looks very handy, already spotted one issue thanks to it and can see it's going to save me a bunch of time.
Where did you come up with the list of styles to include e.g. I never knew about table.invisible or a.link-as-button. Are you automatically generating these in some way or is it just a list of ones you've learned about over time?
I've also been trying to approach this problem from the opposite direction. I think that if you provide two or three radically different themes, that all expect the same core HTML, then it become easier for the developers to see if their code is working as expected. If you have only one theme, or a lot of very similar themes then it's easy for bugs to slip through because it "looks" okay e.g. not using the right classname, but faking the same visual appearence with inline styles.
I've also (in various MDL tracker issues) advocated adopting Bootstrap's conventions whenever the current practice is using many different styles and classes.
edit: you appear to have a small bug in notifications.php and pagelayouts.php where it's not looking in the right place for config.php.
Yes, this looks very handy, already spotted one issue thanks to it and can see it's going to save me a bunch of time.
Where did you come up with the list of styles to include e.g. I never knew about table.invisible or a.link-as-button. Are you automatically generating these in some way or is it just a list of ones you've learned about over time?
I've also been trying to approach this problem from the opposite direction. I think that if you provide two or three radically different themes, that all expect the same core HTML, then it become easier for the developers to see if their code is working as expected. If you have only one theme, or a lot of very similar themes then it's easy for bugs to slip through because it "looks" okay e.g. not using the right classname, but faking the same visual appearence with inline styles.
I've also (in various MDL tracker issues) advocated adopting Bootstrap's conventions whenever the current practice is using many different styles and classes.
edit: you appear to have a small bug in notifications.php and pagelayouts.php where it's not looking in the right place for config.php.
Hi Tim,
is there somewhere I can read more about the Selenium testing, I'd like to get it running locally against our specific deployed hardware/software combo as part of a local CI system.
regards,
dave
is there somewhere I can read more about the Selenium testing, I'd like to get it running locally against our specific deployed hardware/software combo as part of a local CI system.
regards,
dave
The URLs can probably just be replaced with any URL that points to an image, if that's the part that's not working for you.
Actually, nevermind, on closer reading the URLs are currently hardcoded with that implementation.
Actually, nevermind, on closer reading the URLs are currently hardcoded with that implementation.