Moodle Plugins directory: PDF submission: Comments

Friday, 17 December 2021, 1:55 AM - Davo Smith

Thu, 16 Dec 2021 17:55:30 GMT

by Davo Smith.

Quoc Bao Tran - could you explain what your comment has to do with my plugin? Are you saying that the assignsubmission_pdf plugin destroyed all your data when you ran it within docker? That seems extremely unlikely.

Anyway - if you do think my plugin is at fault, please be aware that I've been recommending not to use my plugin for several years now, so please use the core PDF annotation instead.

Friday, 17 December 2021, 1:52 AM - Quoc Bao Tran

Thu, 16 Dec 2021 17:52:09 GMT

by Quoc Bao Tran.

admin/index.php?cache=0&confirmrelease=1&confirmplugincheck=0&confirmupgrade=1 , Too bad I had to reinstall the system and accept to lose all data because I built moodle on Docker and couldn't interfere with the code

Thursday, 27 April 2017, 12:21 AM - Davo Smith

Wed, 26 Apr 2017 16:21:55 GMT

by Davo Smith.

@Jon - glad you found a solution for hiding my plugin, without disabling it fully.

Wednesday, 26 April 2017, 12:43 AM - Jon Shaw

Tue, 25 Apr 2017 16:43:58 GMT

by Jon Shaw.

Hello Davo,

I had another look at this and remembered the visibility property. So I came up with this styling (added to General block of Eguru) which allows the page to generate the controls and either removes them from layout or simply hides them. It appears to allow the system to continue to function normally, keeping the PDF plugins enabled, but disallowing instructors from creating those assignment submission and feedback types.

input#id_assignsubmission_pdf_enabled {display:none;}
label[for="id_assignsubmission_pdf_enabled"] {visibility:hidden;}
input#id_assignfeedback_pdf_enabled {display:none;}
label[for="id_assignfeedback_pdf_enabled"] {visibility:hidden;}
div#fitem_id_assignsubmission_pdf_maxfiles {display:none;}
div#fitem_id_assignsubmission_pdf_maxsizebytes {display:none;}
div#fitem_id_assignsubmission_pdf_coversheet {display:none;}
div#fitem_id_assignsubmission_pdf_templateid {display:none;}
div#fitem_id_assignsubmission_pdf_template_edit {display:none;}

I don't know if I'm missing something, so I just wanted to let you know I have this working and if all's well for anyone else that this might help.

Thanks,

Jon

Tuesday, 25 April 2017, 9:48 PM - Jon Shaw

Tue, 25 Apr 2017 13:48:55 GMT

by Jon Shaw.

Hello Davo,

I found out the hard way we can't just disable the PDF plugins. When we did that, the previews (and pdf submitted file links) vanished after a short period of time, so now we will probably have to resubmit submissions into the unoconv table for processing. We have enabled the PDF plugins.

I was wondering about an alternative approach. I have been searching but unable to find the code that controls the creation of the form for adding an assignment such as it pertains to your submission and feedback plugins. Perhaps where you extend classes? I would like to "display;none;" the spans or the inputs / labels that allow instructors to create these type of assignments (submission type and feedback type). Our plan is to keep the plugin enabled until the existing assignments cycle out of our system, so that instructors use the core File submission option instead.

I tried applying CSS in our Eguru theme General settings and can hide the input checkbox but the label is "stubborn" and resists invisibility. So perhaps there's a CSS file or two I could modify?

We are on version 3.1.

Please advise.

Thanks,

Jon

Thursday, 24 November 2016, 4:49 AM - Davo Smith

Wed, 23 Nov 2016 20:49:58 GMT

by Davo Smith.

Automated tests (contained in assignfeedback_pdf) are all passing in Moodle 3.2

Tuesday, 1 November 2016, 11:18 PM - Bei Chapman

Tue, 01 Nov 2016 15:18:03 GMT

by Bei Chapman.

Ok, no problem. Thanks Davo.

Tuesday, 1 November 2016, 11:03 PM - Davo Smith

Tue, 01 Nov 2016 15:03:24 GMT

by Davo Smith.

Sorry I can't remember exactly how it reaches each status (it has been a long time since I wrote this plugin and I rarely do any work on it these days). You'd have to take a look through the code to work out what that status means.

Tuesday, 1 November 2016, 11:01 PM - Bei Chapman

Tue, 01 Nov 2016 15:01:08 GMT

by Bei Chapman.

Hi Davo,

Thank you so much for the quick response.

Yes, I was asking for PDF submission status in the M_ASSIGNSUBMISSION_PDF table

What situation will cause the following case: PDF submission status=3 (empty) but the contenthash value still valid/exist (I can retrieve that particular pdf file from moodledata filedir no problem)?

Cheers,
Bei

Tuesday, 1 November 2016, 10:35 PM - Davo Smith

Tue, 01 Nov 2016 14:35:24 GMT

by Davo Smith.

What status do you mean? There are at least 3 status values I can find from a quick search of the code (the submission status, the pdf submission status and the ghostscript ready status).

Assuming it is the PDF submission status, they are listed here:
https://github.com/davosmith/moodle-assignsubmission_pdf/blob/master/lib.php#L39

Tuesday, 1 November 2016, 10:31 PM - Bei Chapman

Tue, 01 Nov 2016 14:31:29 GMT

by Bei Chapman.

Hi,

Can anyone out there tell me what the status values mean? For example, status=1 or status=3?

Thanks,
Bei

Wednesday, 12 October 2016, 3:42 AM - Laurent Labidi

Tue, 11 Oct 2016 19:42:23 GMT

by Laurent Labidi.

Hello Davo

Thanks for the tips...i had the same pb than Jürg.

Good job !

Tuesday, 27 September 2016, 4:22 AM - Davo Smith

Mon, 26 Sep 2016 20:22:18 GMT

by Davo Smith.

I think that is a bug in Moodle, because the two plugins depend on each other, so you can never uninstall one without the other complaining. I suggest you edit the version.php file for one (or both) of the plugins and delete the '$dependencies' section at the bottom of the file - you should then be able to delete one, then the other plugin.

Tuesday, 27 September 2016, 4:18 AM - Jürg Hoerner

Mon, 26 Sep 2016 20:18:22 GMT

by Jürg Hoerner.

This is not possible in my installation: PDF submission and PDF Feedback are the only two plugins, with no uninstall Link.

Tuesday, 27 September 2016, 3:39 AM - Davo Smith

Mon, 26 Sep 2016 19:39:08 GMT

by Davo Smith.

You should be able to uninstall from the plugins overview page - then delete the code from the directories on your server.