Moodle Plugins directory: YuJa Verity: Comments

Friday, 9 June 2023, 8:28 AM - Dan Marsden

Fri, 09 Jun 2023 00:28:56 GMT

by Dan Marsden.

Great to hear that was addressed - hopefully we'll look at this again soon. Thanks for your patience with the plugin review team!

Friday, 9 June 2023, 8:17 AM - Kline Boudreau

Fri, 09 Jun 2023 00:17:03 GMT

by Kline Boudreau.

@dan -

"I also think we'll need to have an internal conversation about your hard-coded english language check against the assignment name and if that's something we can allow in the plugins db - It would probably have been better for you to implment this correctly as a quiz access rule and allow a teacher to enable/disable the functionality using a setting in the quiz (like how a quizaccess rule is supposed to work.) rather than having a local plugin that checks the name of the quiz and adds the js to the page."

Have you looked at the new submission? It no longer checks (reconfirmed with the engineer today) the name of the quiz.

Friday, 9 June 2023, 5:23 AM - Dan Marsden

Thu, 08 Jun 2023 21:23:11 GMT

by Dan Marsden.

@Kline - the plugins review team are all volunteers, you have been lucky to get some early reviews of your code, and you've had "more reviews" than many of the others in the queue that have been waiting a couple of months for their first review. You will need to be patient with us. I also think we'll need to have an internal conversation about your hard-coded english language check against the assignment name and if that's something we can allow in the plugins db - It would probably have been better for you to implment this correctly as a quiz access rule and allow a teacher to enable/disable the functionality using a setting in the quiz (like how a quizaccess rule is supposed to work.) rather than having a local plugin that checks the name of the quiz and adds the js to the page.

Friday, 9 June 2023, 3:10 AM - Kline Boudreau

Thu, 08 Jun 2023 19:10:34 GMT

by Kline Boudreau.

Hello, please provide a status update.

Wednesday, 7 June 2023, 12:01 AM - Plugins bot

Tue, 06 Jun 2023 16:01:26 GMT

by Plugins bot.

Approval issue created: CONTRIB-9294

Wednesday, 7 June 2023, 12:00 AM - Kline Boudreau

Tue, 06 Jun 2023 16:00:27 GMT

by Kline Boudreau.

Dan - In the previous contribution, I could not change the plugin type. So I created this new installation with the updated plugin and code changes you specified.