Moodle Plugins directory: Recommendation letters and appraisals: Comments

Monday, 16 October 2017, 5:27 AM - Damilola Adegoke

Sun, 15 Oct 2017 21:27:09 GMT

by Damilola Adegoke.

This is a wonderful plugin but unlike other recommendation system, this particular plugin does not send email directly to the recommender. All requests have to be approved first by the teachers before the recommendation request is sent to the referee. In case you have like 200 requests, it would be awkward having to approve all 200 one after the other before request messages are sent to the referees. Is there any way out of this problem>

Monday, 29 August 2016, 7:26 PM - David Mudrák

Mon, 29 Aug 2016 11:26:40 GMT

by David Mudrák.

Thanks Ivan for the detailed peer-review and thanks Marina for the replies. Please note the plugin has been put into the "needs more work" status. Once you believe all raised issues were addressed, do not forget to schedule it for re-approval. Thanks for your patience with the review and approval process.

Saturday, 27 August 2016, 7:48 PM - Marina Glancy

Sat, 27 Aug 2016 11:48:10 GMT

by Marina Glancy.

regarding coding style errors - I commented out the grading code generated by "newmodule" because I want to implement grading later. If I remove these comments it will be harder for me to restore this code later

Saturday, 27 August 2016, 7:42 PM - Marina Glancy

Sat, 27 Aug 2016 11:42:39 GMT

by Marina Glancy.

Thanks for review Ivan. I am aware of the radio buttons setup and I have a "todo" for myself but I created a proper issue now: https://github.com/marinaglancy/moodle-mod_recommend/issues/1
Regarding the autosave error on the guest form - it is a [known] problem with Atto. I knew about it for a long time but could not find an issue now and had to create a new one - MDL-55744

Saturday, 27 August 2016, 12:23 AM - ivan matviyuk

Fri, 26 Aug 2016 16:23:35 GMT

by ivan matviyuk.

Thanks David.

Marina, can you please review my notes above? As already stated, there is nothing serious, but maybe you will find something to improve, including the coding style errors, which seems to be very easy to do

Best regards,
Ivan

Saturday, 27 August 2016, 12:17 AM - David Mudrák

Fri, 26 Aug 2016 16:17:47 GMT

by David Mudrák.

Hi Ivan. Sure, I was going to wait, I did not mean it as a final comment - sorry for not being clear. Using github for tracking individual issues just seems to work better for keeping track and focus than replying to comments here - for both us and the maintainer (who can mark such issues as resolved or keep them open for working on them later).

Friday, 26 August 2016, 11:38 PM - ivan matviyuk

Fri, 26 Aug 2016 15:38:57 GMT

by ivan matviyuk.

Hi David,
I have not finished my review yet, could you please wait until i report that explicitly?
I did not report any of issues i found in the bug tracker as i do not think they are real issues, rather my doubts and notes for Marina
Thanks,
Ivan

Friday, 26 August 2016, 11:34 PM - David Mudrák

Fri, 26 Aug 2016 15:34:56 GMT

by David Mudrák.

Thanks Marina for sharing this plugin with the community, and thanks Ivan for the detailed peer-review. So far none of the reported issues sounds like a blocker for the plugin approval. Ivan, can you please report such findings as individual issues into the plugin's issue tracker? Thanks in advance.

Friday, 26 August 2016, 10:31 PM - ivan matviyuk

Fri, 26 Aug 2016 14:31:51 GMT

by ivan matviyuk.

And, when opening the question the very first time to give recommendation, an WYSWIG editor reports "Unfortunately the draft version could not be restored."

Friday, 26 August 2016, 10:18 PM - ivan matviyuk

Fri, 26 Aug 2016 14:18:23 GMT

by ivan matviyuk.

Hi Marina,
Another thing, the email the plugin sends, is multipart mime type that contains text/plain and text/html messages, and in the text message the html line break tags < br /> are present
Ivan

Friday, 26 August 2016, 10:07 PM - ivan matviyuk

Fri, 26 Aug 2016 14:07:33 GMT

by ivan matviyuk.

Hi Marina,
I'm having a usage issue with the plugin. In the Edit question -> add question -> Collection of radio buttons -> help for Options it says,
"Specify one option per line, prefix each line with the weight and / sign"
Now, "weight" becomes not obvious, as when i add 4 options with weight 1, they all are reported as checked when a person giving the recommendation selects any one of them
Apparently, they (weights) must be unique as they are used as indexes, but here the question is - why specifying them at all as it can be the line numbers?
If it still makes sense (so they are the weights and the weights cannot be same), a change to the help is needed
Ivan

Friday, 26 August 2016, 8:05 PM - ivan matviyuk

Fri, 26 Aug 2016 12:05:55 GMT

by ivan matviyuk.

Hi Marina,
I'm starting reviewing your plugin on behalf of Moodle plugin guardians. I should get back with results later on today
Regards,
Ivan

Friday, 26 August 2016, 7:28 PM - Plugins bot

Fri, 26 Aug 2016 11:28:43 GMT

by Plugins bot.

Prechecker results: 6 errors/15 warnings
https://integration.moodle.org/job/Precheck%20remote%20branch/26681/artifact/work/smurf.html