Moodle Plugins directory: SavaPage: Comments

Friday, 26 August 2016, 9:37 PM - David Mudrák

Fri, 26 Aug 2016 13:37:49 GMT

by David Mudrák.

Thanks Rijk for providing an updated version promptly. The block implementation seems pretty straightforward and even if it does not follow the recommended coding guidelines for Moodle plugins much, it hopefully should not break things (as in fact all it does is just redirecting to configured host. Here are the most obvious parts you might want to implement / fix yet:

There is a PHP notice thrown on line 55 of block_savapage.php script, please make sure to have developer debugging on when developing for Moodle avoid any PHP notices and warnings.
The functions in view.php would better look if they were part of included locallib.php with correct name prefix - https://docs.moodle.org/dev/Plugin_contribution_checklist#Namespace_collisions
Please consider adding https://docs.moodle.org/dev/Plugin_files#thirdpartylibs.xml for the XML-RPC library shipped with the code

With the hope these issue will be addressed soon, you are cleared to land now. Welcome to the Plugins directory.

Thursday, 18 August 2016, 8:06 PM - David Mudrák

Thu, 18 Aug 2016 12:06:26 GMT

by David Mudrák.

Hi Rijk. Thanks for sharing the plugin with the Moodle community. Beside the question raised by Tomek above, I have to add couple of notes.

Bug tracker is not specified for your plugin. Providing a place for users of your plugin to report issues encourages participation and provides a way for users (and us, reviewers) to report bugs, make feature requests, or suggest other types of improvements.
The block claims to support Moodle 2.0 only. Please test it on recent Moodle versions and select such versions as supported. Only then we can also execute the formal code prechecker which is part of the plugin approval review.
Please pay attention to the naming guidelines set for Moodle plugins. Your global settings are currently named like savapage/HOST. They must start with a valid frankenstyle component and usually are in lowercase (so the expected would be block_savapage/host).
Hard-coded English strings like "User Web App" should be provided via proper language pack string.

For now I am marking this as needing more work. Thanks for your patience with the review and approval process.

Tuesday, 9 August 2016, 1:30 AM - Tomasz Muras

Mon, 08 Aug 2016 17:30:57 GMT

by Tomasz Muras.

Hi Rijk,

Do I need to install my SavaPage server to test your plugin? Or would you have some "demo" account on a server to which I can connect?

Tomek