Moodle Plugins directory: Remlab manager: Comments

Monday, 16 November 2020, 12:16 PM - Zenke Nersnke

Mon, 16 Nov 2020 04:16:19 GMT

by Zenke Nersnke.

Remlab manager, Let's start to find those platforms from where we all can easily move our royalessays stages. No one force us to move from here because i don't like this style, But i only know this that you can do all which no other one can do for you.

Friday, 26 August 2016, 9:08 PM - Luis de la Torre

Fri, 26 Aug 2016 13:08:48 GMT

by Luis de la Torre.

Thanks, David. It's nice to be here!

Friday, 26 August 2016, 9:01 PM - David Mudrák

Fri, 26 Aug 2016 13:01:48 GMT

by David Mudrák.

Thanks Luis for the nice words. And thanks for providing the updated version promptly. I am going to approve it now. You are cleared to land, welcome to the Plugins directory.

Monday, 22 August 2016, 5:22 PM - Luis de la Torre

Mon, 22 Aug 2016 09:22:09 GMT

by Luis de la Torre.

Dear David,

Thank you so much for your comments and help for improving the plugin. And thank you for creating/updating the wiki page with the information about CSRF protection (I noticed it was last edited on August 18th). It was very, very helpful!

You are right about the dependency of the EJSApp activity module. I just uploaded a newer version (the one required now by the Remlab Manager block). I have also uploaded a new version of the Remlab Manager plugin with the changes that solve the two issues you noticed.

Again, thanks a lot for everything. I think you are doing an outstanding job with Moodle's plugins section and for the plugins community.

Friday, 19 August 2016, 7:21 PM - David Mudrák

Fri, 19 Aug 2016 11:21:57 GMT

by David Mudrák.

Thanks Luis for providing the fixed version quickly.

I am a bit worried about the dependency on the EJSApp activity module. This block declares minimal required version of mod_ejsapp as 2016080400. However, that version is only available at github and was not officially released here in the plugins directory. As a consequence, the in-built plugin installer in moodle can't fulfil the dependency and it fails to install this block. As you are one of the maintainers of EJSApp module, you probably want to release that new version first.

While looking at the code again, I noticed missing CSRF protection in your action links. I reported this security issue into your tracker.

I'll be happy to approve this block once these issues are fixed.

p.s. It is discouraged to make other already approved plugins depending on a plugin not yet available in the plugins directory as you did with the EJSApp Booking System. You can put users of your plugin into troubles when they are upgrading their sites. Thanks for understanding.

Wednesday, 13 July 2016, 9:56 PM - David Mudrák

Wed, 13 Jul 2016 13:56:53 GMT

by David Mudrák.

Thanks Luis for sharing the block with the community. I am afraid I cannot approve it now due to serious issues detected in the code. Please see you issues tracker for details. All the issues #1 (direct access to the superglobal $_SESSION), #2 (tables names and installation) and #3 (lack of access permission control) block the approval now so I am marking this plugin as requiring more work. Thanks for your understanding and the patience with the review and approval process.

Friday, 1 July 2016, 5:25 PM - Plugins bot

Fri, 01 Jul 2016 09:25:49 GMT

by Plugins bot.

Prechecker results: 332 errors/89 warnings
http://integration.moodle.org/job/Precheck%20remote%20branch/24828/artifact/work/smurf.html