Moodle Plugins directory: EEXCESS Editor: Comments

Thursday, 2 June 2016, 2:58 PM - David Mudrák

Thu, 02 Jun 2016 06:58:56 GMT

by David Mudrák.

Thanks guys to both for sorting things out. I am happy to approve the plugin now, welcome to the Plugins directory!

Thursday, 2 June 2016, 3:34 AM - Mike Churchward

Wed, 01 Jun 2016 19:34:26 GMT

by Mike Churchward.

Hi Artur. I have checked your latest release, and the dependency now requires the block installation. I looked at the unprotected script, and it is now protected. I did leave one further suggestion on how to possibly handle the potential error better in https://github.com/EEXCESS/moodle-atto_eexcesseditor/issues/2, but that is not required for acceptance.
I'm still not sure if the edit button works as I couldn't figure out what to do with it, but I'm guessing users of "eexcess" will no better.
Thanks for the submission.

Wednesday, 1 June 2016, 11:10 PM - Artur Khotenko

Wed, 01 Jun 2016 15:10:18 GMT

by Artur Khotenko.

Hello,
new version(2016060100) of plugin already submitted and issues on github closed.
Thanks in advance for checking.

Wednesday, 1 June 2016, 10:34 PM - David Mudrák

Wed, 01 Jun 2016 14:34:41 GMT

by David Mudrák.

Thanks Artur for sharing another plugin with the plugin community, and thanks Mike for detailed peer-review. I see things are being discussed and solved in the tracker so I am going to mark this as needing more work. Once a new version with fixes is uploaded, please schedule the plugin for re-approval. Thanks for your patience!

Wednesday, 1 June 2016, 3:10 AM - Mike Churchward

Tue, 31 May 2016 19:10:07 GMT

by Mike Churchward.

Added an issue for an unprotected script - https://github.com/EEXCESS/moodle-atto_eexcesseditor/issues/2

Wednesday, 1 June 2016, 2:53 AM - Mike Churchward

Tue, 31 May 2016 18:53:13 GMT

by Mike Churchward.

I installed the editor as an atto plugin, but it caused the issue described here - https://github.com/EEXCESS/moodle-atto_eexcesseditor/issues/1
Basically, I think you just need a "dependencies" entry in your version file. After I installed the eexcess block, the error went away.

After that, I could see the new button in the editor. I'm not sure what it should do though. I highlighted text and pictures and used the button, but nothing was changed or inserted. Am I using it wrong?

Wednesday, 1 June 2016, 2:35 AM - Mike Churchward

Tue, 31 May 2016 18:35:54 GMT

by Mike Churchward.

Hi. I am reviewing your submission for inclusion into the plugins database. Could you review the identified coding issues above and see if they can be addressed in the meantime?
Thanks.

Friday, 29 April 2016, 3:34 PM - Plugins bot

Fri, 29 Apr 2016 07:34:53 GMT

by Plugins bot.

Prechecker results: 2 errors/2 warnings
http://integration.moodle.org/job/Precheck%20remote%20branch/23175/artifact/work/smurf.html