Moodle Plugins directory: Dyslexic mod: Comments

Wednesday, 20 March 2019, 8:48 PM - Maher Elaissi

Wed, 20 Mar 2019 12:48:27 GMT

by Maher Elaissi.

Bonjour Eric,
Est ce que le plugin est compatible avec les nouvelle version 3.6 et 3.5
merci

Wednesday, 27 December 2017, 8:34 PM - Éric Bugnet

Wed, 27 Dec 2017 12:34:35 GMT

by Éric Bugnet.

Bonjour,
Je viens de tester sous Moodle 3.4, avec les thèmes clean, more et boost, et ça fonctionne.
Peux tu me faire passer l'adresse de ton site, et copier le contenu du « HEAD » ?
Éric

Tuesday, 5 December 2017, 5:39 PM - Gael PLANTIN

Tue, 05 Dec 2017 09:39:15 GMT

by Gael PLANTIN.

Bonjour, en dépit du respect de la procédure ci-dessus sur un moodle 3.3 et quelque soit le thème utilisé, le bouton reste inopérant...
La police ne change pas.
Une idée ?

Thursday, 9 June 2016, 3:49 AM - David Mudrák

Wed, 08 Jun 2016 19:49:27 GMT

by David Mudrák.

Thanks Éric again for sharing this block. For a future development, I can imagine you could replace the cookie storage with a custom user preference so that it would persist across multiple computers without affecting others' sessions (typically in computer labs etc). I am happy to approve the plugin now. You are cleared to land, welcome to the Plugins directory.

Thursday, 9 June 2016, 3:41 AM - David Mudrák

Wed, 08 Jun 2016 19:41:40 GMT

by David Mudrák.

Notice: Undefined index: dyslexic in /blocks/dyslexic/block_dyslexic.php on line 62

Wednesday, 11 May 2016, 10:24 PM - Éric Bugnet

Wed, 11 May 2016 14:24:14 GMT

by Éric Bugnet.

Update made.
I use the « Bitstream Vera Sans license » now.
Éric

Wednesday, 11 May 2016, 2:16 PM - Éric Bugnet

Wed, 11 May 2016 06:16:35 GMT

by Éric Bugnet.

I'just ask the OpenDyslexic author to add the public information of licencing in the official site.
Waiting, now...

Wednesday, 11 May 2016, 5:14 AM - David Mudrák

Tue, 10 May 2016 21:14:19 GMT

by David Mudrák.

Thanks for explanation Éric. The case with Geon's script is clear as there is a public record of the implicit licensing granted to you (in his github comment).

In case of Opendyslexic font license, I think we should stick to publicly available information on their official site. Licensing granted via private emails are way less transparent and do not fit the spirit of open source projects. It would be best if they made the licensing clearer on their site. Maybe you could ask them to do that?

Tuesday, 10 May 2016, 10:58 PM - Éric Bugnet

Tue, 10 May 2016 14:58:58 GMT

by Éric Bugnet.

Hi, and sorry, I juste check your comments now !

@Mike : I'll check it soon.

@David : for licenses, I got exchange with the 2 dev :

- Opendyslexic is SIL-OFL-> from creator (email), but notwritten in the site. « Bitstream Versa Sans. Version 3 is SIL-OFL »

- Script from Geon : « It was not really licensed at all in the blogpost, but I give you complete rights to do what you want, not strings attached. MIT, Apache, whatever you like. ». I opened an issue ont github page (https://github.com/geon/geon.github.com/issues/7#issuecomment-215344312). I just take GPL to be compatible with Moodle.

Is ot OK for you ?

I can add Bitstream Vera Sans license like you said.

Éric

Friday, 29 April 2016, 12:07 AM - David Mudrák

Thu, 28 Apr 2016 16:07:07 GMT

by David Mudrák.

Sorry, I am a bit confused now.

Your thirdpartylibs.xml states that the opendyslexic3 license is SIL-OFL. Where does this info come from? As per http://opendyslexic.org/legal/, Opendyslexic font is a derivate work of Bitstream Vera and effectively does not add any further restriction. Bitstream Vera license is generally considered as compatible with GPL (e.g. http://fedoraproject.org/wiki/Legal_considerations_for_fonts#Approved_font_licenses). So I would put something like this into the XML file:

<license>Bitstream Vera Sans license</license>

Secondly. The boilerplate in the file dyslexic.js links to https://geon.github.io/programming/2016/03/03/dsxyliea which seems to be a blog of Victor Widell and I found no info there that this file was released under GPL. Am I missing something? And is this view.php file (that uses this JS) really essential for the block functionality?

Thursday, 28 April 2016, 10:50 PM - Mike Churchward

Thu, 28 Apr 2016 14:50:35 GMT

by Mike Churchward.

Hi. Thanks for the changes. I think you've covered the licensing issue. The code still has some spacing violations though. You may want to add Travis CI testing to your plugin (https://moodle.org/mod/forum/discuss.php?d=323384), or use the codechecker plugin on your site to find these and fix them easily.

Thursday, 28 April 2016, 5:36 PM - Éric Bugnet

Thu, 28 Apr 2016 09:36:10 GMT

by Éric Bugnet.

Hi, I've just made the asked changes, particulary for dyslexic.js and opendyslexic font licenses.
Éric

Thursday, 28 April 2016, 5:01 AM - David Mudrák

Wed, 27 Apr 2016 21:01:44 GMT

by David Mudrák.

Thanks Éric for sharing this interesting plugin with the community, and thanks Mike for the approval check. I agree that is required to be clear about the licensing of all the code included in the plugin package - see details described at https://docs.moodle.org/dev/Plugin_contribution_checklist#Licensing

For now I am marking this as needing more work so that the standard boilerplate can be added to your files, or they are enlisted in the thirdpartlibs.xml file.

Thursday, 28 April 2016, 4:19 AM - Mike Churchward

Wed, 27 Apr 2016 20:19:23 GMT

by Mike Churchward.

Hi. I am reviewing your plugin for the Plugins guardians. Can you look at the coding issues outlined above, and resubmit when you have dealt with those?
Also, can you ensure the file "dyslexic.js" contains a header like "stylechange.js", that includes the license information?
And, can you create a "thirdpartylibs.xml" file (https://docs.moodle.org/dev/Plugin_files#thirdpartylibs.xml) to list the provided fonts with the appropriate licensing information?
Thanks for your submission.

Wednesday, 27 April 2016, 2:33 PM - Plugins bot

Wed, 27 Apr 2016 06:33:24 GMT

by Plugins bot.

Prechecker results: 127 errors/30 warnings
http://integration.moodle.org/job/Precheck%20remote%20branch/23119/artifact/work/smurf.html