Moodle Plugins directory: MoodleMobile Text Messages: Comments

Friday, 27 November 2015, 4:39 PM - David Mudrák

Fri, 27 Nov 2015 08:39:57 GMT

by David Mudrák.

Thanks for an updated version. Looking better now.

When configuring the plugin, I can see several PHP warnings raised. Please make sure you are developing your plugin with developer debugging enabled and displayed.

Warning: array_key_exists(): The first argument should be either a string or an integer in .../lib/adminlib.php on line 3068

I believe this is caused by a bug in your settings.php file where in admin_setting_configselect() the options are correct integers (0 or 1) but you set the default value to 'false' (instead of 0). As a result, the warning is raised and no information about the default value is displayed.

I agree with Dan that the name could be less confusing, but I understand your reasoning and background sent via e-mail. You are cleared to land now, welcome to the Plugins directory.

Friday, 27 November 2015, 4:16 PM - Plugins bot

Fri, 27 Nov 2015 08:16:51 GMT

by Plugins bot.

Prechecker results: 3 errors/3 warnings
http://integration.moodle.org/job/Precheck%20remote%20branch/18629/artifact/work/smurf.html

Friday, 23 October 2015, 12:03 AM - Plugins bot

Thu, 22 Oct 2015 16:03:04 GMT

by Plugins bot.

Prechecker results: 342 errors/15 warnings
http://integration.moodle.org/job/Precheck%20remote%20branch/17400/artifact/work/smurf.html

Thursday, 22 October 2015, 3:51 PM - Dan Marsden

Thu, 22 Oct 2015 07:51:14 GMT

by Dan Marsden.

Hi there,

Thanks for sharing your code. Please provide a link to the public source code repository and bug tracker related to your plugin.

Also - the name you have used here does not seem correct - "MoodleMobile" - this could cause significant confusion with the Mobile app provided by Moodle. I would suggest renaming it to "PageOne Text messaging" or something similar.

A quick look at your code shows that it does not follow our guidelines very well - please install the local_codechecker and local_moodlecheck plugins and use these to validate the structure of your code. I also see some backticks within in-line SQL which are not cross-db compatible.

once you have tidied these things up please submit a new version for us to look at - thanks!