Moodle Plugins directory: Compile discussions: Comments

Tuesday, 5 January 2016, 7:24 PM - Steve Bond

Tue, 05 Jan 2016 11:24:13 GMT

by Steve Bond.

Hi Mark,

At some point soon I will need to upgrade this to 2.7 and 2.9 for use at my institution, but I don't think there will be a 3.0 version any time soon. Of course, the code might well work in 3.0 anyway.

Monday, 4 January 2016, 4:00 PM - Mark Chaney

Mon, 04 Jan 2016 08:00:22 GMT

by Mark Chaney.

Hi Steve,

Are there any plans to upgrade this plugin for Moodle 3?

Thanks

Mark

Friday, 27 November 2015, 6:08 PM - Steve Bond

Fri, 27 Nov 2015 10:08:04 GMT

by Steve Bond.

Hi Phil,
Actually the 2,6 version still works fine in 2.7. We've got it installed and working in 2.7.11 here. I'll branch it and add a new version here when I get a minute.

Wednesday, 18 November 2015, 6:02 PM - Phil Rogers

Wed, 18 Nov 2015 10:02:59 GMT

by Phil Rogers.

Is there any plans to bring out a version for 2.7? It would be greatly appreciated!

Regards,

Phil

Friday, 19 December 2014, 7:03 AM - David Mudrák

Thu, 18 Dec 2014 23:03:33 GMT

by David Mudrák.

Thanks Steve for this contribution, and thanks Rex for peer-reviewing it. I spotted yet another things you may want to look at and reported them as issues #1 and #2 in your bug tracker.

With the hope the raised issues will be addressed in future updates of your block, you are cleared to land now. Welcome to the Plugins directory!

Thursday, 18 December 2014, 3:42 AM - Plugins bot

Wed, 17 Dec 2014 19:42:44 GMT

by Plugins bot.

Prechecker results: http://integration.moodle.org/job/Precheck%20remote%20branch/8910/artifact/work/smurf.html

Wednesday, 17 December 2014, 5:09 PM - Steve Bond

Wed, 17 Dec 2014 09:09:08 GMT

by Steve Bond.

Hi Rex,
Thanks for these notes, very useful. I'm only an occasional developer so I often fall behind or forget how to do stuff right, so it's good to get feedback. I'll make some improvements when I get a chance.

I'm not sure what the answer is to #5 - some sort of paging I suppose, if the page gets too long.

Wednesday, 17 December 2014, 6:17 AM - Rex Lorenzo

Tue, 16 Dec 2014 22:17:09 GMT

by Rex Lorenzo.

Some code review comments:

1) Should use lang strings for string output of Discussion and Forum titles in compile.php.
2) In compile.php, consider using html_writer for HTML tags.
3) In compile.php use the Moodle core library call userdate() instead of strftime to support if a system is using a different calendar system.
4) Also, the use of exit in compile.php doesn't look right and is unnecessary. Should also add a function phpdoc for get_children(), but that is just a nicety.
5) I'm worried that there is no limit to how many posts/discussions are compiled. Maybe have a config setting to control how many forum posts/discussions are compiled? Or use the existing $CFG-> forum_manydiscussions setting?
6) Do the results change that much or are different by each user? Maybe cache the results and have a cron that updates the compiled output? That is what the recent activity block does. See https://github.com/moodle/moodle/tree/master/blocks/recent_activity