Moodle Plugins directory: CQU MyMoodle: Comments

Monday, 25 August 2014, 6:37 PM - David Mudrák

Mon, 25 Aug 2014 10:37:48 GMT

by David Mudrák.

Hi guys, thanks for sharing this plugin with the community. I am going to approve the plugin now. The only thing I noticed is that your locallib.php creates functions in the global PHP scope without the valid frankenstyle prefix. This is strongly discouraged in order to prevent collisions with (current and/or future) core code or some other
plugin. See http://docs.moodle.org/dev/Coding_style#Functions_and_Methods for details.

With the hope this would be fixed in a future update of the plugin, you are cleared to land. Welcome to the Plugins directory.

Monday, 25 August 2014, 6:29 PM - David Mudrák

Mon, 25 Aug 2014 10:29:00 GMT

by David Mudrák.

Hi Marcus. Having docs at https://github.com/donkeyx/moodle-block_cqumymoodle/blob/master/README.md is fully sufficient, thanks. If you prefer Moodle Tracker over Github issues system, please refer to the instructions in the summary of https://tracker.moodle.org/browse/CONTRIB/ project.

Friday, 22 August 2014, 9:04 AM - Marcus Boon

Fri, 22 Aug 2014 01:04:32 GMT

by Marcus Boon.

Hi David,

How would I go about getting a tracker URL on the moodle.org tracker?

Thursday, 21 August 2014, 8:53 PM - David Mudrák

Thu, 21 Aug 2014 12:53:51 GMT

by David Mudrák.

Hi. Before we move on with the code review and approval, may I ask for fixing the Plugin check results reported above. Thanks in advance.

Saturday, 2 August 2014, 1:40 AM - David Mudrák

Fri, 01 Aug 2014 17:40:24 GMT

by David Mudrák.

I'm sorry, I'm on my annual leave for the next two weeks. I'll get to approving submitted plugins as soon as I'm back. Thanks for understanding.
In the meantime, you may want to fix the formal issues raised by the plugin checker that are displayed above.