Moodle Plugins directory: LAE User report: Comments

Thursday, 20 August 2015, 9:44 PM - Bob Puffer

Thu, 20 Aug 2015 13:44:01 GMT

by Bob Puffer.

It might work in 2.9 but most of the capabilities have been adopted by Moodle's core gradebook in 2.8 and 2.9

Monday, 3 August 2015, 5:20 AM - Sofía González

Sun, 02 Aug 2015 21:20:02 GMT

by Sofía González.

It serves to moodle 2.9 ?

Tuesday, 28 October 2014, 8:08 PM - Bob Puffer

Tue, 28 Oct 2014 12:08:30 GMT

by Bob Puffer.

can you be more specific, what errors are you seeing with debug turned on?

Tuesday, 28 October 2014, 10:38 AM - cam nguyen

Tue, 28 Oct 2014 02:38:00 GMT

by cam nguyen.

dont work whith moodle 2.7, please help me

Sunday, 16 March 2014, 10:37 AM - Anthony Borrow

Sun, 16 Mar 2014 02:37:40 GMT

by Anthony Borrow.

Bob - Thanks for your patience and for tidying up the copyright. I have approved this plugin but still want to ensure we have the tracker URLs listed as you want. I have also created the LAE Grade Reports set at https://moodle.org/plugins/browse.php?list=set&id=53. Peace - Anthony

Saturday, 8 March 2014, 7:11 PM - Bob Puffer

Sat, 08 Mar 2014 11:11:42 GMT

by Bob Puffer.

Anthony, are we thinking this can be approved soon?

Wednesday, 26 February 2014, 10:22 PM - Bob Puffer

Wed, 26 Feb 2014 14:22:38 GMT

by Bob Puffer.

My only question is... I've used as much of the standard User report code as practical to avoid conflicts when merging and the user report does it the way the LAE User report does it?

Wednesday, 26 February 2014, 1:14 PM - Anthony Borrow

Wed, 26 Feb 2014 05:14:53 GMT

by Anthony Borrow.

Bob - In settings.php, I noticed that you are using names like: grade_report_laeuser_showrank. Since this is a plugin, I think it best if you used grade_report_laeuser/showrank. This would require you to use the get_config function but it prevents bloat on $CFG and stores config data related to plugins in the mdl_config_plugins table rather than mdl_config. Let me know if you have any questions about how to implement that change. I appreciate your patience with the review process. Peace - Anthony

Wednesday, 26 February 2014, 10:56 AM - Anthony Borrow

Wed, 26 Feb 2014 02:56:09 GMT

by Anthony Borrow.

Bob - Thanks for the explanations and fixes. For your next release would you patch up the version.php file to address the validation warnings? I am going to give this another test and look at the code for anything else that might need attention but am thinking this is pretty close to being ready for approval. Is there a link for documentation? Peace -Anthony

Wednesday, 26 February 2014, 12:27 AM - Bob Puffer

Tue, 25 Feb 2014 16:27:52 GMT

by Bob Puffer.

I've pushed again, removing a couple notices I found and making the copyright changes

Saturday, 22 February 2014, 3:02 AM - Bob Puffer

Fri, 21 Feb 2014 19:02:26 GMT

by Bob Puffer.

LAE Grade Reports would be appropriate. I've got hundreds of schools using the LAE Grader and that's all they've ever known it by.

Saturday, 22 February 2014, 3:01 AM - Bob Puffer

Fri, 21 Feb 2014 19:01:29 GMT

by Bob Puffer.

I've explained how LAE is derived.
I don't see the notices you indicating but will continue checking various courses (have developer debug on and display to screen)
Will repair copyrights and resubmit

Friday, 21 February 2014, 1:02 PM - Anthony Borrow

Fri, 21 Feb 2014 05:02:22 GMT

by Anthony Borrow.

Bob - I have tested installing this and it appears to work reasonably well although the course I used for testing did not have any grades populated. Before approving, I noticed a couple of copyrights that I would like to see cleaned up:

./lib.php: * @copyright 2007 Nicolas Connault
./renderer.php: * @copyright 2010 Sam Hemelryk
./renderer.php: * @copyright 2010 Sam Hemelryk

Also, do you have any suggestions for the name of the set?

Friday, 21 February 2014, 12:52 PM - Anthony Borrow

Fri, 21 Feb 2014 04:52:39 GMT

by Anthony Borrow.

Bob: FYI, I am seeing the following types of PHP Notices/Warnings:

Notice: Undefined offset: 3 in /var/www/m26/grade/report/laegrader/locallib.php on line 598

Notice: Trying to get property of non-object in /var/www/m26/grade/report/laegrader/locallib.php on line 598

Notice: Undefined index: in /var/www/m26/grade/report/laegrader/locallib.php on line 610

Notice: Trying to get property of non-object in /var/www/m26/grade/report/laegrader/locallib.php on line 610

Warning: Division by zero in /var/www/m26/grade/report/laegrader/locallib.php on line 610

Warning: Creating default object from empty value in /var/www/m26/grade/report/laegrader/locallib.php on line 610

and later in the page:

Notice: Undefined property: stdClass::$parent_id in /var/www/m26/grade/report/laeuser/lib.php on line 408

Peace - Anthony

Friday, 21 February 2014, 12:42 PM - Anthony Borrow

Fri, 21 Feb 2014 04:42:33 GMT

by Anthony Borrow.

Bob - A set means that the plugins work best together or are in some way related to each other even if there is not a dependency. It seems a set would be appropriate here. In the description it would probably be helpful to make it clear that LAE stands for Liberal Arts Edition. Peace - Anthony