Comments

• 

  Anthony Borrow

  Fri, 23 Aug 2013, 12:28 PM

  Franc - Many thanks for sharing your theme with the Moodle community.
  
  I noticed in the lang/en/theme_aigne.php file that there are strings there that are primarily in Spanish. It would be best to at least run these through something like Google Translate if you do not feel comfortable translating them yourself. Others can suggest improvements but it would be good to have an initial English translation for things like helppage, footsearchpage, disclaimerpage, etc. It appears that webmanpage contains links to things specific to your site that are not going to be helpful to others (grupo/cv/personal.asp, forma/elearning.asp, etc.). I would recommend replacing that with something more generic that gives folks an idea of how it can be used. Similarly in the helppage string you make a reference to the student manual which is a pdf file. That is not going to be helpful for other sites. In general, I would be careful about using class names like quadro. In order to really get folks collaborating with you on maintaining a plugin, it is important that as much as possible be in English. I might even consider translating comments so that there is an English translation - even if it is not perfect.
  
  I would also recommend removing the robots.txt file.
  
  I like to encourage folks to provide the source control, tracker and documentation URLs for the Useful links section. Please consider adding that information to the plugin entry.
  
  For now, I am going to mark this plugin as needing some more work so you can take care of some of these issues. Just let us know when you have a new version available and then we can take another look. Thanks for your patience with the approval process. The goal is to help those who download and install your plugin to have a consistent experience. Please do not hesitate to let me know if there is anything I can do to be supportive of your efforts. Peace - Anthony
• 

  Anthony Borrow

  Thu, 5 Sept 2013, 2:15 AM

  Franc - I would like to see the source control, tracker and coumentation URLs added before we approve this. Also, in your lang/en/theme_aigne.php file you have the separator defined with upper case characters. I would recommend switching those to lowercase for XHTML compatibility.
  
  W3Schools use lowercase tags because the World Wide Web Consortium (W3C) recommends lowercase in HTML 4, and demands lowercase tags in XHTML. (from http://www.w3schools.com/html/html_elements.asp)
  
  Otherwise, I believe things are looking good. Thanks for your work at tidying up these details.
  
  Peace - Anthony
• 

  Anthony Borrow

  Thu, 5 Sept 2013, 2:53 AM

  Franc - Perhaps you might give the multi-lang filter - http://docs.moodle.org/25/en/Multi-language_content_filter - a try here on this plugin entry as well. Peace - Anthony
• 

  Franc Pombal

  Sat, 14 Sept 2013, 8:43 PM

  Hello Mr. Borrow
  
  I have read your messages right now and I have any issues... well, not serious things...
  
  AIGNE THEME:
  I tried adding the tag 'span' for multi-lang filter funcionality in the description and simply does not work. Do not understand why?... But no problem, for now I'll leave the description only in English and when I have more time I'll check.
  
  I have corrected the upper case characters, a lapsus. I always try to keep compatibility with W3C ...
  
  And finally, do not really understand the conditions that we must meet in order to maintain a support website, so I'll create a new page in blog format to meet these requirements.
  
  I think everything should be fine ...
  
  NAVIGATION PLUGIN:
  In short, I have to make many more changes that I have tested and add your recommendations, so I'll parked this 'plugin' for a while.
  
  Well, thank you very much for everything, to see whether by the next week is all over.
  
  I am sorry for any inconvenience I am causing
  
  A greeting
• 

  Anthony Borrow

  Sun, 15 Sept 2013, 9:50 AM

  Franc - The multi-lang filter uses span tags for the languages and as a result you cannot have other tags like and

  inside of them. I reformatted the page for you to use the multi-lang filter. To see the individual translations you can append &lang=xx at the end to see how the page behaves - for example,
  
  https://moodle.org/plugins/view.php?plugin=theme_aigne&lang=en
  https://moodle.org/plugins/view.php?plugin=theme_aigne&lang=pt_br
  https://moodle.org/plugins/view.php?plugin=theme_aigne&lang=es
  https://moodle.org/plugins/view.php?plugin=theme_aigne&lang=gl
  
  Thanks for your continued work on getting the plugin ready to share with the community. I am happy to help in any way I can.
  
  Peace - Anthony

• 

  Anthony Borrow

  Sun, 15 Sept 2013, 9:53 AM

  oops, let's try those links again:
  https://moodle.org/plugins/view.php?plugin=theme_aigne&lang=en
  https://moodle.org/plugins/view.php?plugin=theme_aigne&lang=pt_br
  https://moodle.org/plugins/view.php?plugin=theme_aigne&lang=es
  https://moodle.org/plugins/view.php?plugin=theme_aigne&lang=gl
• 

  Anthony Borrow

  Sun, 15 Sept 2013, 10:07 AM

  Franc - No inconvenience at all, I am happy to be of help. The goal is to make sure that others who install your plugin will have a good experience with it. It looks like one string was not translated in the lang/en/theme_aigne.php file:
  
  $string['menucolorhldesc'] = 'Seleccione el color de contraste del menú personalizado. Tenga en cuenta la combinación con el anterior color para mentener un diseño agradable';
  
  In the style folder there are some fonts provided - could you verify that the license for those fonts is GPL compatible. If you could find out how those fonts are licensed it would be very helpful. All files in a Moodle plugins must be GPL compatible.
  
  Thank you for making the webmanpage and helppage strings more generic. As for providing the source and tracker URLs, many developers are using Github.com to host and manage their code. Github provides wiki and issues tools to help with documentation and an issue tracker. You are welcome to use Moodle Docs and/or Moodle Tracker. You may want to review http://docs.moodle.org/en/Development:Guidelines_for_contributed_code to get some ideas about how to use those tools. If you decide to use the Moodle Tracker just let me know and I will create a component under the Addons project so that issues created for your theme will be automatically assigned to you. If you are using Github you may just want to use their issues system.
  
  I appreciate your work and patience with the plugin review process. At this point, the only thing preventing me from approving it is needing to verify the license of the fonts provided in the style folder.
  
  Peace - Anthony
  
• 

  Anthony Borrow

  Wed, 18 Sept 2013, 5:03 AM

  Franc - Thanks for uploading a new version of the theme. I see that you have corrected the menucolorhldesc string and removed the fonts which may not have been GPL compatible from the layout folder. I also see that you know have a Github.com account and a repository created for the theme. I'll work with you to get those files pushed up and create a MOODLE_25_STABLE branch. I'm going to wait until we get the files uploaded to Github to approve this but things are looking good. Let me know how I can best be of help. Peace - Anthony
• 

  Anthony Borrow

  Wed, 18 Sept 2013, 5:06 AM

  p.s. - I noticed a couple of PHP notices that you'll want to work on cleaning up when you have time but these will not prevent the approval of the plugin but I noticed them while testing the theme and thought I would share:
  
  Undefined variable: previewconfig in /var/www/m25/theme/aigne/settings.php on line 59
  
  Notice: Undefined variable: previewconfig in /var/www/m25/theme/aigne/settings.php on line 114
  
  Notice: Undefined variable: previewconfig in /var/www/m25/theme/aigne/settings.php on line 122
  
  Notice: Undefined variable: previewconfig in /var/www/m25/theme/aigne/settings.php on line 59
• 

  Anthony Borrow

  Wed, 18 Sept 2013, 5:11 AM

  pps - I do not see where $previewconfig was defined anywhere
• 

  Anthony Borrow

  Fri, 20 Sept 2013, 6:34 AM

  Franc - I think everything is patched up nicely now so I am going to go ahead and approve this theme. Thanks again for your patience with the review process. Peace - Anthony
• 

  Ral Azar

  Sun, 12 Jan 2014, 4:00 AM

  es posible cambiar el menu lateral que se encuentra a la derecha cambiarlo hacia la izquierda ? hay que ir al codigo o se puede hacer en los parametros de configuracion del tema?
• 

  Franc Pombal

  Sat, 18 Jan 2014, 3:10 AM

  Hola a todos ...
  
  Por el momento no he implantado una opción para cambiar la posición de los bloques.
  En cuanto no lo haga, solo hay una manera de modificar los bloques laterales:
  1.- Se debe entrar en el archivo theme\aigne\config.php
  2.- Buscar una sección que se llama ‘$THEME->layouts’ (esta por la línea #68)
  3.- Aquí esta la configuración de los layouts, donde existe dos apartados que se llaman 'regions' y 'defaultregion'. Lo único que se debe hacer aquí es cambiar 'side-post' (lado derecho) por 'side-pre' (lado izquierdo), o viceversa, en todos los apartados 'regions' y 'defaultregion' que se desee.
  Si se hace con cuidado y cariño seguro que saldrá bien … …
  Recomiendo tener una copia de seguridad del archivo theme\aigne\config.php… por si acaso
  
  Un saludo, y a vuestra disposición…
  
• 

  GIanluca Nolletti

  Mon, 3 Feb 2014, 10:48 PM

  Hi all, i'd like to know how to delete (or change) the text under the 5 pictures on the home page. i changed the default images, but i cannot modify the text (Raia Velenosa_Text of Bellow1 and so on....). thanks in advance
• 

  Franc Pombal

  Thu, 6 Feb 2014, 7:23 AM

  Hello Gianluca and everyone
  
  The text of any of the information box on the ‘frontpage’, can be modified directly in the language files. Inside theme\aigne, has a folder named ‘lang’, where the files are stored for different languages.
  
  Each of these files has a list of strings. Specifically the texts to manipulate in ‘accordion’ box are $string['aco5cap#'] and $ string['aco5alt #'].
  Note that when updating a new version of the plug-in, these files will be overwritten. To avoid that moodle has a powerful configuration tool, which are called local files. To create local files you must access the data folder (moodledata). There you will find a ‘lang’ folder, with all installed languages. You must copy the file ‘theme_aigne.php’ in each desired language and then customize these strings as needed. Thus when upgrading to a new version of the plug-in, your custom text will be preserved.
  
  If you want to hide a particular string, delete existing content in quotes (ex: $string['aco5cap1'] = ''; ).
  
  I hope this been helpful. If you need anything else, feel free to contact.
  "Buona fortuna con l'installazione ... Voglio vedere come sembra!"
  
  P.S.: I remind everyone that I'd like to receive information about their installations and translations of the strings to other languages.