Luke,

Many thanks for sharing this plugin with the Moodle community. Please review the validation results and fix all of the issues mentioned. These changes are typically pretty easy to make but if you have any questions just let us know.

Maturity information ($plugin->maturity) not found in version.php
Release notes not found (searched for files README, README.*)

I noticed that the recommended boilerplate was not used in the version.php file. The boilerplate is recommended at the beginning of each file and makes explicit the GPL license.

You may want to review http://docs.moodle.org/dev/Coding_style#Files to learn more about the boilerplate comments.

I was successfully able to install the plugin but did not do any extensive testing. I noticed that you use it to send email. I was curious how you implemented this. Have you had a look at http://docs.moodle.org/dev/Messaging_2.0#Message_types_.28providers.29? I did not look closely at the code but thought this would be the ideal way to handle the notification and then the user determines how they wish to receive it (via popup, email, etc.)

For now, I am going to mark this plugin as needing more work until we get these issues resolved. Thanks for your patience with the review and approval process. Peace - Anthony

Hi Anthony,

Many thanks for your feedback! I've made a start on addressing the above issues, but I'll need to dedicate a little more time reworking the mailer code to use the messaging API. That's a really nice idea, though -- I'll definitely switch over.

I'll refrain from uploading a new version until this is complete.

Regards,
Luke.

Hi Luke. I am afraid I have to mark this as needing more work yet. Your SQL query in local_tdmmodnotify_util::get_notification_digest() aliases the user table as "user" which is reserved word on some RDBMs that Moodle supports (such as PostgreSQL). This causes your plugin to fail on such hosts. The fix is pretty trivial (by using the alias "u" or "usr" as we commonly do in Moodle code itself. Please ping me once a fixed version is uploaded, I will approve your (otherwise nice and well structured again) plugin then.

Please note some Anthony's points above are still valid. As you are going to touch the code, you might want to fix them, too.

David, my apologies: I completely missed the "Supported versions" section when I pushed 0.2.0, which unfortunately displayed as a previous version s a result. I believe all of the above issues have already been addressed -- I tested the code on PostgreSQL before releasing yesterday.

Sorry!

Ah, right. That explains it. Thanks for the prompt fix Luke. You are cleared to land now, welcome to the Plugins directory!

How i can configure and use this plugin?
Will send when cron.php is executed?
He send only one time per day ?

Thank you so much.

Hi
I have a question.
Does this plug-in send email when a user is enrolled in a course?

Hello, does this plugin is turned on for all the users who are enrolled in any course and i can not turn the plugin on only for special roles (for example for "manager") in Site administration>Users Permissions>Define roles by marking "allow" button for TDM: module modification notification feature?
Thanks
Ann

Hello, I have created a fork of this plugin. Also fixed the mailing issues in 3.10 and moved from cron to task for managing notification schedule . Can't share the url here but look for the repo fork under dirar / moodle-local_tdmmodnotify

Dirar, since I'm no longer active in the Moodle community, would you like to take up maintenance of this plugin?

I want to send auto-generated email to the enrolled students on new activity uploaded to the particular course. My moodle version is 3.10. Any possibility to accommodate that ? Pls Guide. (This plugin is not compatible with 3.9 or 3.10 AS well) Pls let me have an update one or any alternative solution to achieve the above task. Thank you so much !!!

@Luke Carrier sure, what it's needed from my side?