Comments

• 

  Anthony Borrow

  Wed, 21 May 2014, 8:42 AM

  Adam,
  
  Many thanks for sharing this plugin with the Moodle community. You may wish to consider adding a screenshot of your plugin to help folks get an idea of what it looks like when installed.
  
  I was successfully able to install the plugin and it appears to function as expected.
  
  In block_mediagallery.php, you require locallib.php; however, that file is empty so there seems to be no reason to include it unless I missed something.
  
  It is encouraged to follow Moodle's coding style as outlined in:
  
  http://docs.moodle.org/dev/Coding_style
  http://docs.moodle.org/dev/Coding
  
  Tthe code checker plugin can be quite helpful in fine tuning your code and can be found at:
  
  https://moodle.org/plugins/view.php?plugin=local_codechecker
  
  You may wish to consider using that tool to further improve your plugin. Below, are the initial results:
  
  Files found: 6
  
  blocks/mediagallery/locallib.php
  blocks/mediagallery/renderer.php
  blocks/mediagallery/lang/en/block_mediagallery.php
  blocks/mediagallery/db/access.php
  blocks/mediagallery/version.php
  blocks/mediagallery/block_mediagallery.php - 3 error(s) and 0 warning(s)
  Total: 3 error(s) and 0 warning(s)
  
  They seem to be casing and whitespace issues so nothing major.
  
  I am keen to get these plugins approved; however, until we get that licensing issue resolved with https://moodle.org/plugins/view.php?plugin=mod_mediagallery I am going to mark this as needing more work.
  
  Peace - Anthony
  
  
  
  
• 

  Adam Olley

  Wed, 21 May 2014, 12:13 PM

  Hi Anthony,
  
  Coding style fixed up, screenshot added and locallib (and reference to) removed.
  
  Cheers.