Your Moodle version

Themes: slate

theme_slate
Maintained by Picture of Bas Brands Bas Brands
This is a bootswatch theme for the Bootstrap3 theme
2k
198
1

This is a child theme for Moodle 2.7 and Bootstrap3

Before installing this theme download the latest version of the Bootstrap 3 theme.

Screenshots

Screenshot #0

Contributors

Picture of Bas Brands
Bas Brands (Lead maintainer)
Please login to view contributors details and/or to contact them

Comments RSS

Show comments
  • Anthony Borrow
    Tue, May 13, 2014, 11:36 AM
    Bas,

    Many thanks for sharing this plugin with the Moodle community.

    Please review http://docs.moodle.org/dev/Plugin_validation#Recommended_URLs and then edit the plugin entry to provide the source, tracker, and documentation URLs that will enable others in the community to more actively participate in using and maintaining this plugin. Also, please consider adding a screenshot of your plugin to help folks get an idea of what it looks like when installed.

    I was successfully able to install the plugin but it does not appear to function as expected. It seems the css is not loading. I did not try to troubleshoot the issue but the theme does not seem to be working.

    I noticed that some of the copyrights reference a previous author. It is preferred that all of the files that you have modified for this plugin have your name listed (or added) as the copyright holder. In particular, you may want to have a look at:

    ./settings.php: * @copyright 2014 Frédéric Massart

    For now, I am going to mark this plugin as needing more work until we get these issues resolved. Thanks for your patience with the review and approval process. Please do not hesitate to let me know if there is anything I can do to be supportive of your efforts. Peace - Anthony
  • Anthony Borrow
    Tue, May 13, 2014, 10:01 PM
    Bas - Thanks for the new version correcting the issues above. I have tested the theme and all is now working as expected.

    It is encouraged to follow Moodle's coding style as outlined in:

    http://docs.moodle.org/dev/Coding_style
    http://docs.moodle.org/dev/Coding

    Tthe code checker plugin can be quite helpful in fine tuning your code and can be found at:

    https://moodle.org/plugins/view.php?plugin=local_codechecker

    You may wish to consider using that tool to further improve your plugin. Below, are the initial results:

    theme/slate/style/custom.css
    theme/slate/lib.php - 2 error(s) and 0 warning(s)
    theme/slate/lang/en/theme_slate.php - 1 error(s) and 0 warning(s)
    theme/slate/config.php - 2 error(s) and 0 warning(s)
    theme/slate/version.php - 2 error(s) and 0 warning(s)
    theme/slate/settings.php - 3 error(s) and 0 warning(s)
    theme/slate/README.txt

    I am going to approve this theme and thanks again for patching things up so quickly. Peace - Anthony
  • Picture of Bas Brands
    Tue, May 13, 2014, 11:07 PM
    I have fixed the bits that cause the warnings.. Find-replace can be a dangerous tool to use smile Thank you!
Please login to post comments