Approval issue created: CONTRIB-7182

Hi Andrei,

Thanks for submitting this plugin! I think it a a realy fun and nice addition to the plugin DB.

During installation I noticed a small problem in when configuring the Giphy API key. The steps to reproduce are:
Turn on development mode
Go to Site Administration -> Development
Select Debugging
Set Debugging to "Developer..."
Check the display debug messages

Go to Site Administration -> Plugins
Select Repositories -> Manage Repositories
Click the settings icon for the Giphy repository

You will see this notice:

Did you remember to call setType() for 'api_key'? Defaulting to PARAM_RAW cleaning.
line 1354 of /lib/formslib.php: call to debugging()
line 312 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 218 of /lib/formslib.php: call to moodleform->_process_submission()
line 99 of /admin/repository.php: call to moodleform->__construct()

And

Notice: Undefined variable: attributes in /var/wwwdata/mdk/stable_34/moodle/repository/giphy/lib.php on line 260

For further info please read:
https://docs.moodle.org/dev/lib/formslib.php_Form_Definition#setType

Thanks!

Why I attempt to select Giphy from the list of repositories on the File Picker dialog box in Moodle 3.5, I get the following error:

Exception - Too few arguments to function html_writer::img(), 1 passed in [dirroot]/repository/giphy/lib.php on line 235 and at least 2 expected

Dear Andrei,

I tried to use your plugin in a Moodle 3.9.2.+ installation but I keep getting the same error as mentioned by Matthew. Is there any fix?

Thank you!

Hello Martin and Matthew, I updated the code and tested the plugin on Moodle 3.10. Please give it a try now.
Matthew, I'm sorry this small fix comes after more than 2 years since you reported it.

Hello Andrei, thank you for your time and effort! Just tried it and it works like a charm! Great plugin for a bit of fun to lighten the mood! Thank you!

Hello Andrei,

thanks for your effort to create such a cool plugin.

Sadly, I have a problem with using the gifs on our moodle website. In the file packer I can see all gifs and can search for many more, but if I select a gif, a message is seen with "No data available". And I don't know why

Do I need a ADI production key or is there a different problem I need to fix in moodle itself?

Thanks for your help!

I can test to see if anything change within the API. Can you tell me which moodle version do you use?

Thank you so much! We are using the version 3.10.3

Hello, Sabrina. I tested with a fresh install of 3.10.3 and it works. You do need an API key for it to work. You can use a free key.

Hey, Andrei. Hmmm. Damn. It still doesn't work with our moodle and I put in a new API key. I installed your plugin anew as well but it still has the same error ("No data available"). It's curious because I can see the gifs in the previous step. Do you have any other idea what could be wrong? Do I need to change something in the moodle settings?