Moodle plugins directory: Code-checker

LOL, Urs.

I don't recommend to ignore warnings. In fact, I do recommend to check both errors and warnings. More yet, I do check both always.

I only say that, while errors are clear violations, warnings can be understood as recommendations. If you decide to follow or ignore them it's up to you. Personally I follow them, it's not so hard, really. But your choice, anyway.

Ciao

I don't understand, used plugins like?

Gents,

Looking at the code I believe that this: https://github.com/moodlehq/moodle-local_codechecker/blob/master/moodle/tests/moodlestandard_test.php#L344 should be a failure of 'Expected 1 space before "="; 2 found' given: https://github.com/moodlehq/moodle-local_codechecker/blob/master/moodle/tests/fixtures/squiz_whitespace_operatorspacing.php#L18

Cheers,

Gareth

"More documentation" link above should probably point to https://docs.moodle.org/dev/CodeSniffer rather than style documentation. Not sure though.

Would it be possible to include the latest version of the PHPCompatibility sniff and also add in the ability to pass in versions, so the code can be tested against different versions?

Hi Derek, just for reference, there is https://tracker.moodle.org/browse/CONTRIB-5158 about that. It's old, but any movement towards that feature should happen there.

Hi Tim,
This doesn't check the column names in install.xml file. There is a coding standard for the column names as well. "Column names should be always lowercase, simple and short, following the same rules as for variable names. (https://docs.moodle.org/dev/Database)".

You should be using the XMLDB editor built in to Moodle, to edit your database definitions (Admin -> Development -> XMLDB editor). That checks the rules for you. I agree it would be nice to have the same checks in codechecker, but not essential.

Hi there,

What are the thoughts of having the code checker ignore code folding? Does code folding need to be defined in the Moodle coding style before being allowed in the code checker?

/// <editor-fold desc="This is a bunch of code that does stuff">
/// </editor-fold>

If you want a 'bunch of code that does stuff' (with documentation, code folding, etc.) surely that is a function, and refactoring Moodle code to make it more understandable is encouraged.

I don't know which editor you are using for that syntax to work. I have never seen it before, but doing something just for one editor is less likely to be a sensible decision.

So, given we want to encourage well-factored code, not long sprawling blocks of code, and we want to be editor-neutral, I am not enthusiastic about your suggestion.

Cannot install latest version 2019011500 on my localhost moodle box. It keeps telling me "There is a new version 2019011500 available!
Release 2.9.2 - Selectivenesses"

Yeah, you're right Joseph!

I did forget to bump version.php and just discovered it when publishing the new version in the Plugins directory. Expect a new release soon (2.9.3) fixing that. Sorry for the troubles!

Consider yourself repented and forgiven, Eloy. Happy New Year 2019!

Best wishes there too! Thanks!

Can you run Code-checker via the command line (e.g. for CI)? Following the README didn't work: https://moodle.org/mod/forum/discuss.php?d=383557