Prechecker results: http://integration.moodle.org/job/Precheck%20remote%20branch/9627/artifact/work/smurf.html

Andreas - Many thanks for sharing another plugin. Before we approve this, might you tidy up the version.php to avoid the following validation warnings:

Warning Maturity information ($plugin->maturity) not found in version.php
Warning Release name ($plugin->release) not found in version.php

Also, have a look at https://docs.moodle.org/dev/Plugin_contribution_checklist#Meta-data regarding provding the source, tracker and documentation meta-data.

In addition, it looks like this may be restricted to MySQL databases at the moment is I received the following when testing under Postgres:

Debug info: ERROR: function ifnull(bigint, integer) does not exist
LINE 6: ORDER BY GREATEST(IFNULL(time_created,0),IFNULL(time_modif...
^
HINT: No function matches the given name and argument types. You might need to add explicit type casts.

SELECT item.*
FROM mdl_exalib_item AS item
WHERE 1=1
GROUP BY item.id
ORDER BY GREATEST(IFNULL(time_created,0),IFNULL(time_modified,0)) DESC
LIMIT 20

[array (
)]
Error code: dmlreadexception
Stack trace:

line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
line 244 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()
line 764 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()
line 174 of /blocks/exalib/index.php: call to pgsql_native_moodle_database->get_records_sql()
line 5 of /blocks/exalib/admin.php: call to require()

For now, I am going to mark this plugin as needing more work until we get these issues resolved. Thanks for your patience with the review and approval process. Peace - Anthony

Hi There,

it looks like you are still missing some meta-data here as Anthony spotted previously (source/tracker/documentation links) as mentioned here:
https://docs.moodle.org/dev/Plugin_contribution_checklist#Meta-data

Can you please update your plugin with this information?

Hello, and sorry, I thought I had put everything in there but it got lost, anyway - it is updated again, regards Andreas

Hi Andreas,

Thanks for updating those links, I've had a quick look at the code and noticed a number of issues that I've reported to your github account that will need to be resolved before this can be approved - I didn't complete a full review or test your code but I'd encourage you to do your testing and development with PostGres instead of MySql as if it works on Postgres it is likely to work on the other databases that Moodle supports as well.

Andreas - I do not believe we are able to approve this in Moodle plugins because of the license used in jquery.lightbox.css - http://creativecommons.org/licenses/by-nd/2.5/br/deed.en_US - does not allow derivative works to be shared. Might you be able to find an alternative? For now I am going to mark this as needing more work. Peace - Anthony

Hi andreas .. can you pls direct me to the php module that does the single document creation I would like to try make it do multiple document import