Moodle plugins directory: Babellium: interactive video and audio recording assignment

Juanan - In the description you provide an alternative link for the 1.9 version; however, Moodle Plugins is designed to handle different zip files for different versions. I would recommend adding the 1.9 version zip file so that all of the Moodle plugin files are located in one spot and treated the same. Peace - Anthony

While testing, I went to create a new assignment and received the following error:

Debug info:
Error code: babeliumErrorConfigParameters
Stack trace:
line 226 of /mod/assign/submission/babelium/babeliumservice.php: moodle_exception thrown
line 131 of /mod/assign/submission/babelium/babeliumservice.php: call to babeliumservice->display_error()
line 80 of /mod/assign/submission/babelium/babeliumlib.php: call to babeliumservice->newServiceCall()
line 71 of /mod/assign/submission/babelium/locallib.php: call to babeliumsubmission_get_available_exercise_list()
line 852 of /mod/assign/locallib.php: call to assign_submission_babelium->get_settings()
line 869 of /mod/assign/locallib.php: call to assign->add_plugin_settings()
line 147 of /mod/assign/mod_form.php: call to assign->add_all_plugin_settings()
line 191 of /lib/formslib.php: call to mod_assign_mod_form->definition()
line 71 of /course/moodleform_mod.php: call to moodleform->moodleform()
line 261 of /course/modedit.php: call to moodleform_mod->moodleform_mod()
Output buffer:
Strict Standards: Declaration of assign_submission_babelium::get_files() should be compatible with assign_plugin::get_files(stdClass $submissionorgrade, stdClass $user) in /home/arborrow/NetBeansProjects/m24/mod/assign/submission/babelium/locallib.php on line 452
Empty settingsbabelium_babeliumApiAccessKey

Perhaps it is just a settings issue, I went with the defaults when I installed and have not looked carefully at this but figured I would mention it.

I also like to recommend that folks use the Moodle naming convention for Github repositories; however, this is not necessary if folks prefer a different model or convention. Using the Moodle convention simply allows our users to have a consistent experience. The recommended Moodle repository name for your project would be:
moodle-assignsubmission_babelium
Let me know if you want to or decide not to change it to the recommended name. Prior to approving, I like to give folks the option. Peace - Anthony

Hi Anthony,

first of all, thanks for your review. Let me explain the 3 points that you underscored:

* As recommended, we will upload our 1.9 version to the official Moodle plugins site. We use a different approach to develop our 1.9 vs. our 2.3 version because assign_submissions was a type only available since Moodle 2.3 . Other than that, it will be a pleasure to upload our plugin to the official plugins site.

* Regarding the babeliumErrorConfigParameters error , it is due to an empty API AccessKey. It should be entered in the plugin configuration page (in your Moodle instance, as admin). In order to get that key, you might want to go to the plugin activation page located here: http://babeliumproject.com/moodleapi.php (first you will need to register in Babelium project , though)

* With regard to the GitHub repository name, I have created one with the proposed name:

https://github.com/babeliumproject/moodle-assignsubmission_babelium

but just when I was going to push the code, I realized that all of our commit log messages will be missed in the process. Then, I tried to clone the original repo, get the history messages and export to the new one, but it yielded another problem: our plugin is inside a folder of our repo (there are other folders for the desktop version, the mobile version, etc.), I mean, the Moodle plugin version is not an isolated repo on itself, so I can certainly recover the history of the Moodle plugin but it will be intermixed with all the other commit messages of the whole repository.

So, we would prefer to keep our repository as it is right now _but_ should we had to decide in order to get your approval, we would certainly change our repository name and lose our commit messages O

Hope that this is not an obstacle to get the 2.3 version approved .

Looking forward to your reply, have a good day.

Juanan

Juanan - Thanks for the reminder about 1.9 not having assignment submissions. I think listing it as you have is fine given the age of Moodle 1.9. Yes, I was missing the API key but I am not going to bother testing that at this point. I will assume it works with issue. No worries about moving the repository - it is just a suggestion. If you were to rename the repository I would expect that to maintain the commit history (but test it first). I'm ready to approve the plugin on my end. Just let me know your preference on possibly renaming the repository (if that seems to be a viable option for you). Peace - Anthony

Hi Anthony!

we have migrated our old repo to the Moodle-based naming convention:

https://github.com/babeliumproject/moodle-assignsubmission_babelium

we managed to maintain the history logs Just in case you (or some other folks) are interested in how was it made, we "just" followed this recipe:

http://stackoverflow.com/questions/359424/detach-subdirectory-into-separate-git-repository

Thanks for your review of the new version of our plugin!

Juanan