Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(18 errors, 54 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/webanalytics/classes/form/edit.php
(#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/classes/injector.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#48) Logical operator "or" is prohibited; use "||" instead
admin/tool/webanalytics/classes/plugin_manager.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/classes/plugininfo/watool.php
(#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/classes/privacy/provider.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/classes/record.php
(#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#88) Short array syntax must be used to define arrays
admin/tool/webanalytics/classes/record_interface.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/classes/records_manager.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#86) There must not be a space before the colon in a return type declaration
(#138) There must not be a space before the colon in a return type declaration
admin/tool/webanalytics/classes/records_manager_interface.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#68) There must not be a space before the colon in a return type declaration
admin/tool/webanalytics/classes/table/tools_table.php
(#67) There should be a comma after the last array item in a multi-line array.
(#134) There should be a comma after the last array item in a multi-line array.
admin/tool/webanalytics/classes/tool/tool_base.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/classes/tool/tool_interface.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/db/upgrade.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/delete.php
(#58) Logical operator "and" is prohibited; use "&&" instead
admin/tool/webanalytics/edit.php
(#29) Import statements must not begin with a leading backslash
admin/tool/webanalytics/lib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/tests/injector_test.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#39) PHPUnit testcase name "tool_webanalytics_injector_test" does not match file name "injector_test"
(#39) PHPUnit class "tool_webanalytics_injector_test" does not have any namespace. It is recommended to add it to the "tool_webanalytics" namespace, using more levels if needed, in order to match the code being tested
(#44) Test method test_render_empty_tracking_code() is missing any coverage information, own or at class level
(#52) Test method test_render_tracking_code() is missing any coverage information, own or at class level
(#85) Test method test_render_tracking_code_without_disabled_records() is missing any coverage information, own or at class level
admin/tool/webanalytics/tests/record_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#37) PHPUnit testcase name "tool_webanalytics_record_test" does not match file name "record_test"
(#37) PHPUnit class "tool_webanalytics_record_test" does not have any namespace. It is recommended to add it to the "tool_webanalytics" namespace, using more levels if needed, in order to match the code being tested
(#54) There must not be a space before the colon in a return type declaration
(#63) There must not be a space before the colon in a return type declaration
(#72) Test method test_implements_required_interface() is missing any coverage information, own or at class level
(#81) Data provider method "default_values_data_provider" will need to be converted to static in future.
(#81) Data provider method "default_values_data_provider" must return an array, a Generator or an Iterable.
(#100) Test method test_has_correct_default_values() is missing any coverage information, own or at class level
(#107) Test method test_can_get_values() is missing any coverage information, own or at class level
(#129) Test method test_throw_exception_on_incorrect_property() is missing any coverage information, own or at class level
(#138) Test method test_is_enabled() is missing any coverage information, own or at class level
(#157) Test method test_export_empty_record() is missing any coverage information, own or at class level
(#173) Test method test_export_not_empty_record() is missing any coverage information, own or at class level
(#193) Data provider method "not_array_settings_data_provider" will need to be converted to static in future.
(#193) Data provider method "not_array_settings_data_provider" will need to be converted to static in future.
(#193) Data provider method "not_array_settings_data_provider" must return an array, a Generator or an Iterable.
(#193) Data provider method "not_array_settings_data_provider" must return an array, a Generator or an Iterable.
(#210) Test method test_return_empty_settings_if_they_are_not_array() is missing any coverage information, own or at class level
(#223) Test method test_export_empty_settings_if_they_are_not_array() is missing any coverage information, own or at class level
admin/tool/webanalytics/tests/records_manager_test.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) PHPUnit testcase name "tool_webanalytics_records_manager_test" does not match file name "records_manager_test"
(#38) PHPUnit class "tool_webanalytics_records_manager_test" does not have any namespace. It is recommended to add it to the "tool_webanalytics" namespace, using more levels if needed, in order to match the code being tested
(#80) Test method test_config_name() is missing any coverage information, own or at class level
(#87) Test method test_is_ready() is missing any coverage information, own or at class level
(#101) Test method test_get_all_records() is missing any coverage information, own or at class level
(#116) Test method test_get_enabled() is missing any coverage information, own or at class level
(#133) Test method test_get() is missing any coverage information, own or at class level
(#153) Test method test_insert_record() is missing any coverage information, own or at class level
(#198) There should be a comma after the last array item in a multi-line array.
(#205) Test method test_update_record() is missing any coverage information, own or at class level
(#260) There should be a comma after the last array item in a multi-line array.
(#268) Test method test_delete_record() is missing any coverage information, own or at class level
(#295) There should be a comma after the last array item in a multi-line array.
admin/tool/webanalytics/tool/ganalytics/classes/privacy/provider.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/tool/ganalytics/classes/tool/tool.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/tool/gtagmanager/classes/privacy/provider.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/tool/gtagmanager/classes/tool/tool.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/tool/guniversal/classes/privacy/provider.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#68) There must not be a space before the colon in a return type declaration
admin/tool/webanalytics/tool/guniversal/classes/tool/tool.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/webanalytics/tool/matomo/classes/privacy/provider.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#69) There must not be a space before the colon in a return type declaration
admin/tool/webanalytics/tool/matomo/classes/tool/tool.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

admin/tool/webanalytics/tool/matomo/templates/tracking_code.mustache
(#1) HTML Validation info, line 6: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <img src="//examplesite.com/piwik.php?idsite=1" style="border:0;" alt="" /> )

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]