Overview
(0 errors, 0 warnings)
This section shows the general problems detected when processing the code [More info]
PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(21 errors, 95 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- admin/tool/userupsert/classes/event/upsert_failed.php
- (#19) Import statements must not begin with a leading backslash
- admin/tool/userupsert/classes/event/upsert_succeeded.php
- (#19) Import statements must not begin with a leading backslash
- admin/tool/userupsert/classes/external/upsert.php
- (#73) There should be a comma after the last array item in a multi-line array.
- (#105) There should be a comma after the last array item in a multi-line array.
- (#131) There should be a comma after the last array item in a multi-line array.
- admin/tool/userupsert/classes/privacy/provider.php
- (#36) There must not be a space before the colon in a return type declaration
- admin/tool/userupsert/classes/profile_fields.php
- (#47) There should be a comma after the last array item in a multi-line array.
- (#61) There must not be a space before the colon in a return type declaration
- (#70) There must not be a space before the colon in a return type declaration
- (#104) There must not be a space before the colon in a return type declaration
- (#114) There must not be a space before the colon in a return type declaration
- admin/tool/userupsert/classes/user_extractor.php
- (#123) Short array syntax must be used to define arrays
- (#126) There should be a comma after the last array item in a multi-line array.
- admin/tool/userupsert/db/access.php
- (#31) There should be a comma after the last array item in a multi-line array.
- admin/tool/userupsert/db/install.php
- (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- admin/tool/userupsert/db/services.php
- (#34) There should be a comma after the last array item in a multi-line array.
- admin/tool/userupsert/lang/en/tool_userupsert.php
- (#43) The string key "error:creating" is not in the correct order, it should be before "error:updatingfields"
- admin/tool/userupsert/tests/config_test.php
- (#17) PHPUnit class "tool_userupsert\tests\config_test", with namespace "tool_userupsert\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
- (#22) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#33) Unit test config_test should be declared as final.
- (#38) Test method test_get_webservicefields_empty_config() is missing a return type
- (#46) Test method test_get_webservicefields() is missing a return type
- (#73) Test method test_get_mandatory_fields() is missing a return type
- (#95) Test method test_get_user_match_field() is missing a return type
- (#109) Test method test_get_data_mapping() is missing a return type
- (#136) Test method test_is_ready() is missing a return type
- (#191) Test method test_get_default_auth_empty_config() is missing a return type
- (#199) Test method test_get_get_default_auth() is missing a return type
- admin/tool/userupsert/tests/profile_fields_test.php
- (#17) PHPUnit class "tool_userupsert\tests\profile_fields_test", with namespace "tool_userupsert\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
- (#35) Unit test profile_fields_test should be declared as final.
- (#41) Test method test_constants() is missing a return type
- (#50) Test method test_get_supported_match_fields_without_profile_fields() is missing a return type
- (#63) Test method test_get_supported_match_fields_with_profile_fields() is missing a return type
- (#84) There should be a comma after the last array item in a multi-line array.
- (#94) Data provider method "is_custom_profile_field_data_provider" will need to be converted to static in future.
- (#115) Test method test_is_custom_profile_field() is missing a return type
- (#123) Data provider method "get_short_name_data_provider" will need to be converted to static in future.
- (#140) Test method test_get_short_name() is missing a return type
- (#147) Test method test_prefix_prefix_custom_profile_field() is missing a return type
- (#154) Test method test_get_profile_fields() is missing a return type
- admin/tool/userupsert/tests/test_helper_trait.php
- (#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- admin/tool/userupsert/tests/upsert_test.php
- (#16) Boilerplate comment must be followed by a single blank line or end of file
- (#18) PHPUnit class "tool_userupsert\tests\upsert_test", with namespace "tool_userupsert\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
- (#40) Unit test upsert_test should be declared as final.
- (#78) Test method test_upsert_without_permissions() is missing a return type
- (#91) There should be a comma after the last array item in a multi-line array.
- (#104) Test method test_upsert_invalid_params() is missing a return type
- (#117) There should be a comma after the last array item in a multi-line array.
- (#126) Line exceeds 132 characters; contains 168 characters
- (#134) Test method test_upsert_the_plugin_is_not_configured() is missing a return type
- (#150) There should be a comma after the last array item in a multi-line array.
- (#163) Test method test_upsert_failed() is missing a return type
- (#182) There should be a comma after the last array item in a multi-line array.
- (#204) Test method test_upsert_failed_because_missing_matching_field() is missing a return type
- (#221) There should be a comma after the last array item in a multi-line array.
- (#257) Test method test_upsert_succeed() is missing a return type
- admin/tool/userupsert/tests/user_extractor_test.php
- (#17) PHPUnit class "tool_userupsert\tests\user_extractor_test", with namespace "tool_userupsert\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
- (#37) Unit test user_extractor_test should be declared as final.
- (#43) Test method test_get_user_by_field_from_user_table() is missing a return type
- (#64) Test method test_get_user_by_field_from_user_table_deleted_user() is missing a return type
- (#83) Test method test_get_user_by_field_from_user_table_field_does_not_exist() is missing a return type
- (#95) Test method test_get_user_by_field_from_user_table_when_multiple_users_found() is missing a return type
- (#109) Test method test_get_user_by_custom_profile_field() is missing a return type
- (#117) Line exceeds 132 characters; contains 147 characters
- (#118) Line exceeds 132 characters; contains 147 characters
- (#121) Line exceeds 132 characters; contains 147 characters
- (#122) Line exceeds 132 characters; contains 147 characters
- (#125) Line exceeds 132 characters; contains 147 characters
- (#126) Line exceeds 132 characters; contains 147 characters
- (#163) Test method test_get_user_by_custom_profile_field_when_multiple_users_found() is missing a return type
- (#171) Line exceeds 132 characters; contains 147 characters
- (#172) Line exceeds 132 characters; contains 147 characters
- (#175) Line exceeds 132 characters; contains 147 characters
- (#176) Line exceeds 132 characters; contains 147 characters
- (#185) Test method test_is_email_taken() is missing a return type
- (#202) Test method test_is_username_taken() is missing a return type
- admin/tool/userupsert/tests/user_manager_test.php
- (#17) PHPUnit class "tool_userupsert\tests\user_manager_test", with namespace "tool_userupsert\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
- (#38) Unit test user_manager_test should be declared as final.
- (#59) Test method test_exception_when_not_configured() is missing a return type
- (#70) Data provider method "exception_thrown_if_missing_mandatory_field_data_provider" will need to be converted to static in future.
- (#88) Test method test_exception_thrown_if_missing_mandatory_field() is missing a return type
- (#111) Test method test_exception_thrown_if_missing_user_match_field() is missing a return type
- (#137) Test method test_incorrect_status() is missing a return type
- (#157) Test method test_can_delete_user_existing_user() is missing a return type
- (#184) Test method test_user_is_not_created_if_status_is_deleted() is missing a return type
- (#209) Test method test_exception_when_invalid_email_new_user() is missing a return type
- (#229) Test method test_exception_when_invalid_email_existing_user() is missing a return type
- (#251) Test method test_exception_when_not_allowed_email_new_user() is missing a return type
- (#272) Test method test_exception_when_not_allowed_email_existing_user() is missing a return type
- (#295) Test method test_exception_when_taken_email_new_user() is missing a return type
- (#317) Test method test_exception_when_taken_email_existing_user() is missing a return type
- (#341) Test method test_taken_email_when_duplicate_emails_are_allowed_new_user() is missing a return type
- (#366) Test method test_taken_email_when_duplicate_emails_are_allowed_existing_user() is missing a return type
- (#394) Test method test_exception_when_taken_username_new_user() is missing a return type
- (#415) Test method test_exception_when_taken_username_existing_user() is missing a return type
- (#439) Test method test_exception_invalid_auth_new_user() is missing a return type
- (#459) Test method test_exception_invalid_auth_existing_user() is missing a return type
- (#482) Test method test_exception_invalid_username_when_new_user() is missing a return type
- (#496) Line exceeds 132 characters; contains 151 characters
- (#503) Test method test_exception_invalid_username_when_existing_user() is missing a return type
- (#519) Line exceeds 132 characters; contains 151 characters
- (#526) Test method test_exception_invalid_password_when_new_user() is missing a return type
- (#539) Line exceeds 132 characters; contains 136 characters
- (#546) Test method test_exception_invalid_password_when_existing_user() is missing a return type
- (#562) Line exceeds 132 characters; contains 136 characters
- (#569) Test method test_exception_invalid_custom_profile_field_when_new_user() is missing a return type
- (#591) Line exceeds 132 characters; contains 177 characters
- (#599) Test method test_exception_invalid_custom_profile_field_when_existing_user() is missing a return type
- (#634) Line exceeds 132 characters; contains 177 characters
- (#641) Test method test_creating_a_user_without_a_password() is missing a return type
- (#660) Test method test_updating_a_user_with_a_password() is missing a return type
- (#685) Test method test_status_when_a_new_user() is missing a return type
- (#729) Test method test_status_when_existing_user() is missing a return type
- (#770) Test method test_default_auth_is_set() is missing a return type
- (#808) Test method test_can_partly_update_when_existing_user() is missing a return type
- (#854) Test method test_user_not_created_if_something_goes_wrong() is missing a return type
Javascript coding style problems
(0 errors, 0 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
CSS problems
(0 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
PHPDocs style problems
(0 errors, 0 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
grunt changes
(0 errors, 0 warnings)
This section shows files built by grunt and not commited [More info]
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 0 warnings)
This section shows problems detected in mustache templates [More info]
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]