Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(20 errors, 101 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/userupsert/classes/config.php
(#34) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/userupsert/classes/event/upsert_failed.php
(#27) Import statements must not begin with a leading backslash
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/userupsert/classes/event/upsert_succeeded.php
(#27) Import statements must not begin with a leading backslash
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/userupsert/classes/external/upsert.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#83) There should be a comma after the last array item in a multi-line array.
(#115) There should be a comma after the last array item in a multi-line array.
(#141) There should be a comma after the last array item in a multi-line array.
admin/tool/userupsert/classes/more_than_one_user_found_exception.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/userupsert/classes/privacy/provider.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#46) There must not be a space before the colon in a return type declaration
admin/tool/userupsert/classes/profile_fields.php
(#55) There should be a comma after the last array item in a multi-line array.
(#69) There must not be a space before the colon in a return type declaration
(#78) There must not be a space before the colon in a return type declaration
(#112) There must not be a space before the colon in a return type declaration
(#122) There must not be a space before the colon in a return type declaration
admin/tool/userupsert/classes/upsert_failed_exception.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/userupsert/classes/upsert_not_configured_exception.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/userupsert/classes/user_extractor.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#133) Short array syntax must be used to define arrays
(#136) There should be a comma after the last array item in a multi-line array.
admin/tool/userupsert/classes/user_manager.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/userupsert/db/access.php
(#31) There should be a comma after the last array item in a multi-line array.
admin/tool/userupsert/db/install.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/userupsert/db/services.php
(#34) There should be a comma after the last array item in a multi-line array.
admin/tool/userupsert/tests/config_test.php
(#25) PHPUnit class "tool_userupsert\tests\config_test", with namespace "tool_userupsert\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#44) Test method test_get_webservicefields_empty_config() is missing any coverage information, own or at class level
(#52) Test method test_get_webservicefields() is missing any coverage information, own or at class level
(#79) Test method test_get_mandatory_fields() is missing any coverage information, own or at class level
(#101) Test method test_get_user_match_field() is missing any coverage information, own or at class level
(#115) Test method test_get_data_mapping() is missing any coverage information, own or at class level
(#142) Test method test_is_ready() is missing any coverage information, own or at class level
(#197) Test method test_get_default_auth_empty_config() is missing any coverage information, own or at class level
(#205) Test method test_get_get_default_auth() is missing any coverage information, own or at class level
admin/tool/userupsert/tests/profile_fields_test.php
(#25) PHPUnit class "tool_userupsert\tests\profile_fields_test", with namespace "tool_userupsert\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
(#47) Test method test_constants() is missing any coverage information, own or at class level
(#56) Test method test_get_supported_match_fields_without_profile_fields() is missing any coverage information, own or at class level
(#69) Test method test_get_supported_match_fields_with_profile_fields() is missing any coverage information, own or at class level
(#90) There should be a comma after the last array item in a multi-line array.
(#100) Data provider method "is_custom_profile_field_data_provider" will need to be converted to static in future.
(#121) Test method test_is_custom_profile_field() is missing any coverage information, own or at class level
(#129) Data provider method "get_short_name_data_provider" will need to be converted to static in future.
(#146) Test method test_get_short_name() is missing any coverage information, own or at class level
(#153) Test method test_prefix_prefix_custom_profile_field() is missing any coverage information, own or at class level
(#160) Test method test_get_profile_fields() is missing any coverage information, own or at class level
admin/tool/userupsert/tests/test_helper_trait.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/userupsert/tests/upsert_test.php
(#25) PHPUnit class "tool_userupsert\tests\upsert_test", with namespace "tool_userupsert\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
(#86) Test method test_upsert_without_permissions() is missing any coverage information, own or at class level
(#99) There should be a comma after the last array item in a multi-line array.
(#112) Test method test_upsert_invalid_params() is missing any coverage information, own or at class level
(#125) There should be a comma after the last array item in a multi-line array.
(#134) Line exceeds 132 characters; contains 168 characters
(#142) Test method test_upsert_the_plugin_is_not_configured() is missing any coverage information, own or at class level
(#158) There should be a comma after the last array item in a multi-line array.
(#171) Test method test_upsert_failed() is missing any coverage information, own or at class level
(#190) There should be a comma after the last array item in a multi-line array.
(#212) Test method test_upsert_failed_because_missing_matching_field() is missing any coverage information, own or at class level
(#229) There should be a comma after the last array item in a multi-line array.
(#265) Test method test_upsert_succeed() is missing any coverage information, own or at class level
admin/tool/userupsert/tests/user_extractor_test.php
(#25) PHPUnit class "tool_userupsert\tests\user_extractor_test", with namespace "tool_userupsert\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
(#49) Test method test_get_user_by_field_from_user_table() is missing any coverage information, own or at class level
(#70) Test method test_get_user_by_field_from_user_table_deleted_user() is missing any coverage information, own or at class level
(#89) Test method test_get_user_by_field_from_user_table_field_does_not_exist() is missing any coverage information, own or at class level
(#101) Test method test_get_user_by_field_from_user_table_when_multiple_users_found() is missing any coverage information, own or at class level
(#115) Test method test_get_user_by_custom_profile_field() is missing any coverage information, own or at class level
(#123) Line exceeds 132 characters; contains 147 characters
(#124) Line exceeds 132 characters; contains 147 characters
(#127) Line exceeds 132 characters; contains 147 characters
(#128) Line exceeds 132 characters; contains 147 characters
(#131) Line exceeds 132 characters; contains 147 characters
(#132) Line exceeds 132 characters; contains 147 characters
(#169) Test method test_get_user_by_custom_profile_field_when_multiple_users_found() is missing any coverage information, own or at class level
(#177) Line exceeds 132 characters; contains 147 characters
(#178) Line exceeds 132 characters; contains 147 characters
(#181) Line exceeds 132 characters; contains 147 characters
(#182) Line exceeds 132 characters; contains 147 characters
(#191) Test method test_is_email_taken() is missing any coverage information, own or at class level
(#208) Test method test_is_username_taken() is missing any coverage information, own or at class level
admin/tool/userupsert/tests/user_manager_test.php
(#25) PHPUnit class "tool_userupsert\tests\user_manager_test", with namespace "tool_userupsert\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
(#65) Test method test_exception_when_not_configured() is missing any coverage information, own or at class level
(#76) Data provider method "exception_thrown_if_missing_mandatory_field_data_provider" will need to be converted to static in future.
(#94) Test method test_exception_thrown_if_missing_mandatory_field() is missing any coverage information, own or at class level
(#117) Test method test_exception_thrown_if_missing_user_match_field() is missing any coverage information, own or at class level
(#143) Test method test_incorrect_status() is missing any coverage information, own or at class level
(#163) Test method test_can_delete_user_existing_user() is missing any coverage information, own or at class level
(#190) Test method test_user_is_not_created_if_status_is_deleted() is missing any coverage information, own or at class level
(#215) Test method test_exception_when_invalid_email_new_user() is missing any coverage information, own or at class level
(#235) Test method test_exception_when_invalid_email_existing_user() is missing any coverage information, own or at class level
(#257) Test method test_exception_when_not_allowed_email_new_user() is missing any coverage information, own or at class level
(#271) Line exceeds 132 characters; contains 136 characters
(#280) Test method test_exception_when_not_allowed_email_existing_user() is missing any coverage information, own or at class level
(#296) Line exceeds 132 characters; contains 136 characters
(#305) Test method test_exception_when_taken_email_new_user() is missing any coverage information, own or at class level
(#327) Test method test_exception_when_taken_email_existing_user() is missing any coverage information, own or at class level
(#351) Test method test_taken_email_when_duplicate_emails_are_allowed_new_user() is missing any coverage information, own or at class level
(#376) Test method test_taken_email_when_duplicate_emails_are_allowed_existing_user() is missing any coverage information, own or at class level
(#404) Test method test_exception_when_taken_username_new_user() is missing any coverage information, own or at class level
(#425) Test method test_exception_when_taken_username_existing_user() is missing any coverage information, own or at class level
(#449) Test method test_exception_invalid_auth_new_user() is missing any coverage information, own or at class level
(#469) Test method test_exception_invalid_auth_existing_user() is missing any coverage information, own or at class level
(#492) Test method test_exception_invalid_username_when_new_user() is missing any coverage information, own or at class level
(#506) Line exceeds 132 characters; contains 151 characters
(#513) Test method test_exception_invalid_username_when_existing_user() is missing any coverage information, own or at class level
(#529) Line exceeds 132 characters; contains 151 characters
(#536) Test method test_exception_invalid_password_when_new_user() is missing any coverage information, own or at class level
(#549) Line exceeds 132 characters; contains 136 characters
(#556) Test method test_exception_invalid_password_when_existing_user() is missing any coverage information, own or at class level
(#572) Line exceeds 132 characters; contains 136 characters
(#579) Test method test_exception_invalid_custom_profile_field_when_new_user() is missing any coverage information, own or at class level
(#601) Line exceeds 132 characters; contains 177 characters
(#609) Test method test_exception_invalid_custom_profile_field_when_existing_user() is missing any coverage information, own or at class level
(#644) Line exceeds 132 characters; contains 177 characters
(#651) Test method test_creating_a_user_without_a_password() is missing any coverage information, own or at class level
(#670) Test method test_updating_a_user_with_a_password() is missing any coverage information, own or at class level
(#695) Test method test_status_when_a_new_user() is missing any coverage information, own or at class level
(#739) Test method test_status_when_existing_user() is missing any coverage information, own or at class level
(#780) Test method test_default_auth_is_set() is missing any coverage information, own or at class level
(#818) Test method test_can_partly_update_when_existing_user() is missing any coverage information, own or at class level
(#864) Test method test_user_not_created_if_something_goes_wrong() is missing any coverage information, own or at class level

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]