Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(215 errors, 63 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/untoken_oauth2/class/sform.php
(#1) Missing docblock for file sform.php
(#30) Inline comments must start with a capital letter, digit or 3-dots sequence
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#30) No space found before comment text; expected "// moodleform is defined in formslib.php" but found "//moodleform is defined in formslib.php"
(#31) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#34) Missing docblock for class sform
(#35) Line indented incorrectly; expected at least 4 spaces, found 0
(#36) Line indented incorrectly; expected at least 4 spaces, found 1
(#36) Whitespace found at end of line
(#37) Line indented incorrectly; expected at least 4 spaces, found 1
(#38) Line indented incorrectly; expected at least 4 spaces, found 1
(#39) Line indented incorrectly; expected at least 4 spaces, found 1
(#40) Line indented incorrectly; expected at least 4 spaces, found 1
(#41) Line indented incorrectly; expected at least 4 spaces, found 1
(#43) Spaces must be used to indent lines; tabs are not allowed
(#43) Tab found within whitespace
(#43) Line indented incorrectly; expected 4 spaces, found 1
(#43) Missing docblock for function definition
(#44) Spaces must be used to indent lines; tabs are not allowed
(#44) Tab found within whitespace
(#46) Spaces must be used to indent lines; tabs are not allowed
(#46) Tab found within whitespace
(#46) Whitespace found at end of line
(#47) Spaces must be used to indent lines; tabs are not allowed
(#47) Tab found within whitespace
(#47) Commas (,) must be followed by white space.
(#48) Spaces must be used to indent lines; tabs are not allowed
(#48) Tab found within whitespace
(#48) Commas (,) must be followed by white space.
(#48) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) Spaces must be used to indent lines; tabs are not allowed
(#49) Tab found within whitespace
(#49) Commas (,) must be followed by white space.
(#49) Line exceeds 132 characters; contains 150 characters
(#50) Spaces must be used to indent lines; tabs are not allowed
(#50) Tab found within whitespace
(#50) Line indented incorrectly; expected at least 8 spaces, found 2
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) No space found before comment text; expected "// Set type of element" but found "//Set type of element"
(#51) Spaces must be used to indent lines; tabs are not allowed
(#51) Tab found within whitespace
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) No space found before comment text; expected "// Default value" but found "//Default value"
(#52) Spaces must be used to indent lines; tabs are not allowed
(#52) Tab found within whitespace
(#52) Whitespace found at end of line
(#53) Spaces must be used to indent lines; tabs are not allowed
(#53) Tab found within whitespace
(#53) Commas (,) must be followed by white space.
(#54) Spaces must be used to indent lines; tabs are not allowed
(#54) Tab found within whitespace
(#54) Line indented incorrectly; expected 8 spaces, found 2
(#54) Expected "if (...) {\n"; found "if (...){\n"
(#55) Spaces must be used to indent lines; tabs are not allowed
(#55) Tab found within whitespace
(#55) Line indented incorrectly; expected at least 12 spaces, found 3
(#56) Spaces must be used to indent lines; tabs are not allowed
(#56) Tab found within whitespace
(#56) Line indented incorrectly; expected 8 spaces, found 2
(#57) Spaces must be used to indent lines; tabs are not allowed
(#57) Tab found within whitespace
(#57) Line indented incorrectly; expected 4 spaces, found 1
(#58) Spaces must be used to indent lines; tabs are not allowed
(#58) Tab found within whitespace
(#58) Whitespace found at end of line
(#59) Line indented incorrectly; expected at least 4 spaces, found 0
(#60) Line indented incorrectly; expected at least 4 spaces, found 1
(#60) Whitespace found at end of line
(#61) Line indented incorrectly; expected at least 4 spaces, found 1
(#62) Line indented incorrectly; expected at least 4 spaces, found 1
(#63) Line indented incorrectly; expected at least 4 spaces, found 1
(#64) Line indented incorrectly; expected at least 4 spaces, found 1
(#65) Spaces must be used to indent lines; tabs are not allowed
(#65) Tab found within whitespace
(#65) Whitespace found at end of line
(#66) Spaces must be used to indent lines; tabs are not allowed
(#66) Tab found within whitespace
(#66) Missing docblock for function validation
(#66) Line indented incorrectly; expected 4 spaces, found 1
(#66) Visibility must be declared on method "validation"
(#67) Spaces must be used to indent lines; tabs are not allowed
(#67) Tab found within whitespace
(#67) Line indented incorrectly; expected at least 8 spaces, found 2
(#67) Commas (,) must be followed by white space.
(#67) Whitespace found at end of line
(#68) Spaces must be used to indent lines; tabs are not allowed
(#68) Tab found within whitespace
(#68) Line indented incorrectly; expected 8 spaces, found 2
(#69) Spaces must be used to indent lines; tabs are not allowed
(#69) Tab found within whitespace
(#69) Line indented incorrectly; expected 12 spaces, found 14
(#70) Spaces must be used to indent lines; tabs are not allowed
(#70) Tab found within whitespace
(#71) Spaces must be used to indent lines; tabs are not allowed
(#71) Tab found within whitespace
(#71) Line indented incorrectly; expected 12 spaces, found 14
(#72) Spaces must be used to indent lines; tabs are not allowed
(#72) Tab found within whitespace
(#72) Line indented incorrectly; expected 8 spaces, found 9
(#72) Closing brace indented incorrectly; expected 2 spaces, found 9
(#74) Spaces must be used to indent lines; tabs are not allowed
(#74) Tab found within whitespace
(#74) Line indented incorrectly; expected 4 spaces, found 1
(#88) Missing docblock for class dform
(#89) Inline comments must end in full-stops, exclamation marks, or question marks
(#89) No space found before comment text; expected "// Add elements to form" but found "//Add elements to form"
(#91) Line indented incorrectly; expected 4 spaces, found 8
(#91) Missing docblock for function definition
(#94) Whitespace found at end of line
(#95) Commas (,) must be followed by white space.
(#95) Commas (,) must be followed by white space.
(#96) Spaces must be used to indent lines; tabs are not allowed
(#96) Tab found within whitespace
(#96) Line indented incorrectly; expected at least 8 spaces, found 2
(#96) Commas (,) must be followed by white space.
(#97) Spaces must be used to indent lines; tabs are not allowed
(#97) Tab found within whitespace
(#97) Line indented incorrectly; expected at least 8 spaces, found 7
(#97) Commas (,) must be followed by white space.
(#99) Spaces must be used to indent lines; tabs are not allowed
(#99) Tab found within whitespace
(#99) Line indented incorrectly; expected 4 spaces, found 1
(#99) Closing brace indented incorrectly; expected 8 spaces, found 1
(#112) Missing docblock for class lform
(#113) Inline comments must end in full-stops, exclamation marks, or question marks
(#113) No space found before comment text; expected "// Add elements to form" but found "//Add elements to form"
(#115) Line indented incorrectly; expected 4 spaces, found 8
(#115) Missing docblock for function definition
(#118) Whitespace found at end of line
(#119) Commas (,) must be followed by white space.
(#119) Commas (,) must be followed by white space.
(#120) Commas (,) must be followed by white space.
(#121) Commas (,) must be followed by white space.
(#123) Line indented incorrectly; expected 4 spaces, found 8
(#136) Missing docblock for class mform
(#137) Inline comments must end in full-stops, exclamation marks, or question marks
(#137) No space found before comment text; expected "// Add elements to form" but found "//Add elements to form"
(#139) Line indented incorrectly; expected 4 spaces, found 8
(#139) Missing docblock for function definition
(#142) Whitespace found at end of line
(#143) Commas (,) must be followed by white space.
(#144) Commas (,) must be followed by white space.
(#145) Commas (,) must be followed by white space.
(#146) Spaces must be used to indent lines; tabs are not allowed
(#146) Tab found within whitespace
(#146) Line indented incorrectly; expected at least 8 spaces, found 2
(#146) Commas (,) must be followed by white space.
(#146) Line exceeds maximum limit of 180 characters; contains 221 characters
(#147) Spaces must be used to indent lines; tabs are not allowed
(#147) Tab found within whitespace
(#147) Line indented incorrectly; expected at least 8 spaces, found 2
(#147) Commas (,) must be followed by white space.
(#147) Line exceeds maximum limit of 180 characters; contains 236 characters
(#148) Line indented incorrectly; expected 4 spaces, found 8
admin/tool/untoken_oauth2/db/access.php
(#31) Short array syntax must be used to define arrays
(#33) Short array syntax must be used to define arrays
(#35) Commas (,) must be followed by white space.
(#37) Short array syntax must be used to define arrays
(#38) There should be a comma after the last array item in a multi-line array.
(#41) Short array syntax must be used to define arrays
(#43) Commas (,) must be followed by white space.
(#45) Short array syntax must be used to define arrays
(#46) There should be a comma after the last array item in a multi-line array.
admin/tool/untoken_oauth2/db/install.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/untoken_oauth2/db/uninstall.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/untoken_oauth2/db/upgrade.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#36) Missing @copyright tag
(#36) Missing @license tag
(#36) Missing docblock for function xmldb_tool_untoken_oauth2_upgrade
(#37) Inline comments must start with a capital letter, digit or 3-dots sequence
(#37) Inline comments must end in full-stops, exclamation marks, or question marks
(#37) Line indented incorrectly; expected at least 4 spaces, found 0
(#37) No space found before comment text; expected "// upgrade function" but found "//upgrade function"
(#42) Inline comments must start with a capital letter, digit or 3-dots sequence
(#42) Inline comments must end in full-stops, exclamation marks, or question marks
(#42) This comment is 70% valid code; is this commented out code?
(#42) Line indented incorrectly; expected at least 8 spaces, found 0
(#42) Expected 1 space before comment text but found 8; use block comment if you need indentation
(#45) Functions must not contain multiple empty lines in a row; found 2 empty lines
admin/tool/untoken_oauth2/db/upgradelib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
admin/tool/untoken_oauth2/delete.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file delete.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#25) Whitespace found at end of line
(#35) "require_once" must be immediately followed by an open parenthesis
(#36) "require_once" must be immediately followed by an open parenthesis
(#71) Short array syntax must be used to define arrays
(#76) There should be a comma after the last array item in a multi-line array.
(#78) Whitespace found at end of line within string
(#80) There should be a comma after the last array item in a multi-line array.
(#87) Short array syntax must be used to define arrays
(#92) There should be a comma after the last array item in a multi-line array.
(#100) There should be a comma after the last array item in a multi-line array.
(#125) Short array syntax must be used to define arrays
admin/tool/untoken_oauth2/lang/en/tool_untoken_oauth2.php
(#28) The string key "untoken_oauth2:action" is not in the correct order, it should be before "untoken_oauth2:search"
(#29) The string key "pluginname" is not in the correct order, it should be before "untoken_oauth2:action"
(#30) The string key "manager" is not in the correct order, it should be before "pluginname"
(#32) The string key "search" is not in the correct order, it should be before "settings"
(#33) The string key "logevent" is not in the correct order, it should be before "search"
(#34) The string key "headeventtag" is not in the correct order, it should be before "logevent"
(#37) The string key "infologtag" is not in the correct order, it should be before "infoprocestag"
(#39) The string key "descriptionmanagertag" is not in the correct order, it should be before "information"
(#42) The string key "deleted" is not in the correct order, it should be before "emailsearchtag"
(#45) The string key "delbutton" is not in the correct order, it should be before "searchbutton"
(#48) The string key "descriptionlogtag" is not in the correct order, it should be before "headprocestag"
(#50) The string key "eventlbmanagertag" is not in the correct order, it should be before "searchbmanagertag"
(#54) The string key "headsearchtag" is not in the correct order, it should be before "managerinfo"
(#56) The string key "confirmsearchtag" is not in the correct order, it should be before "titlesearchtag"
(#58) The string key "notfoundsearchtag" is not in the correct order, it should be before "notsearchtag"
(#59) The string key "cancelsearchtag" is not in the correct order, it should be before "notfoundsearchtag"
admin/tool/untoken_oauth2/logevent.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file logevent.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#25) Whitespace found at end of line
(#37) "require_once" must be immediately followed by an open parenthesis
(#38) "require_once" must be immediately followed by an open parenthesis
(#52) Inline comments must start with a capital letter, digit or 3-dots sequence
(#52) Inline comments must end in full-stops, exclamation marks, or question marks
(#65) Short array syntax must be used to define arrays
(#69) Short array syntax must be used to define arrays
(#76) There should be a comma after the last array item in a multi-line array.
(#93) Short array syntax must be used to define arrays
(#100) There should be a comma after the last array item in a multi-line array.
(#107) Short array syntax must be used to define arrays
(#109) Short array syntax must be used to define arrays
(#112) There should be a comma after the last array item in a multi-line array.
admin/tool/untoken_oauth2/manager.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file manager.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#26) "require_once" must be immediately followed by an open parenthesis
(#27) "require_once" must be immediately followed by an open parenthesis
(#58) Short array syntax must be used to define arrays
(#59) There should be a comma after the last array item in a multi-line array.
(#62) Short array syntax must be used to define arrays
(#63) There should be a comma after the last array item in a multi-line array.
admin/tool/untoken_oauth2/searchlink.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file searchlink.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#25) Whitespace found at end of line
(#31) "require_once" must be immediately followed by an open parenthesis
(#32) "require_once" must be immediately followed by an open parenthesis
(#58) Whitespace found at end of line within string
(#59) Whitespace found at end of line within string
(#61) There should be a comma after the last array item in a multi-line array.
(#68) Short array syntax must be used to define arrays
(#74) There should be a comma after the last array item in a multi-line array.
(#77) Whitespace found at end of line within string
(#78) Whitespace found at end of line within string
(#80) There should be a comma after the last array item in a multi-line array.
(#84) Short array syntax must be used to define arrays
(#90) There should be a comma after the last array item in a multi-line array.
(#97) Short array syntax must be used to define arrays
(#101) There should be a comma after the last array item in a multi-line array.
(#104) Short array syntax must be used to define arrays
(#105) There should be a comma after the last array item in a multi-line array.
admin/tool/untoken_oauth2/settings.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#32) Line exceeds maximum limit of 180 characters; contains 189 characters
(#33) Inline comments must start with a capital letter, digit or 3-dots sequence
(#33) This comment is 100% valid code; is this commented out code?
admin/tool/untoken_oauth2/tests/test_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#45) Testcase tool_untoken_oauth2_test_testcase should be declared as abstract.
(#45) PHPUnit test file missing any valid testcase class declaration
admin/tool/untoken_oauth2/version.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#27) Inline comments must end in full-stops, exclamation marks, or question marks
(#32) Inline comments must end in full-stops, exclamation marks, or question marks
(#34) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]