Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 15 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/trigger/classes/event_processor.php
(#776) Inline comments must end in full-stops, exclamation marks, or question marks
(#809) Inline comments must end in full-stops, exclamation marks, or question marks
(#810) Line exceeds 132 characters; contains 141 characters
admin/tool/trigger/classes/output/workflowhistory/workflow.php
(#124) Line exceeds 132 characters; contains 133 characters
admin/tool/trigger/classes/steps/actions/http_post_action_step.php
(#164) Line exceeds 132 characters; contains 150 characters
admin/tool/trigger/classes/steps/debounce/debounce_step.php
(#199) Line exceeds 132 characters; contains 138 characters
admin/tool/trigger/classes/task/process_workflows.php
(#215) Inline comments must end in full-stops, exclamation marks, or question marks
admin/tool/trigger/externallib.php
(#78) Inline comments must end in full-stops, exclamation marks, or question marks
admin/tool/trigger/tests/debounce_step_test.php
(#116) Inline comments must end in full-stops, exclamation marks, or question marks
(#132) Inline comments must end in full-stops, exclamation marks, or question marks
(#152) Inline comments must end in full-stops, exclamation marks, or question marks
(#185) Inline comments must end in full-stops, exclamation marks, or question marks
(#212) Inline comments must end in full-stops, exclamation marks, or question marks
admin/tool/trigger/tests/process_workflows_test.php
(#123) Inline comments must end in full-stops, exclamation marks, or question marks
admin/tool/trigger/tests/tool_trigger_testcase.php
(#75) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 46 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

admin/tool/trigger/amd/src/import_workflow.js
(#28) A space is required after ','. (comma-spacing)
(#30) Unexpected space before function parentheses. (space-before-function-paren)
(#54) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#76) Multiple spaces found before '// We're lazy ...'. (no-multi-spaces)
(#99) Missing JSDoc for parameter 'context'. (valid-jsdoc)
(#109) Expected catch,fail() or return (promise/catch-or-return)
(#109) Each then() should return a value or throw (promise/always-return)
admin/tool/trigger/amd/src/step_select.js
(#28) A space is required after ','. (comma-spacing)
(#30) Unexpected space before function parentheses. (space-before-function-paren)
(#42) Missing JSDoc @returns for function. (valid-jsdoc)
(#54) Missing JSDoc for parameter 'steps'. (valid-jsdoc)
(#75) Missing JSDoc comment. (require-jsdoc)
(#93) Each then() should return a value or throw (promise/always-return)
(#101) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#126) ["stepdesc"] is better written in dot notation. (dot-notation)
(#127) ["typedesc"] is better written in dot notation. (dot-notation)
(#133) ["stepclass"] is better written in dot notation. (dot-notation)
(#158) ["type"] is better written in dot notation. (dot-notation)
(#158) ["stepclass"] is better written in dot notation. (dot-notation)
(#167) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#167) Expected JSDoc for 'events' but found 'array'. (valid-jsdoc)
(#174) Extra space after key 'text'. (key-spacing)
(#178) Unexpected space before function parentheses. (space-before-function-paren)
(#181) Extra space after key 'text'. (key-spacing)
(#190) Missing JSDoc parameter type for 'string'. (valid-jsdoc)
(#190) Expected JSDoc for 'valfilter' but found 'string'. (valid-jsdoc)
(#194) There should be no space after '{'. (babel/object-curly-spacing)
(#194) There should be no space before '}'. (babel/object-curly-spacing)
(#211) Missing JSDoc for parameter 'steporder'. (valid-jsdoc)
(#240) Extra space after key 'steptype'. (key-spacing)
(#241) Extra space after key 'stepclass'. (key-spacing)
(#269) Missing JSDoc comment. (require-jsdoc)
(#269) Missing space before opening brace. (space-before-blocks)
(#289) Missing space before opening brace. (space-before-blocks)
(#293) Missing space before opening brace. (space-before-blocks)
(#297) Missing space before opening brace. (space-before-blocks)
(#299) Missing space before opening brace. (space-before-blocks)
(#303) Missing space before opening brace. (space-before-blocks)
(#316) Missing space before opening brace. (space-before-blocks)
(#342) There should be no space before ','. (comma-spacing)
(#376) ["type"] is better written in dot notation. (dot-notation)
(#377) ["stepclass"] is better written in dot notation. (dot-notation)
(#403) Missing space before opening brace. (space-before-blocks)
(#412) Missing JSDoc for parameter 'context'. (valid-jsdoc)
(#422) Expected catch,fail() or return (promise/catch-or-return)
(#422) Each then() should return a value or throw (promise/always-return)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(145 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

admin/tool/trigger/classes/event_processor.php
(#203) Function event_processor::process_realtime_workflow is not documented
(#348) Phpdocs for function event_processor::record_failed_step has incomplete parameters list
(#411) Phpdocs for function event_processor::execute_current_step has incomplete parameters list
(#453) Phpdocs for function event_processor::execute_next_step_historic has incomplete parameters list
(#534) Phpdocs for function event_processor::execute_next_step_current has incomplete parameters list
(#589) Phpdocs for function event_processor::execute_step_and_continue_historic has incomplete parameters list
(#634) Phpdocs for function event_processor::execute_step_and_continue_current has incomplete parameters list
admin/tool/trigger/classes/output/manageworkflows/renderable.php
(#145) Function renderable::col_triggerhistory is not documented
(#184) Function renderable::col_active is not documented
admin/tool/trigger/classes/output/workflowhistory/renderer.php
(#79) Function renderer::step_actions_button is not documented
(#156) Function renderer::run_actions_button is not documented
(#44) Phpdocs for function renderer::render_table has incomplete parameters list
(#192) Phpdocs for function renderer::rerun_all_historic_button has incomplete parameters list
(#204) Phpdocs for function renderer::rerun_all_current_button has incomplete parameters list
admin/tool/trigger/classes/output/workflowhistory/run.php
(#34) Class runhistory_renderable is not documented
(#92) Function runhistory_renderable::col_step is not documented
(#97) Function runhistory_renderable::col_id is not documented
(#101) Function runhistory_renderable::col_name is not documented
(#105) Function runhistory_renderable::col_type is not documented
(#109) Function runhistory_renderable::col_executed is not documented
(#114) Function runhistory_renderable::col_prevstep is not documented
(#122) Function runhistory_renderable::col_actions is not documented
admin/tool/trigger/classes/output/workflowhistory/workflow.php
(#31) Class workflowhistory_renderable is not documented
(#85) Function workflowhistory_renderable::col_id is not documented
(#89) Function workflowhistory_renderable::col_number is not documented
(#93) Function workflowhistory_renderable::col_eventid is not documented
(#97) Function workflowhistory_renderable::col_username is not documented
(#103) Function workflowhistory_renderable::col_description is not documented
(#112) Function workflowhistory_renderable::col_time is not documented
(#117) Function workflowhistory_renderable::col_runstatus is not documented
(#145) Function workflowhistory_renderable::col_actions is not documented
admin/tool/trigger/classes/steps/actions/assign_cohort_action_step.php
(#30) Class assign_cohort_action_step is not documented
(#60) Function assign_cohort_action_step::init is not documented
(#65) There is no description in phpdocs for function execute
(#66) Phpdocs for function assign_cohort_action_step::execute has incomplete parameters list
(#81) Phpdocs for function assign_cohort_action_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/actions/email_action_step.php
(#110) There is no description in phpdocs for function execute
(#111) Phpdocs for function email_action_step::execute has incomplete parameters list
(#177) Phpdocs for function email_action_step::form_definition_extra has incomplete parameters list
(#214) Phpdocs for function email_action_step::add_privacy_metadata has incomplete parameters list
admin/tool/trigger/classes/steps/actions/http_post_action_step.php
(#55) Function http_post_action_step::init is not documented
(#40) Variable http_post_action_step::$url is not documented
(#41) Variable http_post_action_step::$headers is not documented
(#42) Variable http_post_action_step::$params is not documented
(#86) Variable http_post_action_step::$httphandler is not documented
(#112) There is no description in phpdocs for function execute
(#113) Phpdocs for function http_post_action_step::execute has incomplete parameters list
(#170) Phpdocs for function http_post_action_step::form_definition_extra has incomplete parameters list
(#212) Phpdocs for function http_post_action_step::add_privacy_metadata has incomplete parameters list
admin/tool/trigger/classes/steps/actions/logdump_action_step.php
(#40) Function logdump_action_step::form_definition_extra is not documented
(#47) Function logdump_action_step::get_step_desc is not documented
(#51) Function logdump_action_step::get_step_name is not documented
(#55) Function logdump_action_step::execute is not documented
admin/tool/trigger/classes/steps/actions/role_assign_action_step.php
(#29) Class role_assign_action_step is not documented
(#75) There is no description in phpdocs for function init
(#84) There is no description in phpdocs for function execute
(#84) Phpdocs for function role_assign_action_step::execute has incomplete parameters list
(#133) Phpdocs for function role_assign_action_step::form_definition_extra has incomplete parameters list
(#76) Invalid phpdocs tag @inheritdoc used
(#85) Invalid phpdocs tag @inheritdoc used
admin/tool/trigger/classes/steps/actions/roles_unassign_action_step.php
(#55) Function roles_unassign_action_step::init is not documented
(#53) Variable roles_unassign_action_step::$inputprefixrole is not documented
(#86) There is no description in phpdocs for function execute
(#87) Phpdocs for function roles_unassign_action_step::execute has incomplete parameters list
(#109) Phpdocs for function roles_unassign_action_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/base/base_form.php
(#51) Phpdocs for function base_form::__construct has incomplete parameters list
(#106) Phpdocs for function base_form::get_trigger_fields has incomplete parameters list
admin/tool/trigger/classes/steps/base/base_step.php
(#42) Function base_step::__construct is not documented
(#38) Variable base_step::$data is not documented
(#40) Variable base_step::$stepfields is not documented
admin/tool/trigger/classes/steps/debounce/debounce_form.php
(#40) Function debounce_form::definition is not documented
admin/tool/trigger/classes/steps/debounce/debounce_step.php
(#84) Phpdocs for function debounce_step::execute has incomplete parameters list
(#245) Phpdocs for function debounce_step::make_form has incomplete parameters list
(#261) Phpdocs for function debounce_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/filters/fail_filter_step.php
(#41) Phpdocs for function fail_filter_step::execute has incomplete parameters list
(#65) Phpdocs for function fail_filter_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/filters/numcompare_filter_step.php
(#96) Function numcompare_filter_step::get_field_value is not documented
(#42) Constant numcompare_filter_step::OPERATOR_EQUAL is not documented
(#43) Constant numcompare_filter_step::OPERATOR_NOTEQUAL is not documented
(#44) Constant numcompare_filter_step::OPERATOR_LT is not documented
(#45) Constant numcompare_filter_step::OPERATOR_LTE is not documented
(#46) Constant numcompare_filter_step::OPERATOR_GTE is not documented
(#47) Constant numcompare_filter_step::OPERATOR_GT is not documented
(#61) Phpdocs for function numcompare_filter_step::execute has incomplete parameters list
(#142) Phpdocs for function numcompare_filter_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/filters/stringcompare_filter_step.php
(#117) Phpdocs for function stringcompare_filter_step::execute has incomplete parameters list
(#185) Phpdocs for function stringcompare_filter_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/lookups/cohort_lookup_step.php
(#57) Function cohort_lookup_step::init is not documented
(#20) No one-line description found in phpdocs for class cohort_lookup_step
(#62) Phpdocs for function cohort_lookup_step::execute has incomplete parameters list
(#86) Phpdocs for function cohort_lookup_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/lookups/course_cat_lookup_step.php
(#69) Function course_cat_lookup_step::init is not documented
(#74) Phpdocs for function course_cat_lookup_step::execute has incomplete parameters list
(#115) Phpdocs for function course_cat_lookup_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/lookups/course_lookup_step.php
(#87) Function course_lookup_step::init is not documented
(#21) No one-line description found in phpdocs for class course_lookup_step
(#92) Phpdocs for function course_lookup_step::execute has incomplete parameters list
(#133) Phpdocs for function course_lookup_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/lookups/roles_lookup_step.php
(#54) Function roles_lookup_step::init is not documented
(#59) Phpdocs for function roles_lookup_step::execute has incomplete parameters list
(#86) Phpdocs for function roles_lookup_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/lookups/user_lookup_step.php
(#115) Function user_lookup_step::init is not documented
(#23) No one-line description found in phpdocs for class user_lookup_step
(#127) Phpdocs for function user_lookup_step::execute has incomplete parameters list
(#173) Phpdocs for function user_lookup_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/task/process_workflows.php
(#126) Function process_workflows::process_queue is not documented
(#152) Function process_workflows::process_item is not documented
(#94) Phpdocs for function process_workflows::create_trigger_queue has incomplete parameters list
admin/tool/trigger/classes/workflow_manager.php
(#320) Phpdocs for function workflow_manager::validate_and_make_step has incomplete parameters list
admin/tool/trigger/classes/workflow_process.php
(#256) There is no description in phpdocs for function import_prep
admin/tool/trigger/cli/import_csv_records.php
(#17) No one-line description found in phpdocs for file
admin/tool/trigger/db/messages.php
(#16) File-level phpdocs block does not have @copyright tag
admin/tool/trigger/db/tasks.php
(#20) Package tool_monitor is not valid
admin/tool/trigger/externallib.php
(#49) Phpdocs for function tool_trigger_external::step_by_type has incomplete parameters list
(#120) Phpdocs for function tool_trigger_external::validate_form has incomplete parameters list
(#180) Phpdocs for function tool_trigger_external::process_import_form has incomplete parameters list
admin/tool/trigger/lib.php
(#34) Phpdocs for function tool_trigger_output_fragment_new_base_form has incomplete parameters list
(#55) Phpdocs for function tool_trigger_output_fragment_new_step_form has incomplete parameters list
admin/tool/trigger/tests/course_cat_lookup_step_test.php
(#30) Class tool_trigger_course_cat_lookup_step_testcase is not documented
(#180) Phpdocs for function tool_trigger_course_cat_lookup_step_testcase::test_execute_category_id has incomplete parameters list
admin/tool/trigger/tests/course_lookup_step_test.php
(#30) Class tool_trigger_course_lookup_step_testcase is not documented
(#138) Phpdocs for function tool_trigger_course_lookup_step_testcase::test_execute_course_id has incomplete parameters list
admin/tool/trigger/tests/datafield_manager_test.php
(#31) Class tool_trigger_datafield_manager_testcase is not documented
admin/tool/trigger/tests/debounce_step_test.php
(#31) Class debounce_step_testcase is not documented
(#86) Function debounce_step_testcase::get_mock_queue_item is not documented
(#39) Phpdocs for variable debounce_step_testcase::$eventid does not contain @var or incorrect
admin/tool/trigger/tests/email_action_step_test.php
(#31) Class tool_trigger_email_action_step_testcase is not documented
admin/tool/trigger/tests/event_processor_test.php
(#39) Class tool_trigger_event_processor_testcase is not documented
admin/tool/trigger/tests/fail_filter_step_test.php
(#30) Class tool_trigger_fail_filter_step_testcase is not documented
admin/tool/trigger/tests/fixtures/user_event_fixture.php
(#17) No one-line description found in phpdocs for file
admin/tool/trigger/tests/http_post_action_step_test.php
(#31) Class tool_trigger_http_post_action_step_testcase is not documented
(#53) Function tool_trigger_http_post_action_step_testcase::make_mock_http_handler is not documented
admin/tool/trigger/tests/json_export_test.php
(#37) Class tool_trigger_json_export_testcase is not documented
admin/tool/trigger/tests/learn_process_test.php
(#37) Class tool_trigger_learn_process_testcase is not documented
admin/tool/trigger/tests/logdump_action_step_test.php
(#30) Class tool_trigger_logdump_action_step_testcase is not documented
admin/tool/trigger/tests/numcompare_filter_step_test.php
(#32) Class tool_trigger_numcompare_filter_step_testcase is not documented
(#57) There is no description in phpdocs for function test_all_operators
admin/tool/trigger/tests/process_workflows_test.php
(#37) Class tool_trigger_process_workflow_testcase is not documented
admin/tool/trigger/tests/processor_helper_test.php
(#31) Class tool_trigger_processor_helper_testcase is not documented
admin/tool/trigger/tests/role_assign_action_step_test.php
(#30) Class role_assign_action_step_testcase is not documented
admin/tool/trigger/tests/steps_form_test.php
(#30) Class tool_trigger_steps_form_testcase is not documented
admin/tool/trigger/tests/stringcompare_filter_step_test.php
(#33) Class tool_trigger_stringcompare_filter_step_testcase is not documented
admin/tool/trigger/tests/tool_trigger_testcase.php
(#37) Class tool_trigger_testcase is not documented
(#42) Phpdocs for function tool_trigger_testcase::create_workflow has incomplete parameters list
admin/tool/trigger/tests/user_lookup_step_test.php
(#31) Class tool_trigger_user_lookup_testcase is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]