Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 1 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/trigger/classes/edit_form.php
(#90) This comment is 50% valid code; is this commented out code?

Javascript coding style problems

(0 errors, 41 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

admin/tool/trigger/amd/src/step_select.js
(#28) A space is required after ','. (comma-spacing)
(#30) Unexpected space before function parentheses. (space-before-function-paren)
(#42) Missing JSDoc @returns for function. (valid-jsdoc)
(#54) Missing JSDoc for parameter 'steps'. (valid-jsdoc)
(#75) Missing JSDoc comment. (require-jsdoc)
(#94) Each then() should return a value or throw (promise/always-return)
(#102) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#127) ["stepdesc"] is better written in dot notation. (dot-notation)
(#128) ["typedesc"] is better written in dot notation. (dot-notation)
(#134) ["stepclass"] is better written in dot notation. (dot-notation)
(#147) Expected space or tab after '//' in comment. (spaced-comment)
(#159) ["type"] is better written in dot notation. (dot-notation)
(#159) ["stepclass"] is better written in dot notation. (dot-notation)
(#163) Expected JSDoc for 'events' but found 'array'. (valid-jsdoc)
(#163) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#175) Extra space after key 'text'. (key-spacing)
(#179) Unexpected space before function parentheses. (space-before-function-paren)
(#182) Extra space after key 'text'. (key-spacing)
(#187) Missing JSDoc parameter type for 'string'. (valid-jsdoc)
(#187) Expected JSDoc for 'valfilter' but found 'string'. (valid-jsdoc)
(#195) There should be no space after '{'. (object-curly-spacing)
(#195) There should be no space before '}'. (object-curly-spacing)
(#225) Extra space after key 'steptype'. (key-spacing)
(#226) Extra space after key 'stepclass'. (key-spacing)
(#251) Missing JSDoc comment. (require-jsdoc)
(#251) Missing space before opening brace. (space-before-blocks)
(#252) Comments should not begin with a lowercase character (capitalized-comments)
(#271) Missing space before opening brace. (space-before-blocks)
(#275) Missing space before opening brace. (space-before-blocks)
(#279) Missing space before opening brace. (space-before-blocks)
(#281) Missing space before opening brace. (space-before-blocks)
(#285) Missing space before opening brace. (space-before-blocks)
(#298) Missing space before opening brace. (space-before-blocks)
(#324) There should be no space before ','. (comma-spacing)
(#357) ["type"] is better written in dot notation. (dot-notation)
(#358) ["stepclass"] is better written in dot notation. (dot-notation)
(#382) Missing space before opening brace. (space-before-blocks)
(#391) Missing JSDoc for parameter 'context'. (valid-jsdoc)
(#400) Expected space or tab after '//' in comment. (spaced-comment)
(#401) Expected catch,fail() or return (promise/catch-or-return)
(#401) Each then() should return a value or throw (promise/always-return)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(89 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

admin/tool/trigger/classes/edit_form.php
(#161) Phpdocs for function edit_form::validation has incomplete parameters list
admin/tool/trigger/classes/event_processor.php
(#44) Function event_processor::__construct is not documented
admin/tool/trigger/classes/helper/datafield_manager.php
(#17) File-level phpdocs block is not found
(#34) Function get_datafields is not documented
(#34) Package is not specified for function get_datafields. It is also not specified in file-level phpdocs
(#42) Package is not specified for function update_datafields. It is also not specified in file-level phpdocs
(#93) Package is not specified for function render_datafields. It is also not specified in file-level phpdocs
admin/tool/trigger/classes/output/manageworkflows/renderable.php
(#53) Phpdocs for function renderable::__construct has incomplete parameters list
admin/tool/trigger/classes/output/manageworkflows/renderer.php
(#69) Phpdocs for function renderer::render_add_button has incomplete parameters list
admin/tool/trigger/classes/steps/actions/email_action_step.php
(#90) There is no description in phpdocs for function execute
(#91) Phpdocs for function email_action_step::execute has incomplete parameters list
(#158) Phpdocs for function email_action_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/actions/http_post_action_step.php
(#44) Function http_post_action_step::init is not documented
(#40) Variable http_post_action_step::$url is not documented
(#41) Variable http_post_action_step::$headers is not documented
(#42) Variable http_post_action_step::$params is not documented
(#68) Variable http_post_action_step::$httphandler is not documented
(#97) There is no description in phpdocs for function execute
(#98) Phpdocs for function http_post_action_step::execute has incomplete parameters list
(#139) Phpdocs for function http_post_action_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/actions/logdump_action_step.php
(#17) File-level phpdocs block is not found
(#30) Function logdump_action_step::form_definition_extra is not documented
(#37) Function logdump_action_step::get_step_desc is not documented
(#41) Function logdump_action_step::get_step_name is not documented
(#45) Function logdump_action_step::execute is not documented
admin/tool/trigger/classes/steps/base/base_form.php
(#51) Phpdocs for function base_form::__construct has incomplete parameters list
admin/tool/trigger/classes/steps/base/base_step.php
(#40) Function base_step::__construct is not documented
(#38) Variable base_step::$data is not documented
(#97) There is no description in phpdocs for function execute
admin/tool/trigger/classes/steps/filters/fail_filter_step.php
(#40) Phpdocs for function fail_filter_step::execute has incomplete parameters list
(#64) Phpdocs for function fail_filter_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/filters/numcompare_filter_step.php
(#96) Function numcompare_filter_step::get_field_value is not documented
(#42) Constant numcompare_filter_step::OPERATOR_EQUAL is not documented
(#43) Constant numcompare_filter_step::OPERATOR_NOTEQUAL is not documented
(#44) Constant numcompare_filter_step::OPERATOR_LT is not documented
(#45) Constant numcompare_filter_step::OPERATOR_LTE is not documented
(#46) Constant numcompare_filter_step::OPERATOR_GTE is not documented
(#47) Constant numcompare_filter_step::OPERATOR_GT is not documented
(#61) Phpdocs for function numcompare_filter_step::execute has incomplete parameters list
(#142) Phpdocs for function numcompare_filter_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/lookups/course_lookup_step.php
(#17) File-level phpdocs block is not found
(#47) Function course_lookup_step::init is not documented
(#21) No one-line description found in phpdocs for class course_lookup_step
(#52) Phpdocs for function course_lookup_step::execute has incomplete parameters list
(#79) Phpdocs for function course_lookup_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/steps/lookups/user_lookup_step.php
(#17) File-level phpdocs block is not found
(#47) Function user_lookup_step::init is not documented
(#21) No one-line description found in phpdocs for class user_lookup_step
(#52) Phpdocs for function user_lookup_step::execute has incomplete parameters list
(#83) Phpdocs for function user_lookup_step::form_definition_extra has incomplete parameters list
admin/tool/trigger/classes/task/cleanup.php
(#29) Class cleanup does not have @copyright tag
(#29) Class cleanup does not have @license tag
admin/tool/trigger/classes/task/process_workflows.php
(#109) Function process_workflows::process_queue is not documented
(#159) Function process_workflows::process_item is not documented
(#78) Phpdocs for function process_workflows::create_trigger_queue has incomplete parameters list
(#28) Class process_workflows does not have @copyright tag
(#28) Class process_workflows does not have @license tag
admin/tool/trigger/classes/workflow.php
(#86) Phpdocs for function workflow::__construct has incomplete parameters list
(#110) Invalid phpdocs tag @returns used
(#120) Invalid phpdocs tag @returns used
admin/tool/trigger/classes/workflow_manager.php
(#144) Function workflow_manager::get_steps_with_names is not documented
(#160) Function workflow_manager::get_steps_by_type is not documented
(#244) Function workflow_manager::validate_step_class is not documented
(#242) Variable workflow_manager::$stepclasses is not documented
(#254) Phpdocs for function workflow_manager::validate_and_make_step has incomplete parameters list
admin/tool/trigger/classes/workflow_process.php
(#176) Function workflow_process::processform is not documented
(#70) Phpdocs for function workflow_process::to_form_defaults has incomplete parameters list
(#135) Phpdocs for function workflow_process::processjson has incomplete parameters list
admin/tool/trigger/db/messages.php
(#16) File-level phpdocs block does not have @copyright tag
admin/tool/trigger/db/tasks.php
(#20) Package tool_monitor is not valid
admin/tool/trigger/externallib.php
(#49) Phpdocs for function tool_trigger_external::step_by_type has incomplete parameters list
(#110) Phpdocs for function tool_trigger_external::validate_form has incomplete parameters list
admin/tool/trigger/lib.php
(#33) Phpdocs for function tool_trigger_output_fragment_new_base_form has incomplete parameters list
(#54) Phpdocs for function tool_trigger_output_fragment_new_step_form has incomplete parameters list
admin/tool/trigger/settings.php
(#21) Category admin is not valid
admin/tool/trigger/tests/course_lookup_step_test.php
(#30) Class tool_trigger_course_lookup_step_testcase is not documented
admin/tool/trigger/tests/datafield_manager_test.php
(#39) Class tool_trigger_datafield_manager_testcase is not documented
(#31) No one-line description found in phpdocs for class datafield_class
(#31) Class datafield_class does not have @copyright tag
(#31) Class datafield_class does not have @license tag
admin/tool/trigger/tests/email_action_step_test.php
(#31) Class tool_trigger_email_action_step_testcase is not documented
admin/tool/trigger/tests/fail_filter_step_test.php
(#30) Class tool_trigger_fail_filter_step_testcase is not documented
admin/tool/trigger/tests/fixtures/user_event_fixture.php
(#17) No one-line description found in phpdocs for file
admin/tool/trigger/tests/http_post_action_step_test.php
(#31) Class tool_trigger_http_post_action_step_testcase is not documented
(#53) Function tool_trigger_http_post_action_step_testcase::make_mock_http_handler is not documented
admin/tool/trigger/tests/logdump_action_step_test.php
(#30) Class tool_trigger_logdump_action_step_testcase is not documented
admin/tool/trigger/tests/numcompare_filter_step_test.php
(#32) Class tool_trigger_numcompare_filter_step_testcase is not documented
(#57) There is no description in phpdocs for function test_all_operators
admin/tool/trigger/tests/user_lookup_step_test.php
(#30) Class tool_trigger_user_lookup_testcase is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]