Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(41 errors, 42 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/token/classes/external/token_api.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#55) There must not be a space before the colon in a return type declaration
(#83) There must not be a space before the colon in a return type declaration
(#96) There must not be a space before the colon in a return type declaration
admin/tool/token/classes/fields_config.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#47) There should be a comma after the last array item in a multi-line array.
(#60) There must not be a space before the colon in a return type declaration
(#91) There must not be a space before the colon in a return type declaration
(#117) There must not be a space before the colon in a return type declaration
(#129) There must not be a space before the colon in a return type declaration
(#138) There must not be a space before the colon in a return type declaration
(#159) There must not be a space before the colon in a return type declaration
(#174) There must not be a space before the colon in a return type declaration
admin/tool/token/classes/incorrect_field_exception.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
admin/tool/token/classes/privacy/provider.php
(#34) There must not be a space before the colon in a return type declaration
admin/tool/token/classes/services_config.php
(#32) There must not be a space before the colon in a return type declaration
(#56) There must not be a space before the colon in a return type declaration
(#78) There must not be a space before the colon in a return type declaration
(#88) There must not be a space before the colon in a return type declaration
admin/tool/token/classes/token_generator.php
(#52) There must not be a space before the colon in a return type declaration
(#61) There must not be a space before the colon in a return type declaration
(#79) There must not be a space before the colon in a return type declaration
(#96) There should be a comma after the last array item in a multi-line array.
admin/tool/token/classes/user_extractor.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#52) There must not be a space before the colon in a return type declaration
admin/tool/token/db/services.php
(#45) There should be a comma after the last array item in a multi-line array.
admin/tool/token/lang/en/tool_token.php
(#30) The string key "privacy:metadata" is not in the correct order, it should be before "token:generatetoken"
(#31) The string key "error:morethanoneuser" is not in the correct order, it should be before "privacy:metadata"
(#33) The string key "error:incorrectfield" is not in the correct order, it should be before "error:servicenotavailable"
(#34) The string key "auth" is not in the correct order, it should be before "error:incorrectfield"
admin/tool/token/tests/external/token_api_test.php
(#35) Unit test token_api_test should be declared as final.
(#54) The setUp() method in unit tests must always call to parent::setUp().
(#67) There must not be a space before the colon in a return type declaration
(#93) There must not be a space before the colon in a return type declaration
(#133) Test method test_get_token_without_permissions() is missing a return type
(#163) Test method test_get_token_with_by_user_with_permissions() is missing a return type
(#225) Test method test_get_token_for_not_existing_user() is missing a return type
(#249) Test method test_get_token_for_by_not_enabled_field() is missing a return type
(#279) Test method test_get_token_for_incorrect_service() is missing a return type
(#322) Test method test_get_token_is_no_auth_method_enabled() is missing a return type
admin/tool/token/tests/fields_config_test.php
(#31) Unit test fields_config_test should be declared as final.
(#42) There must not be a space before the colon in a return type declaration
(#66) Test method test_constants() is missing a return type
(#81) Test method test_get_supported_fields_without_profile_fields() is missing a return type
(#96) Test method test_get_supported_fields_with_profile_fields() is missing a return type
(#120) There should be a comma after the last array item in a multi-line array.
(#132) Data provider method "get_enabled_fields_data_provider" will need to be converted to static in future.
(#132) There must not be a space before the colon in a return type declaration
(#136) There should be a comma after the last array item in a multi-line array.
(#148) Test method test_get_enabled_fields() is missing a return type
(#165) Test method test_is_custom_profile_field() is missing a return type
(#178) Test method test_is_field_enabled() is missing a return type
(#199) Data provider method "get_enabled_auth_data_provider" will need to be converted to static in future.
(#199) There must not be a space before the colon in a return type declaration
(#203) There should be a comma after the last array item in a multi-line array.
(#215) Test method test_get_enabled_auth_methods() is missing a return type
admin/tool/token/tests/services_config_test.php
(#30) Unit test services_config_test should be declared as final.
(#35) Test method test_get_supported_services() is missing a return type
(#95) Data provider method "get_enabled_services_data_provider" will need to be converted to static in future.
(#95) There must not be a space before the colon in a return type declaration
(#99) There should be a comma after the last array item in a multi-line array.
(#111) Test method test_get_enabled_services() is missing a return type
(#126) Test method test_is_service_enabled() is missing a return type
(#148) Test method test_get_service_by_shortname() is missing a return type
admin/tool/token/tests/token_generator_test.php
(#33) Unit test token_generator_test should be declared as final.
(#50) There must not be a space before the colon in a return type declaration
(#70) Test method test_generate_token_and_user_is_not_exist() is missing a return type
(#83) Test method test_generate_token_without_permissions() is missing a return type
(#99) Test method test_generate_token_for_disabled_service() is missing a return type
(#118) Test method test_generate_token_for_not_existing_service() is missing a return type
(#128) There should be a comma after the last array item in a multi-line array.
(#144) Test method test_generate_token() is missing a return type
(#178) Test method test_generate_token_with_valid_until_configured() is missing a return type
(#215) Test method test_generate_token_correctly_if_existing_token_has_null_validuntil_date() is missing a return type
admin/tool/token/tests/token_test.php
(#30) Unit test token_test should be declared as final.
(#35) Test method test_getters() is missing a return type
admin/tool/token/tests/user_extractor_test.php
(#31) Unit test user_extractor_test should be declared as final.
(#43) There should be a comma after the last array item in a multi-line array.
(#56) There must not be a space before the colon in a return type declaration
(#80) Test method test_get_user_throw_exception_on_not_enabled_field() is missing a return type
(#99) Test method test_get_user_throw_exception_if_found_more_than_one_user() is missing a return type
(#122) Test method test_get_user_by_user_field() is missing a return type
(#166) Test method test_get_user_by_custom_profile_field() is missing a return type

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]