Overview
(0 errors, 0 warnings)
This section shows the general problems detected when processing the code [More info]
PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(26 errors, 91 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- admin/tool/passwordvalidator/classes/form/test_password_form.php
- (#32) Missing docblock for class test_password_form
- (#34) Missing docblock for function definition
- (#47) Missing docblock for function validation
- (#58) Short array syntax must be used to define arrays
- (#63) Short array syntax must be used to define arrays
- admin/tool/passwordvalidator/classes/privacy/provider.php
- (#27) Missing docblock for class provider
- (#37) There must not be a space before the colon in a return type declaration
- admin/tool/passwordvalidator/lang/en/tool_passwordvalidator.php
- (#27) The string key "configpasswordpolicy" is not in the correct order, it should be before "pluginname"
- (#30) The string key "configpassworddigits" is not in the correct order, it should be before "configpasswordrotationempty"
- (#32) The string key "configpasswordminlength" is not in the correct order, it should be before "configpasswordspecialchars"
- (#33) The string key "configpasswordlowerletter" is not in the correct order, it should be before "configpasswordminlength"
- (#35) The string key "configpasswordgood" is not in the correct order, it should be before "configpasswordupperletter"
- (#37) The string key "passwordenabledesc" is not in the correct order, it should be before "passwordenablename"
- (#40) The string key "passwordbadconfigload" is not in the correct order, it should be before "passwordforcedconfigmanual"
- (#45) The string key "passwordexpiryinputdesc" is not in the correct order, it should be before "passwordexpiryinputname"
- (#47) The string key "passwordirapcomplexitydesc" is not in the correct order, it should be before "passwordirapcomplexityname"
- (#50) The string key "passwordirapcomplexitycomplex" is not in the correct order, it should be before "passwordirapcomplexitysimpledesc"
- (#53) The string key "passwordirapnumbersdesc" is not in the correct order, it should be before "passwordirapnumbersname"
- (#54) The string key "passworddictcheckname" is not in the correct order, it should be before "passwordirapnumbersdesc"
- (#55) The string key "passworddictcheckdesc" is not in the correct order, it should be before "passworddictcheckname"
- (#57) The string key "passworddictcheckfiledesc" is not in the correct order, it should be before "passworddictcheckfilename"
- (#59) The string key "passworddigitsdesc" is not in the correct order, it should be before "passworddigitsname"
- (#61) The string key "passworddigitsinputdesc" is not in the correct order, it should be before "passworddigitsinputname"
- (#62) The string key "passwordcharsname" is not in the correct order, it should be before "passworddigitsinputdesc"
- (#63) The string key "passwordcharsdesc" is not in the correct order, it should be before "passwordcharsname"
- (#65) The string key "passwordcharsinputdesc" is not in the correct order, it should be before "passwordcharsinputname"
- (#67) The string key "passwordpersonalinfodesc" is not in the correct order, it should be before "passwordpersonalinfoname"
- (#69) The string key "passwordphrasedesc" is not in the correct order, it should be before "passwordphrasename"
- (#71) The string key "passwordphraseinputdesc" is not in the correct order, it should be before "passwordphraseinputname"
- (#72) The string key "passwordlockoutname" is not in the correct order, it should be before "passwordphraseinputdesc"
- (#73) The string key "passwordlockoutdesc" is not in the correct order, it should be before "passwordlockoutname"
- (#75) The string key "passwordlockoutinputdesc" is not in the correct order, it should be before "passwordlockoutinputname"
- (#76) The string key "passwordblacklistname" is not in the correct order, it should be before "passwordlockoutinputdesc"
- (#77) The string key "passwordblacklistdesc" is not in the correct order, it should be before "passwordblacklistname"
- (#79) The string key "passwordpolicyNIST_ISM_2019" is not in the correct order, it should be before "passwordpolicynotemplate"
- (#80) The string key "passwordpolicyNIST2018" is not in the correct order, it should be before "passwordpolicyNIST_ISM_2019"
- (#81) The string key "passwordpolicyISM0519" is not in the correct order, it should be before "passwordpolicyNIST2018"
- (#87) The string key "passwordtesterdesc" is not in the correct order, it should be before "passwordtestername"
- (#89) The string key "passwordtesterfail" is not in the correct order, it should be before "passwordtesterpass"
- (#90) The string key "passwordtesterempty" is not in the correct order, it should be before "passwordtesterfail"
- (#94) The string key "responsedictionaryfailoneword" is not in the correct order, it should be before "responsenoletters"
- (#98) The string key "responseblacklistphrase" is not in the correct order, it should be before "responserepeatedcharacters"
- (#101) The string key "responsebreachedpassword" is not in the correct order, it should be before "responselockoutperiod"
- (#103) The string key "responseapierror" is not in the correct order, it should be before "responsenouser"
- (#105) The string key "templateNIST2018" is not in the correct order, it should be before "templateNIST_ISM_2019"
- (#106) The string key "templateISM0519" is not in the correct order, it should be before "templateNIST2018"
- (#108) The string key "testpasswordpage" is not in the correct order, it should be before "testpasswordpagestring"
- (#111) The string key "testpasswordpagetestbutton" is not in the correct order, it should be before "testpasswordpageusernamebox"
- (#112) The string key "testpasswordconfigchecker" is not in the correct order, it should be before "testpasswordpagetestbutton"
- (#114) The string key "testpasswordvalidationpassed" is not in the correct order, it should be before "testpasswordvalidationtester"
- (#115) The string key "privacy:metadata" is not in the correct order, it should be before "testpasswordvalidationpassed"
- admin/tool/passwordvalidator/lib.php
- (#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#36) Missing docblock for function tool_passwordvalidator_check_password_policy
- admin/tool/passwordvalidator/locallib.php
- (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#210) Missing docblock for function tool_passwordvalidator_personal_information
- (#213) Short array syntax must be used to define arrays
- (#332) Short array syntax must be used to define arrays
- (#441) Short array syntax must be used to define arrays
- (#441) Short array syntax must be used to define arrays
- (#510) Short array syntax must be used to define arrays
- admin/tool/passwordvalidator/test_password.php
- (#1) Missing @copyright tag
- (#1) Missing @license tag
- (#1) Missing docblock for file test_password.php
- admin/tool/passwordvalidator/tests/locallib_test.php
- (#28) Unit test tool_passwordvalidator_locallib_test should be declared as final.
- (#28) PHPUnit testcase name "tool_passwordvalidator_locallib_test" does not match file name "locallib_test"
- (#28) PHPUnit class "tool_passwordvalidator_locallib_test" does not have any namespace. It is recommended to add it to the "tool_passwordvalidator" namespace, using more levels if needed, in order to match the code being tested
- (#28) Missing docblock for class tool_passwordvalidator_locallib_test
- (#30) Missing docblock for function complexity_length_provider in testcase
- (#30) Data provider method "complexity_length_provider" must return an array, a Generator or an Iterable.
- (#48) There should be a comma after the last array item in a multi-line array.
- (#55) Test method test_complexity_length() is missing any coverage information, own or at class level
- (#55) No one-line description found in phpdocs for docblock of function test_complexity_length
- (#55) Test method test_complexity_length() is missing a return type
- (#60) Missing docblock for function complexity_chars_provider in testcase
- (#60) Data provider method "complexity_chars_provider" must return an array, a Generator or an Iterable.
- (#72) There should be a comma after the last array item in a multi-line array.
- (#79) Test method test_complexity_chars() is missing any coverage information, own or at class level
- (#79) No one-line description found in phpdocs for docblock of function test_complexity_chars
- (#79) Test method test_complexity_chars() is missing a return type
- (#84) Missing docblock for function dictionary_checking_provider in testcase
- (#84) Data provider method "dictionary_checking_provider" must return an array, a Generator or an Iterable.
- (#103) There should be a comma after the last array item in a multi-line array.
- (#110) Test method test_dictionary_checking() is missing any coverage information, own or at class level
- (#110) No one-line description found in phpdocs for docblock of function test_dictionary_checking
- (#110) Test method test_dictionary_checking() is missing a return type
- (#119) Test method test_personal_information() is missing any coverage information, own or at class level
- (#119) Test method test_personal_information() is missing a return type
- (#121) Short array syntax must be used to define arrays
- (#145) Short array syntax must be used to define arrays
- (#184) Short array syntax must be used to define arrays
- (#201) Missing docblock for function sequential_digits_provider in testcase
- (#201) Data provider method "sequential_digits_provider" must return an array, a Generator or an Iterable.
- (#212) There should be a comma after the last array item in a multi-line array.
- (#219) Test method test_sequential_digits() is missing any coverage information, own or at class level
- (#219) No one-line description found in phpdocs for docblock of function test_sequential_digits
- (#219) Test method test_sequential_digits() is missing a return type
- (#228) Missing docblock for function repeated_chars_provider in testcase
- (#228) Data provider method "repeated_chars_provider" must return an array, a Generator or an Iterable.
- (#237) There should be a comma after the last array item in a multi-line array.
- (#244) Test method test_repeated_chars() is missing any coverage information, own or at class level
- (#244) No one-line description found in phpdocs for docblock of function test_repeated_chars
- (#244) Test method test_repeated_chars() is missing a return type
- (#253) Test method test_phrase_blacklisting() is missing any coverage information, own or at class level
- (#253) Test method test_phrase_blacklisting() is missing a return type
- (#275) Test method test_lockout_period() is missing any coverage information, own or at class level
- (#275) Test method test_lockout_period() is missing a return type
- (#287) Short array syntax must be used to define arrays
- (#314) Test method test_password_blacklist() is missing any coverage information, own or at class level
- (#314) Test method test_password_blacklist() is missing a return type
- (#333) Test method test_password_validate() is missing any coverage information, own or at class level
- (#333) Test method test_password_validate() is missing a return type
- (#347) Short array syntax must be used to define arrays
- (#355) Test method test_password_change_api() is missing any coverage information, own or at class level
- (#355) Test method test_password_change_api() is missing a return type
- (#370) Short array syntax must be used to define arrays
- (#390) Test method test_password_expiry() is missing any coverage information, own or at class level
- (#390) Test method test_password_expiry() is missing a return type
Javascript coding style problems
(0 errors, 0 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
CSS problems
(0 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
PHPDocs style problems
(5 errors, 0 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- admin/tool/passwordvalidator/tests/locallib_test.php
- (#52) Phpdocs for function tool_passwordvalidator_locallib_test::test_complexity_length has incomplete parameters list
- (#76) Phpdocs for function tool_passwordvalidator_locallib_test::test_complexity_chars has incomplete parameters list
- (#107) Phpdocs for function tool_passwordvalidator_locallib_test::test_dictionary_checking has incomplete parameters list
- (#216) Phpdocs for function tool_passwordvalidator_locallib_test::test_sequential_digits has incomplete parameters list
- (#241) Phpdocs for function tool_passwordvalidator_locallib_test::test_repeated_chars has incomplete parameters list
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
grunt changes
(0 errors, 0 warnings)
This section shows files built by grunt and not commited [More info]
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 0 warnings)
This section shows problems detected in mustache templates [More info]
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]