Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(159 errors, 50 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/opensesame/autoconfigaicc.php
(#29) Expected at least 1 space before "."; 0 found
(#29) Expected at least 1 space after "."; 0 found
admin/tool/opensesame/classes/api/opensesame.php
(#38) Opening brace must not be followed by a blank line
(#73) Multi-line function declaration not indented correctly; expected 8 spaces but found 12
(#73) Multi-line function declarations must define one parameter per line
(#73) Multi-line function declarations must define one parameter per line
(#73) Multi-line function declarations must define one parameter per line
(#73) Multi-line function declarations must define one parameter per line
(#73) Multi-line function declarations must define one parameter per line
(#73) Multi-line function declarations must define one parameter per line
(#73) The closing parenthesis of a multi-line function declaration must be on a new line
(#271) Space found before comma in argument list
(#271) Expected no space between ""/v1/content"" and the comma. Found: 1 space
(#301) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#301) Only one argument is allowed per line in a multi-line function call
(#301) Only one argument is allowed per line in a multi-line function call
(#301) Only one argument is allowed per line in a multi-line function call
(#301) Only one argument is allowed per line in a multi-line function call
(#301) Only one argument is allowed per line in a multi-line function call
(#301) Only one argument is allowed per line in a multi-line function call
(#301) Only one argument is allowed per line in a multi-line function call
(#301) Closing parenthesis of a multi-line function call must be on a line by itself
admin/tool/opensesame/classes/local/data/base.php
(#45) Opening brace must not be followed by a blank line
admin/tool/opensesame/classes/local/data/opensesame_course.php
(#92) Short array syntax must be used to define arrays
admin/tool/opensesame/classes/local/migration_handler.php
(#38) Opening brace must not be followed by a blank line
(#91) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#92) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#148) Blank line found at end of control structure
admin/tool/opensesame/classes/local/opensesame_handler.php
(#54) Opening brace must not be followed by a blank line
(#108) Multi-line function declarations must define one parameter per line
(#108) Multi-line function declarations must define one parameter per line
(#108) Multi-line function declarations must define one parameter per line
(#108) Multi-line function declarations must define one parameter per line
(#128) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $api.
(#187) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#187) Closing parenthesis of a multi-line function call must be on a line by itself
(#199) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $api.
(#274) Expected 1 space between the comma and "// ID of the context.". Found: 4 spaces
(#275) Expected 1 space between the comma and "// Your component name.". Found: 8 spaces
(#277) Expected 1 space between the comma and "// Usually = ID of row in table.". Found: 15 spaces
(#278) Expected 1 space between the comma and "// Any path beginning and ending in /.". Found: 13 spaces
(#279) Expected 1 space between the comma and "// Any filename.". Found: 3 spaces
(#366) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $draftitemid.
(#366) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $launchurl.
(#393) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#393) Only one argument is allowed per line in a multi-line function call
(#393) Only one argument is allowed per line in a multi-line function call
(#393) Only one argument is allowed per line in a multi-line function call
(#393) Only one argument is allowed per line in a multi-line function call
(#393) Only one argument is allowed per line in a multi-line function call
(#393) Only one argument is allowed per line in a multi-line function call
(#393) Only one argument is allowed per line in a multi-line function call
(#393) Only one argument is allowed per line in a multi-line function call
(#393) Closing parenthesis of a multi-line function call must be on a line by itself
(#409) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#409) Only one argument is allowed per line in a multi-line function call
(#409) Only one argument is allowed per line in a multi-line function call
(#409) Only one argument is allowed per line in a multi-line function call
(#409) Only one argument is allowed per line in a multi-line function call
(#409) Only one argument is allowed per line in a multi-line function call
(#409) Closing parenthesis of a multi-line function call must be on a line by itself
(#430) The first parameter of a multi-line function declaration must be on the line after the opening bracket
(#430) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $launchurl.
(#430) Declaring an optional parameter with a non-nullable type and a null default value before a required parameter is deprecated since PHP 8.4 Parameter $launchurl is optional, while parameter $courseid is required. The $launchurl parameter is implicitly treated as a required parameter.
(#430) Multi-line function declarations must define one parameter per line
(#430) Multi-line function declarations must define one parameter per line
(#430) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $draftitemid.
(#430) Declaring an optional parameter with a non-nullable type and a null default value before a required parameter is deprecated since PHP 8.4 Parameter $draftitemid is optional, while parameter $mod is required. The $draftitemid parameter is implicitly treated as a required parameter.
(#430) Multi-line function declarations must define one parameter per line
(#430) Multi-line function declarations must define one parameter per line
(#430) Line exceeds 132 characters; contains 138 characters
(#431) Multi-line function declaration not indented correctly; expected 8 spaces but found 41
(#431) Multi-line function declarations must define one parameter per line
(#431) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $updt.
(#431) Multi-line function declarations must define one parameter per line
(#431) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $instance.
(#431) Multi-line function declarations must define one parameter per line
(#431) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $cm.
(#596) The closing brace for the class must go on the next line after the body
admin/tool/opensesame/classes/task/process_course_task.php
(#28) Opening brace must not be followed by a blank line
(#83) Blank line found at end of control structure
(#110) Blank line found at end of control structure
(#157) Blank line found at end of control structure
admin/tool/opensesame/classes/task/retrieve_courses_task.php
(#32) Opening brace must not be followed by a blank line
admin/tool/opensesame/db/upgrade.php
(#37) Blank line found at start of control structure
(#71) Blank line found at start of control structure
(#92) Blank line found at start of control structure
(#106) Blank line found at start of control structure
admin/tool/opensesame/lang/en/tool_opensesame.php
(#34) The string key "autoconfigureconfirmation" is not in the correct order, it should be before "autoconfiguredesc"
(#35) The string key "autoconfigsuccess" is not in the correct order, it should be before "autoconfigureconfirmation"
(#36) The string key "apiauthtoken" is not in the correct order, it should be before "autoconfigsuccess"
(#39) The string key "apitokenempty" is not in the correct order, it should be before "apiurlempty"
(#53) The string key "onlyaiccurl" is not in the correct order, it should be before "onlylocal"
(#55) The string key "opensesamecat" is not in the correct order, it should be before "opensesamesync"
(#60) The string key "clientid_missing" is not in the correct order, it should be before "statuscode400"
(#62) The string key "authurl_missing" is not in the correct order, it should be before "clientsecret_missing"
(#67) The string key "optableth:category" is not in the correct order, it should be before "optableth:title"
(#69) The string key "optableth:course" is not in the correct order, it should be before "optableth:status"
(#70) The string key "optableth:actions" is not in the correct order, it should be before "optableth:course"
(#71) The string key "opsecoursestatuspage" is not in the correct order, it should be before "optableth:actions"
(#72) The string key "opcategory" is not in the correct order, it should be before "opsecoursestatuspage"
(#74) The string key "apicall_pagesize" is not in the correct order, it should be before "opcategory_desc"
(#80) The string key "adhocblocked" is not in the correct order, it should be before "resumeadhoc"
(#82) The string key "queued" is not in the correct order, it should be before "retrieved"
(#83) The string key "created" is not in the correct order, it should be before "queued"
(#86) The string key "archived" is not in the correct order, it should be before "scormimported"
(#88) The string key "queued_info" is not in the correct order, it should be before "retrieved_info"
(#89) The string key "created_info" is not in the correct order, it should be before "queued_info"
(#92) The string key "resynccourses" is not in the correct order, it should be before "scormimported_info"
(#94) The string key "resyncallqueued" is not in the correct order, it should be before "resyncqueued"
(#95) The string key "archived_info" is not in the correct order, it should be before "resyncallqueued"
(#107) The string key "namesupdated" is not in the correct order, it should be before "updatenames"
(#108) The string key "guid" is not in the correct order, it should be before "namesupdated"
(#109) The string key "coursename" is not in the correct order, it should be before "guid"
(#110) The string key "courseid" is not in the correct order, it should be before "coursename"
(#112) The string key "activity_name" is not in the correct order, it should be before "prefix"
admin/tool/opensesame/opsesame_courses_status.php
(#83) Blank line found at start of control structure
(#109) Space found before comma in argument list
(#109) Expected no space between "$messageid" and the comma. Found: 1 space
admin/tool/opensesame/settings.php
(#32) Blank line found at start of control structure
(#35) Opening parenthesis of a multi-line function call must be the last content on the line
(#36) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#42) Opening parenthesis of a multi-line function call must be the last content on the line
(#42) Only one argument is allowed per line in a multi-line function call
(#43) Multi-line function call not indented correctly; expected 4 spaces but found 12
(#43) Only one argument is allowed per line in a multi-line function call
(#43) Only one argument is allowed per line in a multi-line function call
(#43) Closing parenthesis of a multi-line function call must be on a line by itself
(#44) Opening parenthesis of a multi-line function call must be the last content on the line
(#45) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#46) Multi-line function call not indented correctly; expected 4 spaces but found 12
(#46) Only one argument is allowed per line in a multi-line function call
(#46) Closing parenthesis of a multi-line function call must be on a line by itself
(#47) Opening parenthesis of a multi-line function call must be the last content on the line
(#47) Only one argument is allowed per line in a multi-line function call
(#48) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#48) Only one argument is allowed per line in a multi-line function call
(#49) Multi-line function call not indented correctly; expected 4 spaces but found 12
(#49) Closing parenthesis of a multi-line function call must be on a line by itself
(#50) Opening parenthesis of a multi-line function call must be the last content on the line
(#50) Only one argument is allowed per line in a multi-line function call
(#51) Multi-line function call not indented correctly; expected 4 spaces but found 12
(#51) Only one argument is allowed per line in a multi-line function call
(#51) Only one argument is allowed per line in a multi-line function call
(#51) Closing parenthesis of a multi-line function call must be on a line by itself
(#53) Opening parenthesis of a multi-line function call must be the last content on the line
(#54) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#55) Multi-line function call not indented correctly; expected 4 spaces but found 12
(#55) Only one argument is allowed per line in a multi-line function call
(#55) Closing parenthesis of a multi-line function call must be on a line by itself
(#73) Opening parenthesis of a multi-line function call must be the last content on the line
(#75) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#75) Only one argument is allowed per line in a multi-line function call
(#75) Only one argument is allowed per line in a multi-line function call
(#75) Closing parenthesis of a multi-line function call must be on a line by itself
(#77) Opening parenthesis of a multi-line function call must be the last content on the line
(#78) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#79) Multi-line function call not indented correctly; expected 4 spaces but found 12
(#79) Only one argument is allowed per line in a multi-line function call
(#79) Only one argument is allowed per line in a multi-line function call
(#79) Closing parenthesis of a multi-line function call must be on a line by itself
(#81) Opening parenthesis of a multi-line function call must be the last content on the line
(#83) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#83) Only one argument is allowed per line in a multi-line function call
(#83) Only one argument is allowed per line in a multi-line function call
(#83) Closing parenthesis of a multi-line function call must be on a line by itself
(#96) Opening parenthesis of a multi-line function call must be the last content on the line
(#97) Multi-line function call not indented correctly; expected 12 spaces but found 8
(#98) Only one argument is allowed per line in a multi-line function call
(#98) Only one argument is allowed per line in a multi-line function call
(#98) Closing parenthesis of a multi-line function call must be on a line by itself
(#101) Opening parenthesis of a multi-line function call must be the last content on the line
(#101) Only one argument is allowed per line in a multi-line function call
(#102) Multi-line function call not indented correctly; expected 4 spaces but found 12
(#102) Closing parenthesis of a multi-line function call must be on a line by itself
(#105) Opening parenthesis of a multi-line function call must be the last content on the line
(#106) Multi-line function call not indented correctly; expected 8 spaces but found 4
(#107) Closing parenthesis of a multi-line function call must be on a line by itself
(#111) Blank line found at end of control structure
admin/tool/opensesame/tests/course_generation_test.php
(#51) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#53) Expected at least 1 space before "."; 0 found
(#53) Expected at least 1 space after "."; 0 found
(#63) Unit test course_generation_test should be declared as final.
(#63) Opening brace must not be followed by a blank line
(#85) Test method test_process_single_os_course() is missing any coverage information, own or at class level
(#85) Test method test_process_single_os_course() is missing a return type
(#211) Test method test_get_state() is missing any coverage information, own or at class level
(#211) The first parameter of a multi-line function declaration must be on the line after the opening bracket
(#211) Multi-line function declarations must define one parameter per line
(#211) Multi-line function declarations must define one parameter per line
(#211) Multi-line function declarations must define one parameter per line
(#211) Multi-line function declarations must define one parameter per line
(#212) Multi-line function declaration not indented correctly; expected 8 spaces but found 12
(#212) The closing parenthesis of a multi-line function declaration must be on a new line
(#222) There should be a comma after the last array item in a multi-line array.
(#223) There should be a comma after the last array item in a multi-line array.
admin/tool/opensesame/tests/course_queing_test.php
(#54) Unit test course_queing_test should be declared as final.
(#54) Opening brace must not be followed by a blank line
(#75) Test method test_retrieve_and_process_queue_courses() is missing any coverage information, own or at class level
(#75) Test method test_retrieve_and_process_queue_courses() is missing a return type
(#117) Expected at least 1 space before "."; 0 found
(#117) Expected at least 1 space after "."; 0 found
(#117) Expected at least 1 space before "."; 0 found
(#117) Expected at least 1 space after "."; 0 found
admin/tool/opensesame/tests/generator/lib.php
(#25) Opening brace must not be followed by a blank line
admin/tool/opensesame/tests/queries_test.php
(#52) Unit test queries_test should be declared as final.
(#52) Opening brace must not be followed by a blank line
(#67) Test method test_queries_funtions() is missing any coverage information, own or at class level
(#67) Test method test_queries_funtions() is missing a return type

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

admin/tool/opensesame/templates/opensesame_courses_table.mustache
(#1) HTML Validation info, line 10: The “button” role is unnecessary for element “button”. (sesame+)) <button role="button" data-toggle="popover" data-trigger="hover" data-placement="bottom" title="((+statusinfo%2C+tool_opensesame+))" data-html=true data-content="((+statusinfo_body%2C+tool_opensesame+))" style="border: none; background: none;"><i cla)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]