Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(51 errors, 71 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

public/admin/tool/mergeusers/cli/listuserfields.php
(#31) The constant "E_STRICT" is deprecated since PHP 8.4
public/admin/tool/mergeusers/tests/after_merged_all_tables_test.php
(#40) Test method test_custom_callback_for_after_merged_all_tables_hook_is_invoked() is missing any coverage information, own or at class level
(#40) No one-line description found in phpdocs for docblock of function test_custom_callback_for_after_merged_all_tables_hook_is_invoked
(#63) Test method test_custom_callback_for_after_merged_all_tables_hook_records_an_error_message() is missing any coverage information, own or at class level
(#63) No one-line description found in phpdocs for docblock of function test_custom_callback_for_after_merged_all_tables_hook_records_an_error_message
public/admin/tool/mergeusers/tests/assign_submission_duplicated_test.php
(#1) No one-line description found in phpdocs for docblock of file assign_submission_duplicated_test.php
(#17) Missing @license tag
(#28) PHPUnit class "assign_submission_duplicated_test" does not have any namespace. It is recommended to add it to the "tool_mergeusers" namespace, using more levels if needed, in order to match the code being tested
(#28) Missing docblock for class assign_submission_duplicated_test
(#37) Test method test_remove_old_ignore_new() is missing any coverage information, own or at class level
(#44) Missing docblock for function remove_old_ignore_new_data_provider in testcase
(#44) Data provider method "remove_old_ignore_new_data_provider" must return an array, a Generator or an Iterable.
(#81) Test method test_update_old_and_remove_new() is missing any coverage information, own or at class level
(#81) Line exceeds 132 characters; contains 136 characters
(#88) Missing docblock for function update_old_and_remove_new_data_provider in testcase
(#88) Data provider method "update_old_and_remove_new_data_provider" must return an array, a Generator or an Iterable.
(#118) Test method test_update_first_and_remove_last() is missing any coverage information, own or at class level
(#130) Missing docblock for function update_first_and_remove_last_data_provider in testcase
(#130) Data provider method "update_first_and_remove_last_data_provider" must return an array, a Generator or an Iterable.
(#154) Missing docblock for function get_assign_submission_submitted in testcase
(#162) Missing docblock for function get_assign_submission_submitted_by_date in testcase
(#171) Missing docblock for function get_assign_submission_new in testcase
(#179) Missing docblock for function get_assign_submission_draft_by_date in testcase
(#186) Missing docblock for function get_assign_submission_draft in testcase
(#194) Missing docblock for function get_assign_submission_reopened in testcase
(#202) Missing docblock for function get_assign_submission in testcase
(#221) No one-line description found in phpdocs for docblock of function get_duplicated_data
public/admin/tool/mergeusers/tests/assign_test.php
(#17) Missing @copyright tag
(#35) PHPUnit class "assign_test" does not have any namespace. It is recommended to add it to the "tool_mergeusers" namespace, using more levels if needed, in order to match the code being tested
(#51) Test method test_merge_non_conflicting_assign_grades() is missing any coverage information, own or at class level
(#125) Test method test_failed_merged_for_missing_course_module() is missing any coverage information, own or at class level
(#125) Test method test_failed_merged_for_missing_course_module() is missing a return type
(#185) Test method test_failed_merged_for_missing_module_record() is missing any coverage information, own or at class level
(#185) Test method test_failed_merged_for_missing_module_record() is missing a return type
public/admin/tool/mergeusers/tests/clioptions_test.php
(#20) Missing @copyright tag
(#28) PHPUnit class "clioptions_test" does not have any namespace. It is recommended to add it to the "tool_mergeusers" namespace, using more levels if needed, in order to match the code being tested
(#47) Test method test_option_alwaysrollback_is_set() is missing any coverage information, own or at class level
(#81) Test method test_option_debugdb_is_set() is missing any coverage information, own or at class level
public/admin/tool/mergeusers/tests/config_test.php
(#69) No one-line description found in phpdocs for docblock of function test_config_is_initialized_with_default_and_custom_settings
(#80) No one-line description found in phpdocs for docblock of function test_config_is_initialized_with_default_and_hook_settings
(#91) No one-line description found in phpdocs for docblock of function test_config_is_initialized_with_default_hook_and_custom_settings
public/admin/tool/mergeusers/tests/db_config_test.php
(#35) Test method test_config_is_initialized_empty() is missing any coverage information, own or at class level
(#35) No one-line description found in phpdocs for docblock of function test_config_is_initialized_empty
(#44) Test method test_config_is_initialized_with_valid_settings() is missing any coverage information, own or at class level
(#44) No one-line description found in phpdocs for docblock of function test_config_is_initialized_with_valid_settings
(#54) Test method test_config_is_initialized_with_invalid_settings_and_not_considered() is missing any coverage information, own or at class level
(#54) No one-line description found in phpdocs for docblock of function test_config_is_initialized_with_invalid_settings_and_not_considered
(#64) Test method test_config_merges_content_and_first_settings_are_kept() is missing any coverage information, own or at class level
(#64) No one-line description found in phpdocs for docblock of function test_config_merges_content_and_first_settings_are_kept
(#74) Test method test_config_merges_content_and_first_array_settings_are_kept() is missing any coverage information, own or at class level
(#74) No one-line description found in phpdocs for docblock of function test_config_merges_content_and_first_array_settings_are_kept
(#115) Test method test_config_merge_with_other_config_and_first_settings_are_kept() is missing any coverage information, own or at class level
(#115) No one-line description found in phpdocs for docblock of function test_config_merge_with_other_config_and_first_settings_are_kept
(#125) Test method test_config_settings_are_not_settable() is missing any coverage information, own or at class level
(#125) No one-line description found in phpdocs for docblock of function test_config_settings_are_not_settable
public/admin/tool/mergeusers/tests/enrolments_test.php
(#22) Missing @copyright tag
(#45) Test method test_merge_enrolments() is missing any coverage information, own or at class level
public/admin/tool/mergeusers/tests/fixtures/add_empty_settings_before_merging_callbacks.php
(#38) Opening brace must not be followed by a blank line
public/admin/tool/mergeusers/tests/fixtures/add_empty_settings_before_merging_hooks.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
public/admin/tool/mergeusers/tests/fixtures/add_settings_before_merging_hooks.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
public/admin/tool/mergeusers/tests/fixtures/after_merged_all_tables_hooks.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
public/admin/tool/mergeusers/tests/fixtures/after_merged_all_tables_hooks_with_error.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
public/admin/tool/mergeusers/tests/generic_table_merger_test.php
(#35) Missing docblock for constant generic_table_merger_test::USER_TO_KEEP
(#36) Missing docblock for constant generic_table_merger_test::USER_TO_REMOVE
(#37) Missing docblock for constant generic_table_merger_test::TABLE_NAME_FOR_TESTING
(#39) Missing member variable doc comment
(#40) Missing member variable doc comment
(#79) Test method test_merge_without_conflicting_records() is missing any coverage information, own or at class level
(#79) No one-line description found in phpdocs for docblock of function test_merge_without_conflicting_records
(#125) Missing docblock for function without_conflicting_records_provider in testcase
(#154) Test method test_merge_with_conflicting_records() is missing any coverage information, own or at class level
(#154) No one-line description found in phpdocs for docblock of function test_merge_with_conflicting_records
(#193) Missing docblock for function with_conflicting_records_provider in testcase
public/admin/tool/mergeusers/tests/grade_grades_table_merger_test.php
(#17) PHPUnit class "tool_mergeusers\local\merger\grade_grades_table_merger_test", with namespace "tool_mergeusers\local\merger", currently located at "tests/" directory, does not match its expected location at "tests/local/merger"
(#39) The setUp() method in unit tests must always call to parent::setUp().
(#66) No one-line description found in phpdocs for docblock of function test_keep_data_from_proper_user
(#112) Missing docblock for function grade_grades_table_merger_provider in testcase
(#122) Missing docblock for function create_grade_with_finalgrade in testcase
public/admin/tool/mergeusers/tests/jsonizer_test.php
(#47) Test method test_to_json() is missing any coverage information, own or at class level
(#76) Test method test_from_json() is missing any coverage information, own or at class level
public/admin/tool/mergeusers/tests/last_merge_test.php
(#39) Test method test_empty_list_of_deletable_users() is missing any coverage information, own or at class level
(#51) Test method test_a_user_can_be_deletable() is missing any coverage information, own or at class level
public/admin/tool/mergeusers/tests/lib_test.php
(#38) Test method test_mergeuser_myprofile_navigation() is missing any coverage information, own or at class level
public/admin/tool/mergeusers/tests/quiz_test.php
(#28) Missing @copyright tag
(#223) Test method test_merge_conflicting_quiz_attempts() is missing any coverage information, own or at class level
(#252) Test method test_merge_non_conflicting_quiz_attempts() is missing any coverage information, own or at class level
public/admin/tool/mergeusers/tests/reaggregate_course_completion_test.php
(#52) Test method test_reaggregate_field_is_updated() is missing any coverage information, own or at class level
(#121) Functions must not contain multiple empty lines in a row; found 2 empty lines
public/admin/tool/mergeusers/tests/renderer_test.php
(#1) Missing docblock for file renderer_test.php
(#31) Expected MOODLE_INTERNAL check or config.php inclusion. Multiple artifacts detected.
(#48) Test method test_get_merge_detail_missing_user() is missing any coverage information, own or at class level
(#71) Test method test_get_merge_detail_existing_user() is missing any coverage information, own or at class level
(#94) Missing docblock for class in_memory_last_merge
(#94) Each class must be in a file by itself
(#95) Missing member variable doc comment
(#96) Missing member variable doc comment
(#97) Missing member variable doc comment
(#98) Missing member variable doc comment
(#99) Missing docblock for function __construct in testcase
(#106) Missing docblock for function fromme in testcase
(#110) Missing docblock for function tome in testcase
(#114) Missing docblock for function is_this_user_deletable in testcase
public/admin/tool/mergeusers/tests/search_users_test.php
(#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#48) Test method test_search_for_user_field_excluding_deleted_users() is missing any coverage information, own or at class level
public/admin/tool/mergeusers/tests/selected_users_to_merge_test.php
(#37) Test method test_initialization_creates_session_attribute() is missing any coverage information, own or at class level
(#37) No one-line description found in phpdocs for docblock of function test_initialization_creates_session_attribute
(#53) Test method test_single_users_are_set_and_unset() is missing any coverage information, own or at class level
(#53) No one-line description found in phpdocs for docblock of function test_single_users_are_set_and_unset
(#78) Test method test_selected_users_are_cleared() is missing any coverage information, own or at class level
(#78) No one-line description found in phpdocs for docblock of function test_selected_users_are_cleared
public/admin/tool/mergeusers/tests/settable_db_config_test.php
(#35) Test method test_config_is_initialized_empty() is missing any coverage information, own or at class level
(#35) No one-line description found in phpdocs for docblock of function test_config_is_initialized_empty
(#44) Test method test_config_is_initialized_with_valid_settings() is missing any coverage information, own or at class level
(#44) No one-line description found in phpdocs for docblock of function test_config_is_initialized_with_valid_settings
(#56) Test method test_config_override_specific_setting() is missing any coverage information, own or at class level
(#56) No one-line description found in phpdocs for docblock of function test_config_override_specific_setting
(#69) Missing docblock for function override_setting_provider in testcase
public/admin/tool/mergeusers/tests/user_merger_test.php
(#47) Test method test_merge_existing_users_with_success() is missing any coverage information, own or at class level
(#77) Test method test_failed_merge_with_one_deleted_user() is missing any coverage information, own or at class level
(#77) Test method test_failed_merge_with_one_deleted_user() is missing a return type
(#128) Test method test_failed_merge_with_two_deleted_users() is missing any coverage information, own or at class level
(#128) Test method test_failed_merge_with_two_deleted_users() is missing a return type

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(1 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

public/admin/tool/mergeusers/styles.css
(#39) Expected single space before "{" (block-opening-brace-space-before)

PHPDocs style problems

(24 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

public/admin/tool/mergeusers/classes/event/user_merged.php
(#61) Phpdocs for function user_merged::get_description_as has incomplete parameters list
public/admin/tool/mergeusers/classes/local/cli/gathering_merger.php
(#54) Phpdocs for function gathering_merger::__construct has incomplete parameters list
public/admin/tool/mergeusers/classes/local/merger/duplicateddata/duplicated_data_merger.php
(#40) Phpdocs for function duplicated_data_merger::merge has incomplete parameters list
public/admin/tool/mergeusers/classes/local/merger/generic_table_merger.php
(#196) Phpdocs for function generic_table_merger::find_ids_to_update_and_remove has incomplete parameters list
(#238) Phpdocs for function generic_table_merger::process_duplicated_records_for_compound_index has incomplete parameters list
(#454) Phpdocs for function generic_table_merger::get_records_to_be_updated has incomplete parameters list
public/admin/tool/mergeusers/classes/local/merger/grade_grades_table_merger.php
(#62) Phpdocs for function grade_grades_table_merger::process_duplicated_records_for_compound_index has incomplete parameters list
public/admin/tool/mergeusers/classes/local/settings/json_setting.php
(#65) Phpdocs for function json_setting::validate has incomplete parameters list
(#84) Phpdocs for function json_setting::write_setting has incomplete parameters list
public/admin/tool/mergeusers/classes/output/renderer.php
(#161) Phpdocs for function renderer::render_user_review_table has incomplete parameters list
(#409) Phpdocs for function renderer::get_merge_detail_data has incomplete parameters list
public/admin/tool/mergeusers/tests/after_merged_all_tables_test.php
(#78) Phpdocs for function after_merged_all_tables_test::prepare_hook_settings has incomplete parameters list
public/admin/tool/mergeusers/tests/assign_submission_duplicated_test.php
(#29) Phpdocs for function assign_submission_duplicated_test::test_remove_old_ignore_new has incomplete parameters list
(#73) Phpdocs for function assign_submission_duplicated_test::test_update_old_and_remove_new has incomplete parameters list
(#111) Phpdocs for function assign_submission_duplicated_test::test_update_first_and_remove_last has incomplete parameters list
(#217) Phpdocs for function assign_submission_duplicated_test::get_duplicated_data has incomplete parameters list
public/admin/tool/mergeusers/tests/assign_test.php
(#106) Phpdocs for function assign_test::get_user_assign_grade has incomplete parameters list
public/admin/tool/mergeusers/tests/generic_table_merger_test.php
(#71) Phpdocs for function generic_table_merger_test::test_merge_without_conflicting_records has incomplete parameters list
(#147) Phpdocs for function generic_table_merger_test::test_merge_with_conflicting_records has incomplete parameters list
public/admin/tool/mergeusers/tests/grade_grades_table_merger_test.php
(#60) Phpdocs for function grade_grades_table_merger_test::test_keep_data_from_proper_user has incomplete parameters list
public/admin/tool/mergeusers/tests/jsonizer_test.php
(#40) Phpdocs for function jsonizer_test::test_to_json has incomplete parameters list
(#69) Phpdocs for function jsonizer_test::test_from_json has incomplete parameters list
public/admin/tool/mergeusers/tests/search_users_test.php
(#38) Phpdocs for function search_users_test::test_search_for_user_field_excluding_deleted_users has incomplete parameters list
public/admin/tool/mergeusers/tests/settable_db_config_test.php
(#51) Phpdocs for function settable_db_config_test::test_config_override_specific_setting has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]