Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(83 errors, 52 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/legacyfilesmigration/batchmigrate.php
(#39) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
(#95) Short array syntax must be used to define arrays
admin/tool/legacyfilesmigration/classes/privacy/provider.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#41) File must end with a newline character
admin/tool/legacyfilesmigration/cli/generate_clis.php
(#2) Line 1 of the opening comment must start "// This file is part of".
(#2) Line 2 of the opening comment must start "//".
(#2) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#2) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#2) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#2) Line 6 of the opening comment must start "// (at your option) any later version.".
(#2) Line 7 of the opening comment must start "//".
(#2) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#2) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#3) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#4) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#4) Line 12 of the opening comment must start "//".
(#4) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#4) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#8) Short array syntax must be used to define arrays
(#13) There should be a comma after the last array item in a multi-line array.
(#15) Short array syntax must be used to define arrays
(#20) There should be a comma after the last array item in a multi-line array.
(#35) Expected "if (...) {\n"; found "if(...){\n"
(#39) Expected "foreach (...) {\n"; found "foreach(...){\n"
(#40) Expected 1 space before "?"; 0 found
(#40) Expected 1 space before ":"; 0 found
(#40) Expected 1 space after ":"; 0 found
(#40) Expected 1 space before "?"; 0 found
(#40) Expected 1 space after "?"; 0 found
(#40) Expected 1 space before ":"; 0 found
(#40) Expected 1 space after ":"; 0 found
(#40) Line exceeds maximum limit of 180 characters; contains 226 characters
(#41) Expected "if (...) {\n"; found "if(...){\n"
(#42) Line exceeds 132 characters; contains 175 characters
admin/tool/legacyfilesmigration/cli/migrate_legacyfiles.php
(#2) Line 1 of the opening comment must start "// This file is part of".
(#2) Line 2 of the opening comment must start "//".
(#2) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#2) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#2) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#2) Line 6 of the opening comment must start "// (at your option) any later version.".
(#2) Line 7 of the opening comment must start "//".
(#2) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#2) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#3) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#4) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#4) Line 12 of the opening comment must start "//".
(#4) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#4) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#8) Inline comments must start with a capital letter, digit or 3-dots sequence
(#8) Inline comments must end in full-stops, exclamation marks, or question marks
(#9) Short array syntax must be used to define arrays
(#15) Short array syntax must be used to define arrays
(#19) There should be a comma after the last array item in a multi-line array.
(#31) Short array syntax must be used to define arrays
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#32) Expected "if (...) {\n"; found "if(...){\n"
(#38) Expected "if (...) {\n"; found "if(...){\n"
(#39) Short array syntax must be used to define arrays
(#39) Expected 1 space before "=>"; 0 found
(#39) Expected 1 space after "=>"; 0 found
(#40) Expected "if (...) {\n"; found "if(...){\n"
(#52) Expected "if (...) {\n"; found "if(...){\n"
(#55) Expected "} else {\n"; found "}else{\n"
(#56) Expected 1 space before "?"; 0 found
(#56) Expected 1 space after "?"; 0 found
(#56) Commas (,) must be followed by white space.
(#56) Expected 1 space before ":"; 0 found
(#56) Expected 1 space after ":"; 0 found
(#58) File must end with a newline character
admin/tool/legacyfilesmigration/lang/en/tool_legacyfilesmigration.php
(#64) Inline comments must start with a capital letter, digit or 3-dots sequence
(#64) Inline comments must end in full-stops, exclamation marks, or question marks
(#64) No space found before comment text; expected "// cli traductions" but found "//cli traductions"
(#75) Expected 1 space before "="; 0 found
(#75) Expected 1 space after "="; 0 found
(#76) Expected 1 space before "="; 0 found
(#76) Expected 1 space after "="; 0 found
(#77) Expected 1 space before "="; 0 found
(#77) Expected 1 space after "="; 0 found
(#78) Expected 1 space before "="; 0 found
(#78) Expected 1 space after "="; 0 found
(#89) Expected 1 space before "="; 0 found
(#89) Expected 1 space after "="; 0 found
(#91) File must end with a newline character
admin/tool/legacyfilesmigration/listnotmigrated.php
(#34) Short array syntax must be used to define arrays
(#45) Short array syntax must be used to define arrays
(#57) File must end with a newline character
admin/tool/legacyfilesmigration/locallib.php
(#36) Short array syntax must be used to define arrays
(#66) Short array syntax must be used to define arrays
(#67) There should be a comma after the last array item in a multi-line array.
(#76) Short array syntax must be used to define arrays
(#77) There should be a comma after the last array item in a multi-line array.
(#119) Short array syntax must be used to define arrays
(#128) Expected 1 space before opening brace; found 0
(#140) Short array syntax must be used to define arrays
(#156) Short array syntax must be used to define arrays
(#157) Short array syntax must be used to define arrays
(#165) Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $copycoursefiles is optional, while parameter $ownerusername is required.
(#168) Short array syntax must be used to define arrays
(#175) Short array syntax must be used to define arrays
(#193) Short array syntax must be used to define arrays
(#198) Logical operator "or" is prohibited; use "||" instead
(#200) Short array syntax must be used to define arrays
(#201) Short array syntax must be used to define arrays
(#222) Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $user is optional, while parameter $log is required.
(#228) Spaces must be used to indent lines; tabs are not allowed
(#228) Tab found within whitespace
(#228) This comment is 65% valid code; is this commented out code?
(#228) Line indented incorrectly; expected at least 8 spaces, found 1
(#236) Inline comments must end in full-stops, exclamation marks, or question marks
(#248) Spaces must be used to indent lines; tabs are not allowed
(#248) Tab found within whitespace
(#248) Line indented incorrectly; expected at least 16 spaces, found 2
(#289) Short array syntax must be used to define arrays
(#290) There should be a comma after the last array item in a multi-line array.
(#297) Short array syntax must be used to define arrays
(#298) There should be a comma after the last array item in a multi-line array.
(#340) Inline comments must end in full-stops, exclamation marks, or question marks
admin/tool/legacyfilesmigration/migrateablecoursesbatchform.php
(#47) Short array syntax must be used to define arrays
(#48) Short array syntax must be used to define arrays
(#49) Short array syntax must be used to define arrays
admin/tool/legacyfilesmigration/migrateablecoursestable.php
(#65) Short array syntax must be used to define arrays
(#74) Short array syntax must be used to define arrays
(#76) Short array syntax must be used to define arrays
(#77) Short array syntax must be used to define arrays
(#124) Short array syntax must be used to define arrays
admin/tool/legacyfilesmigration/paginationform.php
(#44) Short array syntax must be used to define arrays
admin/tool/legacyfilesmigration/renderer.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#77) Short array syntax must be used to define arrays
(#120) Short array syntax must be used to define arrays
(#126) Short array syntax must be used to define arrays
(#168) Short array syntax must be used to define arrays
(#186) Short array syntax must be used to define arrays
(#239) Short array syntax must be used to define arrays

Javascript coding style problems

(50 errors, 33 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

admin/tool/legacyfilesmigration/module.js
(#1) Identifier 'tool_legacyfilesmigration' is not in camel case. (camelcase)
(#2) Identifier 'init_migrate_table' is not in camel case. (camelcase)
(#5) 'checkboxes' is not defined. (no-undef)
(#6) 'checkboxes' is not defined. (no-undef)
(#8) 'rowelement' is not defined. (no-undef)
(#10) 'rowelement' is not defined. (no-undef)
(#12) 'rowelement' is not defined. (no-undef)
(#16) 'rowelement' is not defined. (no-undef)
(#18) 'rowelement' is not defined. (no-undef)
(#20) 'rowelement' is not defined. (no-undef)
(#28) 'checkboxes' is not defined. (no-undef)
(#29) 'checkboxes' is not defined. (no-undef)
(#30) 'rowelement' is not defined. (no-undef)
(#32) 'rowelement' is not defined. (no-undef)
(#35) 'checkboxes' is not defined. (no-undef)
(#36) 'checkboxes' is not defined. (no-undef)
(#37) 'rowelement' is not defined. (no-undef)
(#39) 'rowelement' is not defined. (no-undef)
(#46) 'checkboxes' is not defined. (no-undef)
(#47) 'checkboxes' is not defined. (no-undef)
(#48) 'rowelement' is not defined. (no-undef)
(#52) 'checkboxes' is not defined. (no-undef)
(#53) 'checkboxes' is not defined. (no-undef)
(#54) 'rowelement' is not defined. (no-undef)
(#59) Identifier 'preselect_owner' is not in camel case. (camelcase)
(#60) Identifier 'preselect_owner' is not in camel case. (camelcase)
(#60) Missing space before opening brace. (space-before-blocks)
(#61) Expected space(s) after "if". (keyword-spacing)
(#61) Missing space before opening brace. (space-before-blocks)
(#62) Unexpected alert. (no-alert)
(#62) 'M.str' is restricted from being used. Use AMD module "core/str" or M.util.get_string() (no-restricted-properties)
(#69) Missing space before opening brace. (space-before-blocks)
(#73) Expected space(s) after "if". (keyword-spacing)
(#73) Missing space before opening brace. (space-before-blocks)
(#74) 'vartextfield' is not defined. (no-undef)
(#75) Expected space(s) after "if". (keyword-spacing)
(#75) 'vartextfield' is not defined. (no-undef)
(#75) Missing space before opening brace. (space-before-blocks)
(#76) 'vartextfield' is not defined. (no-undef)
(#76) A space is required after ','. (comma-spacing)
(#79) Expected space(s) before "else". (keyword-spacing)
(#79) Expected space(s) after "if". (keyword-spacing)
(#79) Missing space before opening brace. (space-before-blocks)
(#80) Missing semicolon. (semi)
(#86) 'checkboxes' is not defined. (no-undef)
(#87) 'oinputs' is not defined. (no-undef)
(#91) 'checkboxes' is not defined. (no-undef)
(#97) 'copycoursefilesentry' is not defined. (no-undef)
(#98) Expected space(s) after "if". (keyword-spacing)
(#98) 'copycoursefilesentry' is not defined. (no-undef)
(#98) 'copycoursefilesentry' is not defined. (no-undef)
(#98) Missing space before opening brace. (space-before-blocks)
(#99) Expected space(s) after "if". (keyword-spacing)
(#99) 'copycoursefilesentry' is not defined. (no-undef)
(#99) Missing space before opening brace. (space-before-blocks)
(#104) 'owners' is not defined. (no-undef)
(#105) Expected space(s) after "if". (keyword-spacing)
(#105) 'owners' is not defined. (no-undef)
(#105) 'owners' is not defined. (no-undef)
(#105) Missing space before opening brace. (space-before-blocks)
(#107) 'owners' is not defined. (no-undef)
(#108) Expected space(s) before "else". (keyword-spacing)
(#108) Expected space(s) after "else". (keyword-spacing)
(#110) 'owners' is not defined. (no-undef)
(#112) Expected space(s) after "if". (keyword-spacing)
(#112) Unexpected space after unary operator '-'. (space-unary-ops)
(#112) Missing space before opening brace. (space-before-blocks)
(#113) This line has a length of 147. Maximum allowed is 132. (max-len)
(#113) 'selectownerassociatedusername' is not defined. (no-undef)
(#114) 'selectownerassociatedusername' is not defined. (no-undef)
(#115) Expected space(s) before "else". (keyword-spacing)
(#115) Expected space(s) after "else". (keyword-spacing)
(#123) 'operation' is not defined. (no-undef)
(#124) 'coursesinput' is not defined. (no-undef)
(#125) 'coursesinput' is not defined. (no-undef)
(#126) 'copycoursefilesinput' is not defined. (no-undef)
(#127) 'copycoursefilesinput' is not defined. (no-undef)
(#128) 'ownersinput' is not defined. (no-undef)
(#129) 'ownersinput' is not defined. (no-undef)
(#131) Unexpected alert. (no-alert)
(#131) 'M.str' is restricted from being used. Use AMD module "core/str" or M.util.get_string() (no-restricted-properties)
(#137) 'e' is defined but never used. (no-unused-vars)
(#143) Missing semicolon. (semi)

CSS problems

(35 errors, 1 warnings)

This section shows CSS problems detected by stylelint [More info]

admin/tool/legacyfilesmigration/styles.css
(#1) Expected newline before "}" (block-closing-brace-newline-before)
(#2) Expected newline before "}" (block-closing-brace-newline-before)
(#4) Expected newline before "}" (block-closing-brace-newline-before)
(#5) Expected newline before "}" (block-closing-brace-newline-before)
(#7) Expected newline before "}" (block-closing-brace-newline-before)
(#8) Expected newline before "}" (block-closing-brace-newline-before)
(#9) Expected newline before "}" (block-closing-brace-newline-before)
(#11) Expected newline before "}" (block-closing-brace-newline-before)
(#9) Expected single space before "}" of a single-line block (block-closing-brace-space-before)
(#11) Expected single space before "}" of a single-line block (block-closing-brace-space-before)
(#1) Expected newline after "{" (block-opening-brace-newline-after)
(#2) Expected newline after "{" (block-opening-brace-newline-after)
(#4) Expected newline after "{" (block-opening-brace-newline-after)
(#5) Expected newline after "{" (block-opening-brace-newline-after)
(#7) Expected newline after "{" (block-opening-brace-newline-after)
(#8) Expected newline after "{" (block-opening-brace-newline-after)
(#9) Expected newline after "{" (block-opening-brace-newline-after)
(#11) Expected newline after "{" (block-opening-brace-newline-after)
(#9) Expected single space after "{" of a single-line block (block-opening-brace-space-after)
(#11) Expected single space after "{" of a single-line block (block-opening-brace-space-after)
(#8) Expected single space before "{" (block-opening-brace-space-before)
(#11) Expected single space before "{" (block-opening-brace-space-before)
(#4) Expected "#ffeecc" to be "#fec" (color-hex-length)
(#11) Expected single space after ";" in a single-line declaration block (declaration-block-semicolon-space-after)
(#11) Expected single space after ";" in a single-line declaration block (declaration-block-semicolon-space-after)
(#11) Expected single space after ";" in a single-line declaration block (declaration-block-semicolon-space-after)
(#11) Expected single space after ";" in a single-line declaration block (declaration-block-semicolon-space-after)
(#11) Expected single space after ";" in a single-line declaration block (declaration-block-semicolon-space-after)
(#11) Expected no more than 1 declaration (declaration-block-single-line-max-declarations)
(#9) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#11) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#11) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#11) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#11) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#11) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#11) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)

PHPDocs style problems

(21 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

admin/tool/legacyfilesmigration/batchmigrate.php
(#20) Package tool_legacyfilesmigration * @package is not valid
(#20) Invalid inline phpdocs tag @package found
admin/tool/legacyfilesmigration/classes/privacy/provider.php
(#19) Package local_zz_last_actions is not valid
admin/tool/legacyfilesmigration/cli/generate_clis.php
(#2) File-level phpdocs block is not found
admin/tool/legacyfilesmigration/cli/migrate_legacyfiles.php
(#2) File-level phpdocs block is not found
admin/tool/legacyfilesmigration/lang/en/tool_legacyfilesmigration.php
(#20) Package is not valid
admin/tool/legacyfilesmigration/listnotmigrated.php
(#20) Package is not valid
admin/tool/legacyfilesmigration/locallib.php
(#128) Class tool_legacyfilesmigration_tools is not documented
(#221) Class legacyfiles_migrate_manager is not documented
(#196) Function tool_legacyfilesmigration_tools::string_format_by_object is not documented
(#222) Function legacyfiles_migrate_manager::migrate_files is not documented
(#162) Phpdocs for function tool_legacyfilesmigration_tools::tool_legacyfilesmigration_migrate_course has incomplete parameters list
admin/tool/legacyfilesmigration/migrateablecoursesbatchform.php
(#17) File-level phpdocs block does not have @license tag
admin/tool/legacyfilesmigration/migrateablecoursestable.php
(#33) Package tool_assignmentupgrade is not valid
(#17) File-level phpdocs block does not have @license tag
admin/tool/legacyfilesmigration/paginationform.php
(#17) No one-line description found in phpdocs for file
admin/tool/legacyfilesmigration/renderer.php
(#29) Class tool_legacyfilesmigration_renderer is not documented
(#91) Phpdocs for function tool_legacyfilesmigration_renderer::render_tool_legacyfilesmigration_batchoperationconfirm has incomplete parameters list
(#110) Phpdocs for function tool_legacyfilesmigration_renderer::course_list_page has incomplete parameters list
admin/tool/legacyfilesmigration/settings.php
(#20) Package is not valid
admin/tool/legacyfilesmigration/version.php
(#21) Package tool is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]