Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(2 errors, 127 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/excimer/classes/profile_helper.php
(#82) Short array syntax must be used to define arrays
(#133) Short array syntax must be used to define arrays
admin/tool/excimer/classes/recent_profile_table.php
(#39) There should be a comma after the last array item in a multi-line array.
admin/tool/excimer/db/upgrade.php
(#413) Short array syntax must be used to define arrays
admin/tool/excimer/lang/en/tool_excimer.php
(#29) The string key "adminname" is not in the correct order, it should be before "reportname"
(#31) Unexpected comment found. Auto-fixing will not work after this comment
(#35) The string key "report_slowest_other" is not in the correct order, it should be before "report_slowest_web"
(#36) The string key "report_session_locks" is not in the correct order, it should be before "report_slowest_other"
(#37) The string key "report_recent" is not in the correct order, it should be before "report_session_locks"
(#39) The string key "report_page_groups" is not in the correct order, it should be before "report_unfinished"
(#42) Unexpected comment found. Auto-fixing will not work after this comment
(#43) The string key "checkslowest" is not in the correct order, it should be before "report_page_slow_course"
(#45) The string key "checkslowest:action" is not in the correct order, it should be before "checkslowest:none"
(#47) The string key "checkslowest:details" is not in the correct order, it should be before "checkslowest:summary"
(#49) Unexpected comment found. Auto-fixing will not work after this comment
(#51) The string key "general_settings" is not in the correct order, it should be before "here"
(#53) The string key "auto_settings" is not in the correct order, it should be before "general_settings_desc"
(#71) The string key "num_slowest_by_page" is not in the correct order, it should be before "request_ms_desc"
(#73) The string key "noexcimerprofiler" is not in the correct order, it should be before "num_slowest_by_page_desc"
(#74) The string key "long_interval_s" is not in the correct order, it should be before "noexcimerprofiler"
(#79) The string key "samplelimit" is not in the correct order, it should be before "task_min_duration_desc"
(#86) The string key "expiry_fuzzy_counts" is not in the correct order, it should be before "stacklimit_desc"
(#94) Unexpected comment found. Auto-fixing will not work after this comment
(#99) Unexpected comment found. Auto-fixing will not work after this comment
(#100) The string key "slowest_grouped" is not in the correct order, it should be before "task_purge_page_groups"
(#101) The string key "recent" is not in the correct order, it should be before "slowest_grouped"
(#104) The string key "tab_slowest_other" is not in the correct order, it should be before "tab_slowest_web"
(#105) The string key "tab_session_locks" is not in the correct order, it should be before "tab_slowest_other"
(#107) The string key "tab_page_groups" is not in the correct order, it should be before "unfinished"
(#108) The string key "tab_page_course" is not in the correct order, it should be before "tab_page_groups"
(#109) The string key "tab_import" is not in the correct order, it should be before "tab_page_course"
(#111) Unexpected comment found. Auto-fixing will not work after this comment
(#112) The string key "displaying_month" is not in the correct order, it should be before "tab_import"
(#114) The string key "previous_month" is not in the correct order, it should be before "to_current_month"
(#115) The string key "next_month" is not in the correct order, it should be before "previous_month"
(#117) Unexpected comment found. Auto-fixing will not work after this comment
(#118) The string key "field_id" is not in the correct order, it should be before "next_month"
(#120) The string key "field_scripttype" is not in the correct order, it should be before "field_type"
(#121) The string key "field_contenttype" is not in the correct order, it should be before "field_scripttype"
(#127) The string key "field_created" is not in the correct order, it should be before "field_scriptgroup"
(#130) The string key "field_duration" is not in the correct order, it should be before "field_userid"
(#132) The string key "field_pathinfo" is not in the correct order, it should be before "field_request"
(#133) The string key "field_explanation" is not in the correct order, it should be before "field_pathinfo"
(#137) The string key "field_referer" is not in the correct order, it should be before "field_sessionid"
(#138) The string key "field_cookies" is not in the correct order, it should be before "field_referer"
(#139) The string key "field_buffering" is not in the correct order, it should be before "field_cookies"
(#142) The string key "field_dbreadwrites" is not in the correct order, it should be before "field_numsamples_value"
(#144) The string key "field_datasize" is not in the correct order, it should be before "field_dbreplicareads"
(#146) The string key "field_maxcreated" is not in the correct order, it should be before "field_memoryusagemax"
(#148) The string key "field_maxduration" is not in the correct order, it should be before "field_mincreated"
(#150) The string key "field_maxlockheld" is not in the correct order, it should be before "field_minduration"
(#153) The string key "field_pid" is not in the correct order, it should be before "field_requestcount"
(#154) The string key "field_hostname" is not in the correct order, it should be before "field_pid"
(#157) The string key "field_usermodified" is not in the correct order, it should be before "field_versionhash"
(#158) The string key "field_timecreated" is not in the correct order, it should be before "field_usermodified"
(#160) The string key "field_lockreason" is not in the correct order, it should be before "field_timemodified"
(#161) The string key "field_courseid" is not in the correct order, it should be before "field_lockreason"
(#167) Unexpected comment found. Auto-fixing will not work after this comment
(#169) The string key "field_month" is not in the correct order, it should be before "field_name"
(#170) The string key "field_fuzzycount" is not in the correct order, it should be before "field_month"
(#174) Unexpected comment found. Auto-fixing will not work after this comment
(#175) The string key "field_actions" is not in the correct order, it should be before "field_fuzzydurationsum"
(#177) Unexpected comment found. Auto-fixing will not work after this comment
(#180) Unexpected comment found. Auto-fixing will not work after this comment
(#181) The string key "scripttype_web" is not in the correct order, it should be before "term_profile"
(#182) The string key "scripttype_cli" is not in the correct order, it should be before "scripttype_web"
(#183) The string key "scripttype_ajax" is not in the correct order, it should be before "scripttype_cli"
(#185) The string key "scripttype_task" is not in the correct order, it should be before "scripttype_ws"
(#187) Unexpected comment found. Auto-fixing will not work after this comment
(#188) The string key "reason_flameme" is not in the correct order, it should be before "scripttype_task"
(#189) The string key "reason_auto" is not in the correct order, it should be before "reason_flameme"
(#191) The string key "reason_flameall" is not in the correct order, it should be before "reason_slow"
(#193) The string key "reason_import" is not in the correct order, it should be before "reason_stack"
(#195) Unexpected comment found. Auto-fixing will not work after this comment
(#196) The string key "lock_profile" is not in the correct order, it should be before "reason_import"
(#205) Unexpected comment found. Auto-fixing will not work after this comment
(#209) Unexpected comment found. Auto-fixing will not work after this comment
(#210) The string key "privacy:metadata:tool_excimer_profiles" is not in the correct order, it should be before "strftime_monyear"
(#212) Unexpected comment found. Auto-fixing will not work after this comment
(#213) The string key "approx_count_algorithm" is not in the correct order, it should be before "privacy:metadata:tool_excimer_profiles"
(#216) Unexpected comment found. Auto-fixing will not work after this comment
(#218) The string key "histogram_history" is not in the correct order, it should be before "months_to_display"
(#220) Unexpected comment found. Auto-fixing will not work after this comment
(#221) The string key "export_profile" is not in the correct order, it should be before "histogram_history"
(#224) The string key "import_error" is not in the correct order, it should be before "import_success"
(#228) Unexpected comment found. Auto-fixing will not work after this comment
(#229) The string key "cachedef_request_metadata" is not in the correct order, it should be before "profile_file"
(#230) The string key "cachedef_page_group_metadata" is not in the correct order, it should be before "cachedef_request_metadata"
(#234) The string key "allprofilesdeleted" is not in the correct order, it should be before "deleteprofilewarning"
(#236) The string key "deleteprofiles_script_warning" is not in the correct order, it should be before "profiledeleted"
(#237) The string key "deleteprofiles_script" is not in the correct order, it should be before "deleteprofiles_script_warning"
(#238) The string key "deleteprofiles_course" is not in the correct order, it should be before "deleteprofiles_script"
(#241) The string key "didnotfinish" is not in the correct order, it should be before "profilesdeleted"
(#242) The string key "deleteprofiles_filter_warning" is not in the correct order, it should be before "didnotfinish"
(#243) The string key "deleteprofiles_filter" is not in the correct order, it should be before "deleteprofiles_filter_warning"
(#246) The string key "duration" is not in the correct order, it should be before "samples"
(#248) The string key "deletedcourse" is not in the correct order, it should be before "no_month_in_page_group_table"
(#250) The string key "link" is not in the correct order, it should be before "unknown"
admin/tool/excimer/tests/tool_excimer_cron_processor_test.php
(#31) Unit test tool_excimer_cron_processor_test should be declared as final.
(#46) Test method test_findtaskname() is missing a return type
(#66) Test method test_on_interval() is missing a return type
admin/tool/excimer/tests/tool_excimer_flamed3_node_test.php
(#33) Unit test tool_excimer_flamed3_node_test should be declared as final.
admin/tool/excimer/tests/tool_excimer_helper_test.php
(#28) Unit test tool_excimer_helper_test should be declared as final.
(#32) Test method test_course_display_name() is missing a return type
(#47) Test method test_course_display_link() is missing a return type
admin/tool/excimer/tests/tool_excimer_manager_test.php
(#27) Unit test tool_excimer_manager_test should be declared as final.
(#81) Test method test_approximate_increment() is missing a return type
admin/tool/excimer/tests/tool_excimer_mockery_test.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#32) Unit test tool_excimer_mockery_test should be declared as final.
admin/tool/excimer/tests/tool_excimer_profile_helper_test.php
(#28) Unit test tool_excimer_profile_helper_test should be declared as final.
(#404) Test method test_minimal_db_reads_writes_for_warm_cache() is missing a return type
admin/tool/excimer/tests/tool_excimer_profile_test.php
(#28) Unit test tool_excimer_profile_test should be declared as final.
(#172) Test method test_partial_save() is missing a return type
(#258) Test method test_save_course() is missing a return type
admin/tool/excimer/tests/tool_excimer_purge_page_group_test.php
(#29) Unit test tool_excimer_purge_page_group_test should be declared as final.
(#44) Test method test_purge() is missing a return type
admin/tool/excimer/tests/tool_excimer_sample_set_test.php
(#32) Unit test tool_excimer_sample_set_test should be declared as final.
(#39) Test method test_add_sample() is missing a return type
(#59) Test method test_filtering() is missing a return type
(#101) Test method test_stripping() is missing a return type
(#134) Test method test_automatic_doubling_when_adding_samples() is missing a return type
(#183) Test method test_event_count() is missing a return type
admin/tool/excimer/tests/tool_excimer_script_metadata_test.php
(#27) Unit test tool_excimer_script_metadata_test should be declared as final.
(#46) Test method test_strip_parameters() is missing a return type
(#91) Test method test_get_parameters() is missing a return type
(#143) Test method test_get_groupby_value() is missing a return type
(#177) Test method test_get_sample_limit() is missing a return type
(#206) Test method test_get_normalised_relative_script_path() is missing a return type
(#251) Test method test_get_redactable_param_names() is missing a return type

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(56 errors, 3 warnings)

This section shows CSS problems detected by stylelint [More info]

admin/tool/excimer/css/d3-flamegraph.css
(#2) Expected "#EEEEEE" to be "#eeeeee" (color-hex-case)
(#2) Expected "#EEEEEE" to be "#EEE" (color-hex-length)
(#29) Unexpected !important (declaration-no-important)
(#2) Expected indentation of 4 spaces (indentation)
(#3) Expected indentation of 4 spaces (indentation)
(#7) Expected indentation of 4 spaces (indentation)
(#8) Expected indentation of 4 spaces (indentation)
(#9) Expected indentation of 4 spaces (indentation)
(#13) Expected indentation of 4 spaces (indentation)
(#14) Expected indentation of 4 spaces (indentation)
(#15) Expected indentation of 4 spaces (indentation)
(#16) Expected indentation of 4 spaces (indentation)
(#17) Expected indentation of 4 spaces (indentation)
(#18) Expected indentation of 4 spaces (indentation)
(#19) Expected indentation of 4 spaces (indentation)
(#20) Expected indentation of 4 spaces (indentation)
(#21) Expected indentation of 4 spaces (indentation)
(#22) Expected indentation of 4 spaces (indentation)
(#23) Expected indentation of 4 spaces (indentation)
(#24) Expected indentation of 4 spaces (indentation)
(#25) Expected indentation of 4 spaces (indentation)
(#29) Expected indentation of 4 spaces (indentation)
(#33) Expected indentation of 4 spaces (indentation)
(#34) Expected indentation of 4 spaces (indentation)
(#38) Expected indentation of 4 spaces (indentation)
(#39) Expected indentation of 4 spaces (indentation)
(#40) Expected indentation of 4 spaces (indentation)
(#41) Expected indentation of 4 spaces (indentation)
(#42) Expected indentation of 4 spaces (indentation)
(#43) Expected indentation of 4 spaces (indentation)
(#44) Expected indentation of 4 spaces (indentation)
(#45) Expected indentation of 4 spaces (indentation)
(#50) Expected indentation of 4 spaces (indentation)
(#51) Expected indentation of 4 spaces (indentation)
(#52) Expected indentation of 4 spaces (indentation)
(#53) Expected indentation of 4 spaces (indentation)
(#54) Expected indentation of 4 spaces (indentation)
(#55) Expected indentation of 4 spaces (indentation)
(#56) Expected indentation of 4 spaces (indentation)
(#57) Expected indentation of 4 spaces (indentation)
(#62) Expected indentation of 4 spaces (indentation)
(#63) Expected indentation of 4 spaces (indentation)
(#64) Expected indentation of 4 spaces (indentation)
(#65) Expected indentation of 4 spaces (indentation)
(#66) Expected indentation of 4 spaces (indentation)
(#71) Expected indentation of 4 spaces (indentation)
(#72) Expected indentation of 4 spaces (indentation)
(#73) Expected indentation of 4 spaces (indentation)
(#74) Expected indentation of 4 spaces (indentation)
(#79) Expected indentation of 4 spaces (indentation)
(#80) Expected indentation of 4 spaces (indentation)
(#81) Expected indentation of 4 spaces (indentation)
(#82) Expected indentation of 4 spaces (indentation)
(#83) Expected indentation of 4 spaces (indentation)
(#88) Expected indentation of 4 spaces (indentation)
(#89) Expected indentation of 4 spaces (indentation)
(#90) Expected indentation of 4 spaces (indentation)
(#91) Expected indentation of 4 spaces (indentation)
admin/tool/excimer/css/memory-usage-graph.css
(#16) Unexpected unit (length-zero-no-unit)

PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]