Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(3 errors, 19 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/dataprivacy/categories.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
admin/tool/dataprivacy/classes/api.php
(#338) Must use "self::" for local static member reference
(#737) Line exceeds 132 characters; contains 150 characters
admin/tool/dataprivacy/classes/external/contextlevel_exporter.php
(#35) Duplicate class name "tool_dataprivacy\external\category_exporter" found; first defined in /var/lib/jenkins/git_repositories/prechecker/admin/tool/dataprivacy/classes/external/category_exporter.php on line 35
admin/tool/dataprivacy/classes/form/defaults.php
(#51) Line exceeds 132 characters; contains 134 characters
admin/tool/dataprivacy/classes/form/purpose.php
(#65) Line exceeds 132 characters; contains 148 characters
admin/tool/dataprivacy/classes/privacy/provider.php
(#32) Expected MOODLE_INTERNAL check or config.php inclusion
(#44) Expected 1 space after closing parenthesis; found 0
(#65) Expected 1 space after closing parenthesis; found 0
admin/tool/dataprivacy/dataregistry.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
admin/tool/dataprivacy/dataregistrysetup.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
admin/tool/dataprivacy/defaults.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
admin/tool/dataprivacy/editcategory.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
admin/tool/dataprivacy/editpurpose.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
admin/tool/dataprivacy/lib.php
(#147) Line exceeds 132 characters; contains 134 characters
(#166) Line exceeds 132 characters; contains 134 characters
(#200) Line exceeds 132 characters; contains 145 characters
(#270) Line exceeds 132 characters; contains 142 characters
admin/tool/dataprivacy/purposes.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
admin/tool/dataprivacy/settings.php
(#43) Line exceeds 132 characters; contains 136 characters
admin/tool/dataprivacy/tests/api_test.php
(#745) Line exceeds 132 characters; contains 147 characters
(#748) Line exceeds 132 characters; contains 147 characters

Javascript coding style problems

(1 errors, 2 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

admin/tool/dataprivacy/amd/src/data_registry.js
(#225) Each then() should return a value or throw (promise/always-return)
(#298) Missing JSDoc return type. (valid-jsdoc)
admin/tool/dataprivacy/amd/src/effective_retention_period.js
(#35) Line 35 exceeds the maximum line length of 132. (max-len)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(4 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

admin/tool/dataprivacy/classes/privacy/provider.php
(#32) Class provider is not documented
admin/tool/dataprivacy/lib.php
(#173) Function tool_dataprivacy_get_context_form_customdata is not documented
(#219) Function tool_dataprivacy_get_contextlevel_form_customdata is not documented
(#270) Function tool_dataprivacy_get_retention_display_text is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Task "eslint:amd" failed. Use --force to continue.
Problems running grunt

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 2 warnings)

This section shows problems detected in mustache templates [More info]

admin/tool/dataprivacy/templates/data_request_email.mustache
(#1) HTML Validation error, line 2: Element “style” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><style> t)
admin/tool/dataprivacy/templates/data_request_modal.mustache
(#1) HTML Validation info, line 10: Empty heading. ( <h3 id="would-be-a-uniqid-modal-title" class="modal-title" data-region="title" tabindex="0"> )