Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(75 errors, 229 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/crawler/classes/event/crawl_start.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/crawler/classes/event/observer.php
(#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/crawler/classes/event/robot_cleanup_completed.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/crawler/classes/event/robot_cleanup_started.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/crawler/classes/local/url.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#49) Short array syntax must be used to define arrays
(#50) Short array syntax must be used to define arrays
(#53) Short array syntax must be used to define arrays
(#56) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
(#66) Short array syntax must be used to define arrays
(#71) Short array syntax must be used to define arrays
(#76) Short array syntax must be used to define arrays
(#81) Short array syntax must be used to define arrays
(#86) Short array syntax must be used to define arrays
(#91) Short array syntax must be used to define arrays
(#96) Short array syntax must be used to define arrays
(#101) Short array syntax must be used to define arrays
(#106) Short array syntax must be used to define arrays
(#111) Short array syntax must be used to define arrays
(#116) Short array syntax must be used to define arrays
(#121) Short array syntax must be used to define arrays
(#126) Short array syntax must be used to define arrays
(#131) Short array syntax must be used to define arrays
(#136) Short array syntax must be used to define arrays
(#141) Short array syntax must be used to define arrays
(#146) Short array syntax must be used to define arrays
(#196) Short array syntax must be used to define arrays
(#227) Short array syntax must be used to define arrays
admin/tool/crawler/classes/privacy/provider.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#50) Method name "_get_reason" should not be prefixed with an underscore to indicate visibility
admin/tool/crawler/classes/robot/crawler.php
(#84) Short array syntax must be used to define arrays
(#89) There should be a comma after the last array item in a multi-line array.
(#108) Short array syntax must be used to define arrays
(#121) Short array syntax must be used to define arrays
(#128) Short array syntax must be used to define arrays
(#147) Short array syntax must be used to define arrays
(#151) Short array syntax must be used to define arrays
(#220) Short array syntax must be used to define arrays
(#344) Short array syntax must be used to define arrays
(#350) Short array syntax must be used to define arrays
(#361) Short array syntax must be used to define arrays
(#367) Short array syntax must be used to define arrays
(#386) Short array syntax must be used to define arrays
(#442) Short array syntax must be used to define arrays
(#506) Short array syntax must be used to define arrays
(#667) Function utf8_decode() is deprecated since PHP 8.2; Use mb_convert_encoding(), UConverter::transcode() or iconv instead
(#706) Short array syntax must be used to define arrays
(#827) Short array syntax must be used to define arrays
(#904) Short array syntax must be used to define arrays
(#1130) Short array syntax must be used to define arrays
(#1282) Short array syntax must be used to define arrays
(#1308) Inline comments must end in full-stops, exclamation marks, or question marks
(#1395) Short array syntax must be used to define arrays
(#1509) Short array syntax must be used to define arrays
admin/tool/crawler/classes/task/robot_cleanup.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#73) Short array syntax must be used to define arrays
(#76) There should be a comma after the last array item in a multi-line array.
(#86) Short array syntax must be used to define arrays
(#87) Short array syntax must be used to define arrays
(#88) There should be a comma after the last array item in a multi-line array.
(#89) There should be a comma after the last array item in a multi-line array.
admin/tool/crawler/cli/crawl-as.php
(#38) Short array syntax must be used to define arrays
(#42) Short array syntax must be used to define arrays
admin/tool/crawler/cli/crawler.php
(#32) Short array syntax must be used to define arrays
(#36) Short array syntax must be used to define arrays
(#37) There should be a comma after the last array item in a multi-line array.
admin/tool/crawler/cli/scrape-as.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#33) Short array syntax must be used to define arrays
(#37) Short array syntax must be used to define arrays
admin/tool/crawler/constants.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/crawler/db/tasks.php
(#27) Short array syntax must be used to define arrays
(#28) Short array syntax must be used to define arrays
(#35) There should be a comma after the last array item in a multi-line array.
(#37) Short array syntax must be used to define arrays
(#44) There should be a comma after the last array item in a multi-line array.
admin/tool/crawler/db/uninstall.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/crawler/db/upgrade.php
(#88) Short array syntax must be used to define arrays
(#125) Short array syntax must be used to define arrays
(#170) Short array syntax must be used to define arrays
admin/tool/crawler/index.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file index.php
(#70) Short array syntax must be used to define arrays
(#73) Short array syntax must be used to define arrays
(#74) Short array syntax must be used to define arrays
(#75) Short array syntax must be used to define arrays
(#76) Short array syntax must be used to define arrays
(#81) Short array syntax must be used to define arrays
(#83) Short array syntax must be used to define arrays
(#85) Short array syntax must be used to define arrays
(#87) Short array syntax must be used to define arrays
(#92) There should be a comma after the last array item in a multi-line array.
(#94) Short array syntax must be used to define arrays
(#96) There should be a comma after the last array item in a multi-line array.
(#98) Short array syntax must be used to define arrays
(#100) There should be a comma after the last array item in a multi-line array.
(#102) Short array syntax must be used to define arrays
(#104) There should be a comma after the last array item in a multi-line array.
(#106) Short array syntax must be used to define arrays
(#108) There should be a comma after the last array item in a multi-line array.
(#110) Short array syntax must be used to define arrays
(#112) There should be a comma after the last array item in a multi-line array.
(#114) Short array syntax must be used to define arrays
(#116) There should be a comma after the last array item in a multi-line array.
(#118) Short array syntax must be used to define arrays
(#120) There should be a comma after the last array item in a multi-line array.
(#122) Short array syntax must be used to define arrays
(#125) There should be a comma after the last array item in a multi-line array.
(#127) Short array syntax must be used to define arrays
(#129) There should be a comma after the last array item in a multi-line array.
(#139) Short array syntax must be used to define arrays
(#150) Short array syntax must be used to define arrays
(#151) Short array syntax must be used to define arrays
(#152) Short array syntax must be used to define arrays
(#160) Short array syntax must be used to define arrays
admin/tool/crawler/lang/en/tool_crawler.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#75) The string key "crawlend" is not in the correct order, it should be before "curcrawlstart"
(#80) The string key "debugnormal" is not in the correct order, it should be before "debugoff"
(#82) The string key "debuggingdesc" is not in the correct order, it should be before "debugverbose"
(#98) The string key "excludecourses" is not in the correct order, it should be before "excludemdlurldesc"
(#143) The string key "outgoingurls" is not in the correct order, it should be before "oversize_header"
(#144) The string key "crawl_task" is not in the correct order, it should be before "outgoingurls"
(#149) The string key "pluginname" is not in the correct order, it should be before "progresseta"
(#151) The string key "defaultpriority" is not in the correct order, it should be before "priority"
(#153) The string key "highpriority" is not in the correct order, it should be before "normalpriority"
(#154) The string key "custompriority" is not in the correct order, it should be before "highpriority"
(#160) The string key "recent_header" is not in the correct order, it should be before "recentactivitydesc"
(#166) The string key "resetprogress" is not in the correct order, it should be before "retry"
(#185) The string key "unknown" is not in the correct order, it should be before "useraccount"
(#195) Unexpected comment found. Auto-fixing will not work after this comment
(#196) Unexpected comment found. Auto-fixing will not work after this comment
(#197) Unexpected comment found. Auto-fixing will not work after this comment
(#198) The string key "privacy:no_data_reason" is not in the correct order, it should be before "whenqueued"
admin/tool/crawler/lib.php
(#80) Short array syntax must be used to define arrays
(#115) Short array syntax must be used to define arrays
(#116) Short array syntax must be used to define arrays
(#117) Short array syntax must be used to define arrays
(#129) Short array syntax must be used to define arrays
(#131) Short array syntax must be used to define arrays
(#167) Short array syntax must be used to define arrays
admin/tool/crawler/locallib.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#57) Short array syntax must be used to define arrays
(#58) Line exceeds 132 characters; contains 140 characters
(#62) Short array syntax must be used to define arrays
(#189) Short array syntax must be used to define arrays
(#194) Short array syntax must be used to define arrays
(#208) Short array syntax must be used to define arrays
(#218) Short array syntax must be used to define arrays
(#226) Short array syntax must be used to define arrays
(#253) Short array syntax must be used to define arrays
(#254) There should be a comma after the last array item in a multi-line array.
(#269) Short array syntax must be used to define arrays
(#293) Short array syntax must be used to define arrays
(#318) Short array syntax must be used to define arrays
admin/tool/crawler/report.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file report.php
(#39) Short array syntax must be used to define arrays
(#41) There should be a comma after the last array item in a multi-line array.
(#43) Short array syntax must be used to define arrays
(#46) There should be a comma after the last array item in a multi-line array.
(#57) Short array syntax must be used to define arrays
(#92) Short array syntax must be used to define arrays
(#117) Short array syntax must be used to define arrays
(#123) There should be a comma after the last array item in a multi-line array.
(#128) Short array syntax must be used to define arrays
(#138) Short array syntax must be used to define arrays
(#139) Short array syntax must be used to define arrays
(#145) There should be a comma after the last array item in a multi-line array.
(#161) Short array syntax must be used to define arrays
(#182) Short array syntax must be used to define arrays
(#191) Short array syntax must be used to define arrays
(#197) Short array syntax must be used to define arrays
(#216) Short array syntax must be used to define arrays
(#240) Short array syntax must be used to define arrays
(#251) Short array syntax must be used to define arrays
(#258) Short array syntax must be used to define arrays
(#311) Short array syntax must be used to define arrays
(#324) Short array syntax must be used to define arrays
(#334) Short array syntax must be used to define arrays
(#340) There should be a comma after the last array item in a multi-line array.
(#352) Short array syntax must be used to define arrays
(#354) There should be a comma after the last array item in a multi-line array.
admin/tool/crawler/settings.php
(#135) Short array syntax must be used to define arrays
(#178) Short array syntax must be used to define arrays
(#179) Short array syntax must be used to define arrays
(#193) Short array syntax must be used to define arrays
(#200) There should be a comma after the last array item in a multi-line array.
admin/tool/crawler/tabs.php
(#31) There should be a comma after the last array item in a multi-line array.
(#44) There should be a comma after the last array item in a multi-line array.
admin/tool/crawler/tests/phpunit/robot_cleanup_test.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#40) Unit test tool_crawler_robot_cleanup_test should be declared as final.
(#40) PHPUnit testcase name "tool_crawler_robot_cleanup_test" does not match file name "robot_cleanup_test"
(#40) PHPUnit class "tool_crawler_robot_cleanup_test" does not have any namespace. It is recommended to add it to the "tool_crawler" namespace, using more levels if needed, in order to match the code being tested
(#47) The setUp() method in unit tests must always call to parent::setUp().
(#56) Short array syntax must be used to define arrays
(#57) Short array syntax must be used to define arrays
(#76) There should be a comma after the last array item in a multi-line array.
(#78) Short array syntax must be used to define arrays
(#97) There should be a comma after the last array item in a multi-line array.
(#99) Short array syntax must be used to define arrays
(#118) There should be a comma after the last array item in a multi-line array.
(#119) There should be a comma after the last array item in a multi-line array.
(#137) Test method test_robot_cleanup() is missing any coverage information, own or at class level
(#137) Test method test_robot_cleanup() is missing a return type
admin/tool/crawler/tests/phpunit/robot_crawler_test.php
(#40) Unit test tool_crawler_robot_crawler_test should be declared as final.
(#40) PHPUnit testcase name "tool_crawler_robot_crawler_test" does not match file name "robot_crawler_test"
(#40) PHPUnit class "tool_crawler_robot_crawler_test" does not have any namespace. It is recommended to add it to the "tool_crawler" namespace, using more levels if needed, in order to match the code being tested
(#45) The setUp() method in unit tests must always call to parent::setUp().
(#45) There must be a single space between the colon and type in a return type declaration
(#58) Data provider method "absolute_urls_provider" will need to be converted to static in future.
(#58) No one-line description found in phpdocs for docblock of function absolute_urls_provider
(#58) Data provider method "absolute_urls_provider" must return an array, a Generator or an Iterable.
(#59) Short array syntax must be used to define arrays
(#60) Short array syntax must be used to define arrays
(#62) Short array syntax must be used to define arrays
(#67) There should be a comma after the last array item in a multi-line array.
(#68) There should be a comma after the last array item in a multi-line array.
(#70) Short array syntax must be used to define arrays
(#72) Short array syntax must be used to define arrays
(#77) There should be a comma after the last array item in a multi-line array.
(#78) There should be a comma after the last array item in a multi-line array.
(#80) Short array syntax must be used to define arrays
(#82) Short array syntax must be used to define arrays
(#86) There should be a comma after the last array item in a multi-line array.
(#87) There should be a comma after the last array item in a multi-line array.
(#89) Short array syntax must be used to define arrays
(#91) Short array syntax must be used to define arrays
(#95) There should be a comma after the last array item in a multi-line array.
(#96) There should be a comma after the last array item in a multi-line array.
(#98) Short array syntax must be used to define arrays
(#100) Short array syntax must be used to define arrays
(#116) Test method test_absolute_urls() is missing any coverage information, own or at class level
(#116) No one-line description found in phpdocs for docblock of function test_absolute_urls
(#116) Test method test_absolute_urls() is missing a return type
(#127) Data provider method "should_auth_provider" will need to be converted to static in future.
(#127) No one-line description found in phpdocs for docblock of function should_auth_provider
(#127) Data provider method "should_auth_provider" must return an array, a Generator or an Iterable.
(#128) Short array syntax must be used to define arrays
(#129) Short array syntax must be used to define arrays
(#130) Short array syntax must be used to define arrays
(#131) Short array syntax must be used to define arrays
(#132) Short array syntax must be used to define arrays
(#133) Short array syntax must be used to define arrays
(#134) Short array syntax must be used to define arrays
(#135) Short array syntax must be used to define arrays
(#136) Short array syntax must be used to define arrays
(#149) Test method test_should_be_authenticated() is missing any coverage information, own or at class level
(#149) No one-line description found in phpdocs for docblock of function test_should_be_authenticated
(#149) Test method test_should_be_authenticated() is missing a return type
(#159) Test method test_param_retention_exists() is missing any coverage information, own or at class level
(#159) Test method test_param_retention_exists() is missing a return type
(#165) Test method test_reset_queries() is missing any coverage information, own or at class level
(#165) No one-line description found in phpdocs for docblock of function test_reset_queries
(#165) Test method test_reset_queries() is missing a return type
(#189) There should be a comma after the last array item in a multi-line array.
(#214) Test method test_uri_escaping() is missing any coverage information, own or at class level
(#214) Test method test_uri_escaping() is missing a return type
(#239) Test method test_redirection_uri_escaping() is missing any coverage information, own or at class level
(#239) Test method test_redirection_uri_escaping() is missing a return type
(#264) There should be a comma after the last array item in a multi-line array.
(#286) Test method test_should_be_excluded() is missing any coverage information, own or at class level
(#286) Test method test_should_be_excluded() is missing a return type
(#308) There should be a comma after the last array item in a multi-line array.
(#338) Short array syntax must be used to define arrays
(#347) Data provider method "priority_provider" will need to be converted to static in future.
(#347) Data provider method "priority_provider" must return an array, a Generator or an Iterable.
(#351) There should be a comma after the last array item in a multi-line array.
(#362) Test method test_parse_html_priority_inheritance() is missing any coverage information, own or at class level
(#362) No one-line description found in phpdocs for docblock of function test_parse_html_priority_inheritance
(#362) Test method test_parse_html_priority_inheritance() is missing a return type
(#391) Short array syntax must be used to define arrays
(#425) Data provider method "should_be_crawled_provider" will need to be converted to static in future.
(#425) Data provider method "should_be_crawled_provider" must return an array, a Generator or an Iterable.
(#443) Test method test_should_be_crawled() is missing any coverage information, own or at class level
(#443) Test method test_should_be_crawled() is missing a return type
(#464) Test method test_url_creates_hash() is missing any coverage information, own or at class level
(#464) Test method test_url_creates_hash() is missing a return type
(#486) There should be a comma after the last array item in a multi-line array.
(#515) Data provider method "crawler_url_string_matches_provider" will need to be converted to static in future.
(#515) Data provider method "crawler_url_string_matches_provider" must return an array, a Generator or an Iterable.
(#550) Test method test_crawler_url_string_matches() is missing any coverage information, own or at class level
(#550) Test method test_crawler_url_string_matches() is missing a return type
(#560) Data provider method "url_validity_check_provider" will need to be converted to static in future.
(#560) Data provider method "url_validity_check_provider" must return an array, a Generator or an Iterable.
(#578) Test method test_invalid_url() is missing any coverage information, own or at class level
(#578) No one-line description found in phpdocs for docblock of function test_invalid_url
(#578) Test method test_invalid_url() is missing a return type
(#593) Data provider method "page_title_validity_check_provider" will need to be converted to static in future.
(#593) Data provider method "page_title_validity_check_provider" must return an array, a Generator or an Iterable.
(#608) Test method test_check_page_title_validity() is missing any coverage information, own or at class level
(#608) No one-line description found in phpdocs for docblock of function test_check_page_title_validity
(#608) Test method test_check_page_title_validity() is missing a return type
admin/tool/crawler/tests/test1.php
(#40) Short array syntax must be used to define arrays
admin/tool/crawler/url.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file url.php
(#24) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
admin/tool/crawler/version.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#31) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) Short array syntax must be used to define arrays

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]