Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(110 errors, 62 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/category_backup/classes/backup/backup_controller.class.php
(#33) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) Missing docblock for class backup_controller
(#36) Opening brace should be on the same line as the declaration for class backup_controller
(#48) No one-line description found in phpdocs for docblock of function __construct
(#49) Opening brace should be on the same line as the declaration
(#59) Inline comments must end in full-stops, exclamation marks, or question marks
(#71) Inline comments must end in full-stops, exclamation marks, or question marks
(#74) Inline comments must end in full-stops, exclamation marks, or question marks
(#77) Inline comments must end in full-stops, exclamation marks, or question marks
(#80) Inline comments must end in full-stops, exclamation marks, or question marks
(#83) Inline comments must end in full-stops, exclamation marks, or question marks
(#86) Inline comments must end in full-stops, exclamation marks, or question marks
(#101) Inline comments must end in full-stops, exclamation marks, or question marks
(#104) Inline comments must end in full-stops, exclamation marks, or question marks
(#107) Inline comments must end in full-stops, exclamation marks, or question marks
(#110) Inline comments must end in full-stops, exclamation marks, or question marks
(#113) Inline comments must end in full-stops, exclamation marks, or question marks
(#116) Inline comments must end in full-stops, exclamation marks, or question marks
(#128) No one-line description found in phpdocs for docblock of function load_plan
(#131) Inline comments must end in full-stops, exclamation marks, or question marks
(#136) File must end with a newline character
admin/tool/category_backup/classes/backup/backup_plan_category_backup.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#32) Missing docblock for class backup_plan_category_backup
(#33) Opening brace should be on the same line as the declaration for class backup_plan_category_backup
(#34) Missing docblock for function __construct
(#35) Opening brace should be on the same line as the declaration
(#45) File must end with a newline character
admin/tool/category_backup/classes/form/form_category_backup.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#32) Missing docblock for class form_category_backup
(#33) Opening brace should be on the same line as the declaration for class form_category_backup
(#37) No one-line description found in phpdocs for docblock of function definition
(#38) Opening brace should be on the same line as the declaration
(#48) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#56) Variable "formatted_url" must not contain underscores.
(#60) Variable "formatted_url" must not contain underscores.
(#62) Functions must not contain multiple empty lines in a row; found 2 empty lines
admin/tool/category_backup/classes/local/asynchronous_category_backup.php
(#39) Missing docblock for class asynchronous_category_backup
(#40) Opening brace should be on the same line as the declaration for class asynchronous_category_backup
(#46) Opening brace should be on the same line as the declaration
(#53) Short array syntax must be used to define arrays
(#55) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#96) Short array syntax must be used to define arrays
(#97) Inline comments must end in full-stops, exclamation marks, or question marks
(#97) No space found before comment text; expected "// Rename file" but found "//Rename file"
(#114) Visibility must be declared on method "tool_category_backup_update_file"
(#115) Opening brace should be on the same line as the declaration
(#118) Short array syntax must be used to define arrays
(#119) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#121) Inline comments must end in full-stops, exclamation marks, or question marks
(#121) No space found before comment text; expected "// Obtener el controller" but found "//Obtener el controller"
(#126) Variable "filename_v" must not contain underscores.
(#127) Whitespace found at end of line within string
(#128) Whitespace found at end of line within string
(#129) Whitespace found at end of line within string
(#130) Whitespace found at end of line within string
(#131) Whitespace found at end of line within string
(#137) There should be a comma after the last array item in a multi-line array.
(#137) Variable "filename_v" must not contain underscores.
(#139) Variable "file_verified" must not contain underscores.
(#142) Inline comments must end in full-stops, exclamation marks, or question marks
(#143) Variable "file_verified" must not contain underscores.
(#143) Inline comments must start with a capital letter, digit or 3-dots sequence
(#143) Inline comments must end in full-stops, exclamation marks, or question marks
(#145) Inline comments must end in full-stops, exclamation marks, or question marks
(#146) Variable "file_get" must not contain underscores.
(#149) This comment is 53% valid code; is this commented out code?
(#149) No space found before comment text; expected "// If file exist, deleted!" but found "//If file exist, deleted!"
(#150) Inline comments must end in full-stops, exclamation marks, or question marks
(#150) No space found before comment text; expected "// mtrace($file_get->get_timecreated());" but found "//mtrace($file_get->get_timecreated());"
(#151) Variable "file_get" must not contain underscores.
(#153) Variable "file_get" must not contain underscores.
(#155) Inline comments must start with a capital letter, digit or 3-dots sequence
(#155) Inline comments must end in full-stops, exclamation marks, or question marks
(#159) Inline comments must end in full-stops, exclamation marks, or question marks
(#159) No space found before comment text; expected "// Rename file" but found "//Rename file"
(#161) Inline comments must end in full-stops, exclamation marks, or question marks
(#161) No space found before comment text; expected "// The filename has to be to referencie, In time of run the copy from backup/moodle2/backup_root_task.class.php" but found "//The filename has to be to referencie, In time of run the copy from backup/moodle2/backup_root_task.class.php"
(#162) Whitespace found at end of line within string
(#163) Whitespace found at end of line within string
(#164) Whitespace found at end of line within string
(#165) Whitespace found at end of line within string
(#172) Variable "file_get" must not contain underscores.
(#174) Variable "file_get" must not contain underscores.
(#174) Variable "filename_v" must not contain underscores.
(#176) File must end with a newline character
admin/tool/category_backup/classes/privacy/provider.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#29) Opening brace should be on the same line as the declaration for class provider
(#31) Invalid docblock tag "@inheritDoc".
(#33) No one-line description found in phpdocs for docblock of function get_reason
(#34) Opening brace should be on the same line as the declaration
(#37) File must end with a newline character
admin/tool/category_backup/db/access.php
(#27) Short array syntax must be used to define arrays
(#35) There should be a comma after the last array item in a multi-line array.
(#38) File must end with a newline character
admin/tool/category_backup/db/caches.php
(#27) Short array syntax must be used to define arrays
(#28) Short array syntax must be used to define arrays
(#33) File must end with a newline character
admin/tool/category_backup/index.php
(#27) "require_once" must be immediately followed by an open parenthesis
(#28) "require" must be immediately followed by an open parenthesis
(#45) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#70) Variable "json_data" must not contain underscores.
(#71) Variable "json_data" must not contain underscores.
(#75) Short array syntax must be used to define arrays
(#75) Line exceeds 132 characters; contains 139 characters
admin/tool/category_backup/lang/en/tool_category_backup.php
(#25) The string key "backup_category:execute" is not in the correct order, it should be before "pluginname"
(#27) The string key "back" is not in the correct order, it should be before "nopermissions"
(#31) The string key "name_backup" is not in the correct order, it should be before "size"
(#32) The string key "date_backup" is not in the correct order, it should be before "name_backup"
(#34) The string key "generate_task" is not in the correct order, it should be before "visible"
(#40) The string key "js_finish" is not in the correct order, it should be before "url_config"
(#45) The string key "download_backups" is not in the correct order, it should be before "js_m4"
(#47) The string key "hidden" is not in the correct order, it should be before "show"
(#48) Unexpected string end, it should be a line feed after a semicolon
(#48) File must end with a newline character
admin/tool/category_backup/lang/es/tool_category_backup.php
(#25) The string key "backup_category:execute" is not in the correct order, it should be before "pluginname"
(#27) The string key "back" is not in the correct order, it should be before "nopermissions"
(#31) The string key "name_backup" is not in the correct order, it should be before "size"
(#32) The string key "date_backup" is not in the correct order, it should be before "name_backup"
(#34) The string key "generate_task" is not in the correct order, it should be before "visible"
(#40) The string key "js_finish" is not in the correct order, it should be before "url_config"
(#45) The string key "download_backups" is not in the correct order, it should be before "js_m4"
(#47) The string key "hidden" is not in the correct order, it should be before "show"
admin/tool/category_backup/lib.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#35) Opening brace should be on the same line as the declaration
(#38) Variable "user_doing_the_backup" must not contain underscores.
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
(#40) Variable "user_doing_the_backup" must not contain underscores.
(#43) Short array syntax must be used to define arrays
(#60) Opening brace should be on the same line as the declaration
(#74) Whitespace found at end of line within string
(#75) Whitespace found at end of line within string
(#76) Whitespace found at end of line within string
(#78) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#83) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#97) Variable "courses_validate" must not contain underscores.
(#107) Line exceeds 132 characters; contains 149 characters
(#128) Variable "tam_file" must not contain underscores.
(#129) Variable "info_size_file" must not contain underscores.
(#129) Variable "tam_file" must not contain underscores.
(#130) Variable "tam_file" must not contain underscores.
(#131) Variable "tam_file" must not contain underscores.
(#131) Variable "tam_file" must not contain underscores.
(#132) Variable "info_size_file" must not contain underscores.
(#132) Variable "tam_file" must not contain underscores.
(#133) Variable "tam_file" must not contain underscores.
(#134) Variable "tam_file" must not contain underscores.
(#134) Variable "tam_file" must not contain underscores.
(#135) Variable "info_size_file" must not contain underscores.
(#135) Variable "tam_file" must not contain underscores.
(#137) Variable "info_size_file" must not contain underscores.
(#146) Variable "courses_validate" must not contain underscores.
(#154) Variable "courses_validate" must not contain underscores.
(#164) Opening brace should be on the same line as the declaration
(#167) Inline comments must end in full-stops, exclamation marks, or question marks
(#167) No space found before comment text; expected "// Obtener el controller" but found "//Obtener el controller"
(#169) Variable "filename_v" must not contain underscores.
(#171) Whitespace found at end of line within string
(#172) Whitespace found at end of line within string
(#173) Whitespace found at end of line within string
(#174) Whitespace found at end of line within string
(#176) Variable "filename_v" must not contain underscores.
(#177) Variable "file_verified" must not contain underscores.
(#181) Inline comments must end in full-stops, exclamation marks, or question marks
(#182) Variable "file_verified" must not contain underscores.
(#182) Inline comments must start with a capital letter, digit or 3-dots sequence
(#182) Inline comments must end in full-stops, exclamation marks, or question marks
(#184) Inline comments must end in full-stops, exclamation marks, or question marks
(#185) Variable "file_get" must not contain underscores.
(#188) Variable "file_get" must not contain underscores.
(#192) File must end with a newline character
admin/tool/category_backup/version.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#28) File must end with a newline character

Javascript coding style problems

(8 errors, 14 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

admin/tool/category_backup/amd/src/download.js
(#27) Identifier 'init_process' is not in camel case. (camelcase)
(#28) Identifier 'data_course' is not in camel case. (camelcase)
(#28) 'data_course' is not defined. (no-undef)
(#31) Unexpected space before function parentheses. (space-before-function-paren)
(#33) Identifier 'data_course' is not in camel case. (camelcase)
(#33) 'data_course' is not defined. (no-undef)
(#42) Identifier 'data_course' is not in camel case. (camelcase)
(#42) 'data_course' is not defined. (no-undef)
(#42) ["downloadbackup"] is better written in dot notation. (dot-notation)
(#43) Identifier 'data_course' is not in camel case. (camelcase)
(#43) 'data_course' is not defined. (no-undef)
(#43) ["downloadbackup"] is better written in dot notation. (dot-notation)
(#48) This line has a length of 137. Maximum allowed is 132. (max-len)
(#48) Identifier 'data_course' is not in camel case. (camelcase)
(#48) 'data_course' is not defined. (no-undef)
(#48) ["fullname"] is better written in dot notation. (dot-notation)
(#48) Identifier 'data_course' is not in camel case. (camelcase)
(#48) 'data_course' is not defined. (no-undef)
(#48) ["filename"] is better written in dot notation. (dot-notation)
(#55) Identifier 'data_course' is not in camel case. (camelcase)
(#55) 'data_course' is not defined. (no-undef)
(#55) ["fullname"] is better written in dot notation. (dot-notation)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(5 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

admin/tool/category_backup/classes/backup/backup_controller.class.php
(#39) Phpdocs for function backup_controller::__construct has incomplete parameters list
admin/tool/category_backup/classes/local/asynchronous_category_backup.php
(#109) Phpdocs for function asynchronous_category_backup::tool_category_backup_update_file has incomplete parameters list
admin/tool/category_backup/lib.php
(#31) Phpdocs for function tool_category_backup_create_backup has incomplete parameters list
(#53) Phpdocs for function tool_category_backup_get_courses has incomplete parameters list
(#160) Phpdocs for function tool_category_backup_get_file_backup has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 5 warnings)

This section shows problems detected in mustache templates [More info]

admin/tool/category_backup/templates/buttons.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 3: Bad value “” for attribute “action” on element “form”: Must be non-empty. (p-3"> <form action="" method="post"> )
(#1) HTML Validation error, line 8: Bad value “” for attribute “action” on element “form”: Must be non-empty. (form> <form action="" method="post"> )
(#1) HTML Validation error, line 13: Bad value “” for attribute “action” on element “form”: Must be non-empty. (form> <form action="" method="post"> )
admin/tool/category_backup/templates/success_task.mustache
(#1) Example context missing (@template section not found.)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]