Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(33 errors, 11 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

lib/editor/tiny/plugins/stash/classes/plugininfo.php: (#39) The interface names in a "class implements" statement should be ordered alphabetically. Expected: plugin_with_buttons, plugin_with_menuitems, plugin_with_configuration; Found: plugin_with_buttons, plugin_with_configuration, plugin_with_menuitems; (#42) Opening brace must not be followed by a blank line; (#44) Missing member variable doc comment; (#46) Missing member variable doc comment; (#48) Missing member variable doc comment; (#50) Missing member variable doc comment; (#52) Missing docblock for function is_enabled; (#52) Line exceeds 132 characters; contains 134 characters; (#63) Missing docblock for function get_available_buttons; (#69) Missing docblock for function get_available_menuitems; (#75) Missing docblock for function get_courseid_from_context; (#91) Missing docblock for function get_plugin_configuration_for_context; (#91) The first parameter of a multi-line function declaration must be on the line after the opening bracket; (#91) Multi-line function declarations must define one parameter per line; (#91) Multi-line function declarations must define one parameter per line; (#92) Multi-line function declaration not indented correctly; expected 8 spaces but found 12; (#92) The closing parenthesis of a multi-line function declaration must be on a new line; (#97) Inline comments must start with a capital letter, digit or 3-dots sequence; (#132) There should be a comma after the last array item in a multi-line array.; (#144) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#145) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#146) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#147) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#150) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#151) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#152) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#153) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#154) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#168) There should be a comma after the last array item in a multi-line array.; (#175) Parentheses must be used when instantiating a new class; (#191) There should be a comma after the last array item in a multi-line array.
lib/editor/tiny/plugins/stash/classes/privacy/provider.php: (#27) Missing docblock for function get_reason
lib/editor/tiny/plugins/stash/lang/en/tiny_stash.php: (#28) The string key "additemlocation" is not in the correct order, it should be before "additemloss"; (#37) The string key "collectioninterval" is not in the correct order, it should be before "createitems"; (#81) The string key "days" is not in the correct order, it should be before "weeks"; (#84) Expected 1 blank line at end of file; 2 found
lib/editor/tiny/plugins/stash/lib.php: (#25) Missing docblock for function tiny_stash_output_fragment_add_item_form; (#43) Inline comments must start with a capital letter, digit or 3-dots sequence; (#43) Inline comments must end in full-stops, exclamation marks, or question marks; (#43) This comment is 75% valid code; is this commented out code?; (#45) Inline comments must start with a capital letter, digit or 3-dots sequence; (#45) Inline comments must end in full-stops, exclamation marks, or question marks; (#45) This comment is 80% valid code; is this commented out code?; (#50) Missing docblock for function tiny_stash_output_fragment_add_trade_form

Javascript coding style problems

(0 errors, 107 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

lib/editor/tiny/plugins/stash/amd/src/additem.js: (#51) Expected catch,fail,always() or return (promise/catch-or-return); (#51) There should be no space before ','. (comma-spacing); (#51) A space is required after ','. (comma-spacing); (#51) Each then() should return a value or throw (promise/always-return); (#63) Expected catch,fail,always() or return (promise/catch-or-return); (#63) Each then() should return a value or throw (promise/always-return); (#145) Expected catch,fail,always() or return (promise/catch-or-return); (#145) Each then() should return a value or throw (promise/always-return); (#152) Expected catch,fail,always() or return (promise/catch-or-return); (#152) Each then() should return a value or throw (promise/always-return); (#170) Expected catch,fail,always() or return (promise/catch-or-return); (#171) Each then() should return a value or throw (promise/always-return); (#172) Expected catch,fail,always() or return (promise/catch-or-return); (#172) Avoid nesting promises. (promise/no-nesting); (#175) Each then() should return a value or throw (promise/always-return); (#204) Unexpected space before function parentheses. (space-before-function-paren); (#219) Comments should not begin with a lowercase character. (capitalized-comments)
lib/editor/tiny/plugins/stash/amd/src/addtrade.js: (#42) Expected catch,fail,always() or return (promise/catch-or-return); (#42) Each then() should return a value or throw (promise/always-return); (#55) Expected catch,fail,always() or return (promise/catch-or-return); (#55) There should be no space before ','. (comma-spacing); (#55) A space is required after ','. (comma-spacing); (#55) Each then() should return a value or throw (promise/always-return); (#59) Expected catch,fail,always() or return (promise/catch-or-return); (#59) Each then() should return a value or throw (promise/always-return); (#67) Unexpected space before function parentheses. (space-before-function-paren); (#79) Comments should not begin with a lowercase character. (capitalized-comments); (#89) Comments should not begin with a lowercase character. (capitalized-comments); (#90) Expected catch,fail,always() or return (promise/catch-or-return); (#90) Each then() should return a value or throw (promise/always-return); (#97) Comments should not begin with a lowercase character. (capitalized-comments); (#98) Expected catch,fail,always() or return (promise/catch-or-return); (#98) Each then() should return a value or throw (promise/always-return); (#177) Expected catch,fail,always() or return (promise/catch-or-return); (#177) Each then() should return a value or throw (promise/always-return); (#193) ["name"] is better written in dot notation. (dot-notation); (#200) Extra space after key 'courseid'. (key-spacing); (#201) Extra space after key 'stashid'. (key-spacing); (#202) Extra space after key 'hashcode'. (key-spacing); (#203) Extra space after key 'title'. (key-spacing); (#204) Extra space after key 'gain'. (key-spacing); (#205) Extra space after key 'loss'. (key-spacing); (#206) Extra space after key 'additems'. (key-spacing); (#207) Extra space after key 'lossitems'. (key-spacing); (#209) Expected catch,fail,always() or return (promise/catch-or-return); (#209) Each then() should return a value or throw (promise/always-return)
lib/editor/tiny/plugins/stash/amd/src/configuration.js: (#40) Identifier 'content_css' is not in camel case. (camelcase)
lib/editor/tiny/plugins/stash/amd/src/drop-add.js: (#44) Comments should not begin with a lowercase character. (capitalized-comments); (#55) Expected catch,fail,always() or return (promise/catch-or-return); (#55) Each then() should return a value or throw (promise/always-return); (#60) Expected catch,fail,always() or return (promise/catch-or-return); (#60) Each then() should return a value or throw (promise/always-return); (#149) Expected catch,fail,always() or return (promise/catch-or-return); (#149) Each then() should return a value or throw (promise/always-return); (#185) Expected catch,fail,always() or return (promise/catch-or-return); (#185) Each then() should return a value or throw (promise/always-return)
lib/editor/tiny/plugins/stash/amd/src/helptabs.js: (#35) Expected catch,fail,always() or return (promise/catch-or-return); (#35) Each then() should return a value or throw (promise/always-return)
lib/editor/tiny/plugins/stash/amd/src/options.js: (#57) Unquoted reserved word 'default' used as key. (quote-props); (#61) Unquoted reserved word 'default' used as key. (quote-props); (#65) Unquoted reserved word 'default' used as key. (quote-props); (#69) Unquoted reserved word 'default' used as key. (quote-props)
lib/editor/tiny/plugins/stash/amd/src/plugin.js: (#29) Unexpected space before function parentheses. (space-before-function-paren)
lib/editor/tiny/plugins/stash/amd/src/ui.js: (#37) There should be no space after '{'. (@babel/object-curly-spacing); (#37) There should be no space before '}'. (@babel/object-curly-spacing); (#55) Unexpected space before function parentheses. (space-before-function-paren); (#62) There should be no space after '{'. (@babel/object-curly-spacing); (#62) There should be no space before '}'. (@babel/object-curly-spacing); (#63) There should be no space after '{'. (@babel/object-curly-spacing); (#63) There should be no space before '}'. (@babel/object-curly-spacing); (#69) There should be no space after '{'. (@babel/object-curly-spacing); (#69) There should be no space after '{'. (@babel/object-curly-spacing); (#69) There should be no space before '}'. (@babel/object-curly-spacing); (#69) There should be no space before '}'. (@babel/object-curly-spacing); (#71) There should be no space after '{'. (@babel/object-curly-spacing); (#71) There should be no space after '{'. (@babel/object-curly-spacing); (#71) There should be no space before '}'. (@babel/object-curly-spacing); (#71) There should be no space before '}'. (@babel/object-curly-spacing); (#76) There should be no space after '{'. (@babel/object-curly-spacing); (#105) Unnecessary escape character: \]. (no-useless-escape); (#113) Expected catch,fail,always() or return (promise/catch-or-return); (#216) Unexpected space before function parentheses. (space-before-function-paren); (#223) Expected catch,fail,always() or return (promise/catch-or-return); (#223) Each then() should return a value or throw (promise/always-return); (#233) Expected catch,fail,always() or return (promise/catch-or-return); (#237) Each then() should return a value or throw (promise/always-return); (#237) Operator '=' must be spaced. (space-infix-ops); (#237) Operator '<' must be spaced. (space-infix-ops); (#260) Comments should not begin with a lowercase character. (capitalized-comments); (#280) Expected catch,fail,always() or return (promise/catch-or-return); (#280) Each then() should return a value or throw (promise/always-return); (#287) Expected catch,fail,always() or return (promise/catch-or-return); (#291) Each then() should return a value or throw (promise/always-return); (#291) Operator '=' must be spaced. (space-infix-ops); (#291) Operator '<' must be spaced. (space-infix-ops); (#327) Unexpected space before function parentheses. (space-before-function-paren); (#341) ["id"] is better written in dot notation. (dot-notation); (#347) Expected catch,fail,always() or return (promise/catch-or-return); (#347) Each then() should return a value or throw (promise/always-return); (#389) Comments should not begin with a lowercase character. (capitalized-comments); (#409) Comments should not begin with a lowercase character. (capitalized-comments); (#448) Expected catch,fail,always() or return (promise/catch-or-return); (#448) Each then() should return a value or throw (promise/always-return); (#505) Expected catch,fail,always() or return (promise/catch-or-return); (#505) Each then() should return a value or throw (promise/always-return); (#517) Unexpected space before function parentheses. (space-before-function-paren); (#526) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "gherkinlint" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 25 warnings)

This section shows problems detected in mustache templates [More info]

lib/editor/tiny/plugins/stash/templates/drop-code-selector.mustache: (#1) Example context missing (@template section not found.); (#1) HTML Validation error, line 47: Duplicate ID “navbarTogglerItems”. ( <div class="collapse navbar-collapse" id="navbarTogglerItems"> ); (#1) HTML Validation info, line 28: The first occurrence of ID “navbarTogglerItems” was here. ( <div class="collapse navbar-collapse" id="navbarTogglerItems"> ); (#1) HTML Validation error, line 10: The “aria-controls” attribute must point to an element in the same document. ( <a class="nav-link active" id="item-tab" data-bs-toggle="tab" data-tiny-stash href="#item" role="tab" aria-controls="items" aria-selected="true">((loca); (#1) HTML Validation error, line 13: The “aria-controls” attribute must point to an element in the same document. ( <a class="nav-link" id="trade-tab" data-bs-toggle="tab" data-tiny-stash href="#trade" role="tab" aria-controls="trades" aria-selected="false">((trad)
lib/editor/tiny/plugins/stash/templates/drop-select.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/item-drop-snippet.mustache: (#1) Example context missing (@template section not found.); (#1) HTML Validation info, line 26: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="text" name="actiontext" class="form-control" id="label-actiontext-would-be-a-uniqid" value="((pickup%2C+tiny_stash))" /> )
lib/editor/tiny/plugins/stash/templates/item-preview.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/footers/add-drop-footer.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/footers/add-item-footer.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/footers/add-trade-footer.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/footers/help-footer.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/footers/main-footer.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/help/itemhelp.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/help/locationhelp.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/help/tradehelp.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/nav/trade-nav.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/selectors/trade-drop-selector.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/tabs/drop-form.mustache: (#1) Example context missing (@template section not found.); (#1) HTML Validation info, line 38: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="text" name="actiontext" class="form-control" id="label-actiontext-would-be-a-uniqid" value="((pickup%2C+tiny_stash))" /> )
lib/editor/tiny/plugins/stash/templates/local/tabs/help-main.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/tabs/locations-main.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/tabs/trade-form.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/local/tabs/trades-main.mustache: (#1) Example context missing (@template section not found.)
lib/editor/tiny/plugins/stash/templates/stash-drop-form.mustache: (#1) Example context missing (@template section not found.); (#1) HTML Validation info, line 11: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (> <input type="text" class="form-control location-name" value="" /> <); (#1) HTML Validation info, line 17: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="number" class="form-control location-supplies" placeholder="1" value="1" min="1" /> ); (#1) HTML Validation info, line 21: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="checkbox" class="form-check-input" id="supplyunlimited" /> ); (#1) HTML Validation info, line 31: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="text" class="form-control intervalnumber" placeholder="1" value="1" size="3" disabled /> )
lib/editor/tiny/plugins/stash/templates/trade-preview.mustache: (#1) Example context missing (@template section not found.); (#1) HTML Validation error, line 15: The “center” element is obsolete. Use CSS instead. (> <center><butto)

Gherkin .feature problems

(5 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

lib/editor/tiny/plugins/stash/tests/behat/create_item.feature: (#7) Wrong indentation for "Background", expected indentation level of 2, but got 0; (#27) Wrong indentation for "Scenario", expected indentation level of 2, but got 0
lib/editor/tiny/plugins/stash/tests/behat/editor_visibility.feature: (#7) Wrong indentation for "Background", expected indentation level of 2, but got 0; (#27) Wrong indentation for "Scenario", expected indentation level of 2, but got 0; (#31) Wrong indentation for "Scenario", expected indentation level of 2, but got 0