Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(8 errors, 19 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

lib/editor/tiny/plugins/molstructure/classes/external/image_generator.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#32) Import statements must not begin with a leading backslash
(#33) Import statements must not begin with a leading backslash
(#34) Import statements must not begin with a leading backslash
(#35) Import statements must not begin with a leading backslash
lib/editor/tiny/plugins/molstructure/classes/plugininfo.php
(#87) Missing docblock for function is_enabled
lib/editor/tiny/plugins/molstructure/classes/privacy/provider.php
(#38) There must not be a space before the colon in a return type declaration
lib/editor/tiny/plugins/molstructure/db/access.php
(#29) Short array syntax must be used to define arrays
(#31) Short array syntax must be used to define arrays
(#34) Short array syntax must be used to define arrays
lib/editor/tiny/plugins/molstructure/db/services.php
(#29) Short array syntax must be used to define arrays
(#30) Short array syntax must be used to define arrays
lib/editor/tiny/plugins/molstructure/lang/en/tiny_molstructure.php
(#28) The string key "buttontitle" is not in the correct order, it should be before "pluginname"
(#29) The string key "alreadyexistingfile" is not in the correct order, it should be before "buttontitle"
(#30) The string key "Xfilestored" is not in the correct order, it should be before "alreadyexistingfile"
(#32) The string key "insertimage" is not in the correct order, it should be before "unabletosaveXfile"
(#35) The string key "height" is not in the correct order, it should be before "resize"
(#37) The string key "update" is not in the correct order, it should be before "width"
(#40) The string key "jcamp" is not in the correct order, it should be before "ylabel"
(#41) The string key "integration" is not in the correct order, it should be before "jcamp"
(#44) The string key "dialogtitle" is not in the correct order, it should be before "title"
(#46) The string key "2Dcanvas" is not in the correct order, it should be before "instructions"
(#50) The string key "privacy:metadata" is not in the correct order, it should be before "updateKetcherButton"
lib/editor/tiny/plugins/molstructure/lib.php
(#31) Missing docblock for function tiny_molstructure_strings_for_js
(#33) Short array syntax must be used to define arrays
(#44) Missing docblock for function tiny_molstructure_params_for_js
(#50) Short array syntax must be used to define arrays

Javascript coding style problems

(1 errors, 113 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

lib/editor/tiny/plugins/molstructure/amd/src/canvas2D.js
(#32) Operator '=' must be spaced. (space-infix-ops)
(#33) Operator '=' must be spaced. (space-infix-ops)
(#34) Operator '=' must be spaced. (space-infix-ops)
(#35) Operator '=' must be spaced. (space-infix-ops)
(#38) ["H"] is better written in dot notation. (dot-notation)
(#39) ["S"] is better written in dot notation. (dot-notation)
(#43) Missing space before value for key 'useServices'. (key-spacing)
(#43) Missing space before value for key 'oneMolecule'. (key-spacing)
(#44) Expected space or tab after '//' in comment. (spaced-comment)
(#45) Identifier 'atoms_displayTerminalCarbonLabels_2D' is not in camel case. (camelcase)
(#46) Identifier 'atoms_useJMOLColors' is not in camel case. (camelcase)
(#47) Identifier 'bonds_clearOverlaps_2D' is not in camel case. (camelcase)
(#51) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#53) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#53) Identifier 'atoms_displayTerminalCarbonLabels_2D' is not in camel case. (camelcase)
(#54) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#54) Identifier 'atoms_useJMOLColors' is not in camel case. (camelcase)
(#55) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#55) Identifier 'bonds_clearOverlaps_2D' is not in camel case. (camelcase)
(#56) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#62) Missing space before opening brace. (space-before-blocks)
(#66) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#68) There should be no space after this paren. (space-in-parens)
(#73) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#82) Identifier 'function_resize' is not in camel case. (camelcase)
(#82) Operator '=' must be spaced. (space-infix-ops)
(#84) Identifier 'input_width' is not in camel case. (camelcase)
(#85) Identifier 'input_height' is not in camel case. (camelcase)
(#86) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#90) Expected space(s) after "if". (keyword-spacing)
(#90) Identifier 'input_width' is not in camel case. (camelcase)
(#90) There should be no space before this paren. (space-in-parens)
(#91) Identifier 'input_width' is not in camel case. (camelcase)
(#96) Expected space(s) after "if". (keyword-spacing)
(#96) Identifier 'input_height' is not in camel case. (camelcase)
(#96) There should be no space before this paren. (space-in-parens)
(#97) Identifier 'input_height' is not in camel case. (camelcase)
(#101) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#106) Operator '=' must be spaced. (space-infix-ops)
(#108) Identifier 'height_input' is not in camel case. (camelcase)
(#109) Identifier 'height_input' is not in camel case. (camelcase)
(#111) Identifier 'width_input' is not in camel case. (camelcase)
(#112) Identifier 'width_input' is not in camel case. (camelcase)
lib/editor/tiny/plugins/molstructure/amd/src/canvas3D.js
(#32) Operator '=' must be spaced. (space-infix-ops)
(#33) Operator '=' must be spaced. (space-infix-ops)
(#34) Operator '=' must be spaced. (space-infix-ops)
(#35) Operator '=' must be spaced. (space-infix-ops)
(#43) Missing space before value for key 'useServices'. (key-spacing)
(#47) Identifier 'atoms_useJMOLColors' is not in camel case. (camelcase)
(#47) Operator '=' must be spaced. (space-infix-ops)
(#49) Comments should not begin with a lowercase character. (capitalized-comments)
(#49) Expected space or tab after '/*' in comment. (spaced-comment)
(#58) Identifier 'sketcher_viewer_3D' is not in camel case. (camelcase)
(#60) Identifier 'sketcher_viewer_3D' is not in camel case. (camelcase)
(#61) Identifier 'sketcher_viewer_3D' is not in camel case. (camelcase)
(#62) Identifier 'sketcher_viewer_3D' is not in camel case. (camelcase)
(#63) Identifier 'sketcher_viewer_3D' is not in camel case. (camelcase)
(#63) Identifier 'atoms_useJMOLColors' is not in camel case. (camelcase)
(#63) Operator '=' must be spaced. (space-infix-ops)
(#64) Operator '=' must be spaced. (space-infix-ops)
(#70) Missing space before opening brace. (space-before-blocks)
(#74) Identifier 'sketcher_viewer_3D' is not in camel case. (camelcase)
(#86) Identifier 'function_resize' is not in camel case. (camelcase)
(#86) Operator '=' must be spaced. (space-infix-ops)
(#86) Identifier 'sketcher_viewer_3D' is not in camel case. (camelcase)
(#88) Identifier 'input_width' is not in camel case. (camelcase)
(#89) Identifier 'input_height' is not in camel case. (camelcase)
(#93) Expected space(s) after "if". (keyword-spacing)
(#93) Identifier 'input_width' is not in camel case. (camelcase)
(#93) There should be no space before this paren. (space-in-parens)
(#94) Identifier 'input_width' is not in camel case. (camelcase)
(#98) Expected space(s) after "if". (keyword-spacing)
(#98) Identifier 'input_height' is not in camel case. (camelcase)
(#98) There should be no space before this paren. (space-in-parens)
(#99) Identifier 'input_height' is not in camel case. (camelcase)
(#103) Identifier 'sketcher_viewer_3D' is not in camel case. (camelcase)
(#108) Operator '=' must be spaced. (space-infix-ops)
(#110) Identifier 'height_input' is not in camel case. (camelcase)
(#111) Identifier 'height_input' is not in camel case. (camelcase)
(#113) Identifier 'width_input' is not in camel case. (camelcase)
(#114) Identifier 'width_input' is not in camel case. (camelcase)
lib/editor/tiny/plugins/molstructure/amd/src/canvasSpectrum.js
(#32) Operator '=' must be spaced. (space-infix-ops)
(#33) Operator '=' must be spaced. (space-infix-ops)
(#39) Identifier 'plots_color' is not in camel case. (camelcase)
(#39) Operator '=' must be spaced. (space-infix-ops)
(#40) Identifier 'plots_width' is not in camel case. (camelcase)
(#40) Operator '=' must be spaced. (space-infix-ops)
(#41) Operator '=' must be spaced. (space-infix-ops)
(#42) Identifier 'text_font_size' is not in camel case. (camelcase)
(#67) Multiple spaces found before 'function_displaySVG'. (no-multi-spaces)
(#67) Identifier 'function_displaySVG' is not in camel case. (camelcase)
(#67) Operator '=' must be spaced. (space-infix-ops)
(#68) Multiple spaces found before 'iframeContent'. (no-multi-spaces)
(#79) Identifier 'function_insert' is not in camel case. (camelcase)
(#79) Operator '=' must be spaced. (space-infix-ops)
(#97) Identifier 'function_update' is not in camel case. (camelcase)
(#97) Operator '=' must be spaced. (space-infix-ops)
(#102) Identifier 'function_update_ketcher' is not in camel case. (camelcase)
(#102) Operator '=' must be spaced. (space-infix-ops)
(#107) Unexpected space before function parentheses. (space-before-function-paren)
(#126) Identifier 'plots_showIntegration' is not in camel case. (camelcase)
(#127) Identifier 'plots_flipXAxis' is not in camel case. (camelcase)
(#139) Multiple spaces found before 'getString'. (no-multi-spaces)
(#141) Comments should not begin with a lowercase character. (capitalized-comments)
(#141) Expected space or tab after '/*' in comment. (spaced-comment)
lib/editor/tiny/plugins/molstructure/amd/src/ketcher.js
(#34) Operator '+' must be spaced. (space-infix-ops)
(#48) Unexpected space before function parentheses. (space-before-function-paren)
(#49) There should be no space after this paren. (space-in-parens)
(#57) Extra space after key 'done'. (key-spacing)
lib/editor/tiny/plugins/molstructure/amd/src/plugin.js
(#36) Promise executor functions should not be async. (no-async-promise-executor)
lib/editor/tiny/plugins/molstructure/amd/src/ui.js
(#67) Missing space before opening brace. (space-before-blocks)
(#71) A space is required after ','. (comma-spacing)
(#109) Comments should not begin with a lowercase character. (capitalized-comments)
(#109) Expected space or tab after '/*' in comment. (spaced-comment)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(1 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

lib/editor/tiny/plugins/molstructure/templates/modal.mustache
(#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]