Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(1 errors, 13 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

lib/editor/tiny/plugins/molstructure/classes/external/image_generator.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
lib/editor/tiny/plugins/molstructure/classes/privacy/provider.php
(#38) There must not be a space before the colon in a return type declaration
lib/editor/tiny/plugins/molstructure/db/access.php
(#29) Short array syntax must be used to define arrays
(#31) Short array syntax must be used to define arrays
(#34) Short array syntax must be used to define arrays
lib/editor/tiny/plugins/molstructure/db/services.php
(#29) Short array syntax must be used to define arrays
(#30) Short array syntax must be used to define arrays
lib/editor/tiny/plugins/molstructure/lang/en/tiny_molstructure.php
(#28) The string key "buttontitle" is not in the correct order, it should be before "pluginname"
(#29) The string key "alreadyexistingfile" is not in the correct order, it should be before "buttontitle"
(#30) The string key "Xfilestored" is not in the correct order, it should be before "alreadyexistingfile"
(#32) The string key "insertimage" is not in the correct order, it should be before "unabletosaveXfile"
(#35) The string key "height" is not in the correct order, it should be before "resize"
(#37) The string key "dialogtitle" is not in the correct order, it should be before "width"
(#39) The string key "2Dcanvas" is not in the correct order, it should be before "instructions"

Javascript coding style problems

(0 errors, 49 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

lib/editor/tiny/plugins/molstructure/amd/src/canvas2D.js
(#32) Operator '=' must be spaced. (space-infix-ops)
(#33) Operator '=' must be spaced. (space-infix-ops)
(#34) Operator '=' must be spaced. (space-infix-ops)
(#35) Operator '=' must be spaced. (space-infix-ops)
(#38) ["H"] is better written in dot notation. (dot-notation)
(#39) ["S"] is better written in dot notation. (dot-notation)
(#42) Missing space before value for key 'useServices'. (key-spacing)
(#45) Identifier 'atoms_displayTerminalCarbonLabels_2D' is not in camel case. (camelcase)
(#46) Identifier 'atoms_useJMOLColors' is not in camel case. (camelcase)
(#47) Identifier 'bonds_clearOverlaps_2D' is not in camel case. (camelcase)
(#51) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#52) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#52) Identifier 'atoms_displayTerminalCarbonLabels_2D' is not in camel case. (camelcase)
(#53) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#53) Identifier 'atoms_useJMOLColors' is not in camel case. (camelcase)
(#54) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#54) Identifier 'bonds_clearOverlaps_2D' is not in camel case. (camelcase)
(#55) Comments should not begin with a lowercase character. (capitalized-comments)
(#55) Expected space or tab after '//' in comment. (spaced-comment)
(#56) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#61) Missing space before opening brace. (space-before-blocks)
(#63) Comments should not begin with a lowercase character. (capitalized-comments)
(#63) Expected space or tab after '//' in comment. (spaced-comment)
(#66) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#68) There should be no space after this paren. (space-in-parens)
(#72) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#81) Identifier 'function_resize' is not in camel case. (camelcase)
(#81) Operator '=' must be spaced. (space-infix-ops)
(#83) Identifier 'input_width' is not in camel case. (camelcase)
(#84) Identifier 'input_height' is not in camel case. (camelcase)
(#85) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#89) Expected space(s) after "if". (keyword-spacing)
(#89) Identifier 'input_width' is not in camel case. (camelcase)
(#89) There should be no space before this paren. (space-in-parens)
(#90) Identifier 'input_width' is not in camel case. (camelcase)
(#95) Expected space(s) after "if". (keyword-spacing)
(#95) Identifier 'input_height' is not in camel case. (camelcase)
(#95) There should be no space before this paren. (space-in-parens)
(#96) Identifier 'input_height' is not in camel case. (camelcase)
(#100) Identifier 'sketcher_viewer' is not in camel case. (camelcase)
(#105) Operator '=' must be spaced. (space-infix-ops)
(#107) Identifier 'height_input' is not in camel case. (camelcase)
(#108) Identifier 'height_input' is not in camel case. (camelcase)
(#110) Identifier 'width_input' is not in camel case. (camelcase)
(#111) Identifier 'width_input' is not in camel case. (camelcase)
lib/editor/tiny/plugins/molstructure/amd/src/ketcher.js
(#42) Unexpected space before function parentheses. (space-before-function-paren)
(#43) There should be no space after this paren. (space-in-parens)
(#51) Extra space after key 'done'. (key-spacing)
lib/editor/tiny/plugins/molstructure/amd/src/ui.js
(#62) Missing space before opening brace. (space-before-blocks)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "gherkinlint" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(1 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

lib/editor/tiny/plugins/molstructure/templates/modal.mustache
(#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error

Gherkin .feature problems

(1 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

lib/editor/tiny/plugins/molstructure/tests/behat/chemdoodle.feature
(#25) New line at EOF(end of file) is required