Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(82 errors, 19 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

theme/shoelace/classes/core_renderer.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#50) Variable "list_items" must not contain underscores.
(#53) Variable "list_items" must not contain underscores.
(#128) Line exceeds 132 characters; contains 138 characters
(#198) This comment is 67% valid code; is this commented out code?
(#206) Line exceeds 132 characters; contains 134 characters
(#216) Inline comments must start with a capital letter, digit or 3-dots sequence
(#227) Line exceeds 132 characters; contains 133 characters
(#260) Variable "anti_gravity" must not contain underscores.
(#260) Line exceeds 132 characters; contains 142 characters
(#262) Variable "anti_gravity" must not contain underscores.
theme/shoelace/classes/toolbox.php
(#30) Expected MOODLE_INTERNAL check or config.php inclusion
(#145) Line exceeds 132 characters; contains 133 characters
(#166) Visibility must be declared on method "get_html_for_settings"
theme/shoelace/config.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#92) Expected 1 space before "=>"; 0 found
(#92) Expected 1 space after "=>"; 0 found
(#99) Inline comments must start with a capital letter, digit or 3-dots sequence
(#99) Inline comments must end in full-stops, exclamation marks, or question marks
(#110) Expected 1 space before "=>"; 0 found
(#110) Expected 1 space after "=>"; 0 found
(#123) Expected 1 space before "=>"; 0 found
(#123) Expected 1 space after "=>"; 0 found
(#134) Expected 1 space before "=>"; 0 found
(#134) Expected 1 space after "=>"; 0 found
(#141) Expected 1 space before "=>"; 0 found
(#141) Expected 1 space after "=>"; 0 found
(#141) Expected 1 space before "=>"; 0 found
(#141) Expected 1 space after "=>"; 0 found
(#147) Expected 1 space before "=>"; 0 found
(#147) Expected 1 space after "=>"; 0 found
(#147) Expected 1 space before "=>"; 0 found
(#147) Expected 1 space after "=>"; 0 found
(#149) Inline comments must end in full-stops, exclamation marks, or question marks
(#160) Expected 1 space before "=>"; 0 found
(#160) Expected 1 space after "=>"; 0 found
(#160) Expected 1 space before "=>"; 0 found
(#160) Expected 1 space after "=>"; 0 found
(#160) Expected 1 space before "=>"; 0 found
(#160) Expected 1 space after "=>"; 0 found
(#160) Expected 1 space before "=>"; 0 found
(#160) Expected 1 space after "=>"; 0 found
(#166) Expected 1 space before "=>"; 0 found
(#166) Expected 1 space after "=>"; 0 found
(#166) Expected 1 space before "=>"; 0 found
(#166) Expected 1 space after "=>"; 0 found
theme/shoelace/db/upgrade.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
theme/shoelace/eyelet/classes/core_renderer.php
(#27) Expected MOODLE_INTERNAL check or config.php inclusion
theme/shoelace/eyelet/config.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
theme/shoelace/eyelet/layout/frontpage.php
(#30) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#63) Line indented incorrectly; expected 4 spaces, found 8
(#65) Line indented incorrectly; expected 4 spaces, found 8
theme/shoelace/eyelet/layout/tiles/footer.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#43) A closing tag is not permitted at the end of a PHP file
theme/shoelace/eyelet/layout/tiles/header.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
theme/shoelace/eyelet/lib.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion
(#37) Whitespace found at end of line
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
theme/shoelace/eyelet/version.php
(#33) This comment is 45% valid code; is this commented out code?
theme/shoelace/layout/columns1.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#39) Line indented incorrectly; expected 4 spaces, found 8
(#41) Line indented incorrectly; expected 4 spaces, found 8
theme/shoelace/layout/columns2.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#68) Line indented incorrectly; expected 4 spaces, found 8
(#70) Line indented incorrectly; expected 4 spaces, found 8
(#88) Expected "if (...) {\n"; found "if (...) { "
(#88) Closing brace must be on a line by itself
theme/shoelace/layout/columns3.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#80) Line indented incorrectly; expected 4 spaces, found 8
(#82) Line indented incorrectly; expected 4 spaces, found 8
theme/shoelace/layout/embedded.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#36) Line indented incorrectly; expected 4 spaces, found 8
(#38) Line indented incorrectly; expected 4 spaces, found 8
theme/shoelace/layout/frontpage.php
(#30) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#63) Line indented incorrectly; expected 4 spaces, found 8
(#65) Line indented incorrectly; expected 4 spaces, found 8
theme/shoelace/layout/maintenance.php
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
theme/shoelace/layout/popup.php
(#17) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#25) Line indented incorrectly; expected 4 spaces, found 8
(#27) Line indented incorrectly; expected 4 spaces, found 8
(#40) Line indented incorrectly; expected 0 spaces, found 4
(#40) Expected "if (...) {\n"; found "if(...) {\n"
(#43) Line indented incorrectly; expected 0 spaces, found 4
theme/shoelace/layout/secure.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#36) Line indented incorrectly; expected 4 spaces, found 8
(#38) Line indented incorrectly; expected 4 spaces, found 8
theme/shoelace/layout/tiles/cdn_fonts.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#26) Line indented incorrectly; expected 4 spaces, found 1
(#27) Line exceeds 132 characters; contains 147 characters
theme/shoelace/layout/tiles/footer.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#42) A closing tag is not permitted at the end of a PHP file
theme/shoelace/layout/tiles/footer_blocks.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#27) A closing tag is not permitted at the end of a PHP file
theme/shoelace/layout/tiles/header.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
theme/shoelace/layout/tiles/page-header.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
theme/shoelace/lib.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion
theme/shoelace/settings.php
(#83) Commas (,) must be followed by white space.
(#91) Commas (,) must be followed by white space.
(#105) Commas (,) must be followed by white space.
theme/shoelace/version.php
(#31) This comment is 45% valid code; is this commented out code?

Javascript coding style problems

(0 errors, 17 warnings)

This section shows the coding style problems detected in the code by jshint [More info]

theme/shoelace/Gruntfile.js
(#60) 'module' is not defined.
(#63) 'require' is not defined.
(#75) 'console' is not defined.
(#76) 'console' is not defined.
(#80) '__dirname' is not defined.
(#83) 'process' is not defined.
(#91) 'process' is not defined.
(#66) 'LESSDIR' is defined but never used.
(#67) 'MOODLEURLPREFIX' is defined but never used.
(#68) 'THEMEDIR' is defined but never used.
(#164) 'stderror' is defined but never used.
(#164) 'stdout' is defined but never used.
theme/shoelace/javascript/dock.js
(#10) 'customise_dock_for_theme' is defined but never used.
theme/shoelace/javascript/html5shiv.js
(#186) Missing 'new' prefix when invoking a constructor.
(#247) Line is too long.
theme/shoelace/javascript/shoelace.js
(#2) 'require' is not defined.
(#3) 'require' is not defined.

CSS problems

(3 errors, 0 warnings)

This section shows CSS problems detected by csslint [More info]

theme/shoelace/style/custom.css
(#35) Expected IDENT at line 35, col 2.
(#35) Expected IDENT at line 35, col 2.
theme/shoelace/style/font.css
(#28) @charset not allowed here.

PHPDocs style problems

(45 errors, 1 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

theme/shoelace/classes/core_renderer.php
(#30) Class theme_shoelace_core_renderer is not documented
(#36) Function theme_shoelace_core_renderer::navbar is not documented
(#238) Function theme_shoelace_core_renderer::gotobottom_menu is not documented
(#243) Function theme_shoelace_core_renderer::render_gotobottom_menu is not documented
(#258) Function theme_shoelace_core_renderer::anti_gravity is not documented
(#20) Package theme is not valid
theme/shoelace/classes/toolbox.php
(#30) Class toolbox is not documented
(#32) Variable toolbox::$theme is not documented
(#160) Phpdocs for function toolbox::get_html_for_settings has incomplete parameters list
(#20) Package theme is not valid
theme/shoelace/config.php
(#20) Package theme is not valid
theme/shoelace/db/upgrade.php
(#2) Empty line found after PHP open tag
(#29) Function xmldb_theme_shoelace_upgrade is not documented
(#21) Package theme is not valid
theme/shoelace/eyelet/classes/core_renderer.php
(#17) File-level phpdocs block is not found
(#20) Package theme is not valid
theme/shoelace/eyelet/config.php
(#20) Package theme is not valid
theme/shoelace/eyelet/lang/en/theme_eyelet.php
(#20) Package theme is not valid
theme/shoelace/eyelet/layout/frontpage.php
(#20) Package theme is not valid
theme/shoelace/eyelet/layout/tiles/footer.php
(#20) Package theme is not valid
theme/shoelace/eyelet/layout/tiles/header.php
(#20) Package theme is not valid
theme/shoelace/eyelet/lib.php
(#28) Function theme_eyelet_process_css is not documented
(#20) Package theme is not valid
theme/shoelace/eyelet/settings.php
(#20) Package theme is not valid
theme/shoelace/eyelet/version.php
(#20) Package theme is not valid
theme/shoelace/lang/en/theme_shoelace.php
(#20) Package theme is not valid
theme/shoelace/layout/columns1.php
(#20) Package theme is not valid
theme/shoelace/layout/columns2.php
(#20) Package theme is not valid
theme/shoelace/layout/columns3.php
(#20) Package theme is not valid
theme/shoelace/layout/embedded.php
(#20) Package theme is not valid
theme/shoelace/layout/frontpage.php
(#20) Package theme is not valid
theme/shoelace/layout/maintenance.php
(#17) File-level phpdocs block does not have @copyright tag
(#17) File-level phpdocs block does not have @license tag
theme/shoelace/layout/popup.php
(#17) File-level phpdocs block is not found
theme/shoelace/layout/secure.php
(#20) Package theme is not valid
theme/shoelace/layout/tiles/cdn_fonts.php
(#20) Package theme is not valid
theme/shoelace/layout/tiles/footer.php
(#20) Package theme is not valid
theme/shoelace/layout/tiles/footer_blocks.php
(#20) Package theme is not valid
theme/shoelace/layout/tiles/header.php
(#20) Package theme is not valid
theme/shoelace/layout/tiles/page-header.php
(#20) Package theme is not valid
theme/shoelace/lib.php
(#28) Function theme_shoelace_process_css is not documented
(#44) Function theme_shoelace_set_logo is not documented
(#57) Function theme_shoelace_set_customcss is not documented
(#20) Package theme is not valid
theme/shoelace/settings.php
(#20) Package theme is not valid
theme/shoelace/version.php
(#20) Package theme is not valid

Update savepoints problems

(2 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

theme/shoelace/db/upgrade.php
Detected more 'if' blocks (1) than 'savepoint' calls (0)
version 2014022400 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]