Comments

• 

  Anthony Borrow

  Tue, 10 Sept 2013, 10:37 AM

  Gareth - Many thanks for sharing this theme with the Moodle community. Most things look good but I have two concerns. The first is whether the otf files are GPL licensed or not. The second issue is also a licensing issue as it appears that there is a BSD licensed file which is unfortunately not compatible with GPL - see http://directory.fsf.org/wiki/License:BSD_4Clause for more information. The file in question is /mutant_banjo/javascript/jquery.bxslider/plugins/. You may need to find something else or rework things a little to make sure everything is GPL compatible. I'm going to mark this as needing more work until you can tidy up the licensing concerns and confirm that everything in the theme is GPL compatible. Please do not hesitate to let me know if there is anything I can do to be supportive of your efforts. Peace - Anthony
• 

  Gareth J Barnard

  Tue, 10 Sept 2013, 7:58 PM

  Hi Anthony,
  
  Thank you for reviewing my theme so soon . I believe I have sorted out the license issues as follows:
  
  BSD:
  
  The BSD licence used in the file 'jquery.easing.1.3.js' (the other one 'jquery.fitvids.js' has the WTFPL license - http://www.wtfpl.net/ - using a word I don't really like) is the revised 3 clause BSD license - http://opensource.org/licenses/BSD-3-Clause - which according to http://www.gnu.org/licenses/license-list.html#ModifiedBSD is compatible with GNU GPL.
  
  Fonts:
  
  Fonts with the GNU GPL are treated differently - http://www.gnu.org/licenses/gpl-faq.html#FontException - so even though I thought they would be ok with the SIL Open Font License - http://opensource.org/licenses/OFL-1.1 - I previously contacted GNU to ask, and this was their reply:
  
  "
  [gnu.org #804047] Re: SIL Open Font License 1.1 compatibility.
  
  Hello,
  
  Please accept our apologies for the delay in getting back to you. We
  rely on volunteer effort and often have difficulties keeping up with
  the demand for our expertise.
  
  > I have a GPLv3 program with a sub-folder containing fonts that are
  > licensed under the SIL Open Font License 1.1 -
  > http://scripts.sil.org/OFL. Are the two compatible and do I need to
  > add the font exception
  > http://www.gnu.org/licenses/gpl-faq.html#FontException ?
  
  Based on your description you would be creating an aggregate, and not a
  combined work
  (http://www.gnu.org/licenses/gpl-faq.html#MereAggregation). Therefore
  you can use the fonts in question without adding an exception.
  
  If you have further questions please feel free to write back and I'll do
  my best to expedite my reply.
  
  --
  I am not a lawyer, the above is not legal advice
  
  Regards, Yoni Rabkin
  "
  
  So therefore in my opinion I consider to be ok with GPLv3.
  
  Cheers,
  
  Gareth
• 

  Gareth J Barnard

  Tue, 10 Sept 2013, 7:59 PM

  P.S. The date / time of the GNU reply was 24 July 2013 16:31.
• 

  Gareth J Barnard

  Tue, 10 Sept 2013, 8:00 PM

  P.P.S.
  
  I've included the SIL OFL license for each font with the fonts in their folder.
  
  I'm quite willing to add more information to the Readme.md file if this helps.
  
  Cheers,
  
  Gareth
• 

  Anthony Borrow

  Tue, 10 Sept 2013, 11:36 PM

  Gareth - I appreciate your work at tracking down and verifying the GPL compatibility of the licenses. Licensing can be one of the more tricky parts of reviewing plugins. I'm going to go ahead and approve this theme. Peace - Anthony
• 

  fei xi

  Fri, 13 Sept 2013, 2:55 PM

  I am a newer with themes, I try this one today,but find
  
  --------------------------------------------------------------------
  Notice: Undefined property: stdClass::$colourswatch in D:\xampp\htdocs\moodle\theme\mutant_banjo\config.php on line 32
  
  Notice: Undefined property: stdClass::$colourswatch in D:\xampp\htdocs\moodle\theme\mutant_banjo\config.php on line 32
  -------------------------------------------------------------------------
  
  the theme doesn't success,I want help!
• 

  Gareth J Barnard

  Fri, 13 Sept 2013, 6:16 PM

  Hi fei xi,
  
  The error is because the settings have not been created. They are created as a part of the installation. Did you follow the 'Installation' instructions in 'Readme.md' and perform "'Site administration' -> 'Notifications'"?
  
  What version of Moodle are you using?
  
  Gareth
• 

  fei xi

  Sat, 14 Sept 2013, 12:19 PM

  Thank you,I fix it!