Prechecker results: error


Overview

(1 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

The patchset contains changes to upgrade.txt or UPGRADING.md files.

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(7 errors, 65 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

public/theme/moove/classes/output/core/question_renderer.php
(#1) DocBlock missing a @package tag for file question_renderer.php. Expected @package theme_moove
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#43) DocBlock missing a @package tag for class question_renderer. Expected @package theme_moove
(#114) The closing parenthesis of a multi-line function declaration must be on a new line
(#201) Only one argument is allowed per line in a multi-line function call
public/theme/moove/classes/output/core_renderer.php
(#488) Expected 1 space after SWITCH keyword; 0 found
(#489) There must be no space before the colon in a CASE statement
public/theme/moove/lang/en/theme_moove.php
(#28) The string key "configtitle" is not in the correct order, it should be before "pluginname"
(#29) The string key "choosereadme" is not in the correct order, it should be before "configtitle"
(#33) The string key "prev_section" is not in the correct order, it should be before "region-side-pre"
(#34) The string key "next_section" is not in the correct order, it should be before "prev_section"
(#37) The string key "needsupport" is not in the correct order, it should be before "themedevelopedbyconectimepartner"
(#39) The string key "access" is not in the correct order, it should be before "pleasuretohelp"
(#41) The string key "next_activity" is not in the correct order, it should be before "prev_activity"
(#42) The string key "donthaveanaccount" is not in the correct order, it should be before "next_activity"
(#45) Unexpected comment found. Auto-fixing will not work after this comment
(#46) The string key "generalsettings" is not in the correct order, it should be before "signinwith"
(#49) The string key "favicon" is not in the correct order, it should be before "logodesc"
(#55) The string key "loginbgimg" is not in the correct order, it should be before "presetfiles_desc"
(#57) The string key "brandcolor" is not in the correct order, it should be before "loginbgimg_desc"
(#61) The string key "navbarbg" is not in the correct order, it should be before "secondarymenucolor_desc"
(#65) The string key "fontsite" is not in the correct order, it should be before "navbarbghover_desc"
(#67) The string key "enablecourseindex" is not in the correct order, it should be before "fontsite_desc"
(#69) The string key "enableclassicbreadcrumb" is not in the correct order, it should be before "enablecourseindex_desc"
(#72) Unexpected comment found. Auto-fixing will not work after this comment
(#73) The string key "advancedsettings" is not in the correct order, it should be before "enableclassicbreadcrumb_desc"
(#76) The string key "rawscss" is not in the correct order, it should be before "rawscsspre_desc"
(#78) The string key "googleanalytics" is not in the correct order, it should be before "rawscss_desc"
(#83) Unexpected comment found. Auto-fixing will not work after this comment
(#84) The string key "frontpagesettings" is not in the correct order, it should be before "hvpcss_desc"
(#85) The string key "displaymarketingboxes" is not in the correct order, it should be before "frontpagesettings"
(#88) The string key "marketingsectioncontent" is not in the correct order, it should be before "marketingsectionheading"
(#89) The string key "marketingicon" is not in the correct order, it should be before "marketingsectioncontent"
(#90) The string key "marketingheading" is not in the correct order, it should be before "marketingicon"
(#91) The string key "marketingcontent" is not in the correct order, it should be before "marketingheading"
(#93) The string key "disableteacherspic" is not in the correct order, it should be before "marketingcontent"
(#98) The string key "slidercount" is not in the correct order, it should be before "sliderfrontpageloggedindesc"
(#104) The string key "slidercaption" is not in the correct order, it should be before "slidertitledesc"
(#107) The string key "numbersfrontpage" is not in the correct order, it should be before "slidercaptiondesc"
(#109) The string key "numbersfrontpagecontent" is not in the correct order, it should be before "numbersfrontpagedesc"
(#111) The string key "numbersfrontpagecontentdefault" is not in the correct order, it should be before "numbersfrontpagecontentdesc"
(#116) The string key "numberscourses" is not in the correct order, it should be before "numbersusers"
(#118) The string key "faq" is not in the correct order, it should be before "numberscourses"
(#122) The string key "faqanswer" is not in the correct order, it should be before "faqquestion"
(#124) Unexpected comment found. Auto-fixing will not work after this comment
(#128) The string key "mobile" is not in the correct order, it should be before "websitedesc"
(#130) The string key "mail" is not in the correct order, it should be before "mobiledesc"
(#134) The string key "facebook" is not in the correct order, it should be before "tiktokdesc"
(#138) The string key "linkedin" is not in the correct order, it should be before "twitterdesc"
(#142) The string key "instagram" is not in the correct order, it should be before "youtubedesc"
(#148) The string key "telegram" is not in the correct order, it should be before "whatsappdesc"
(#150) The string key "contactus" is not in the correct order, it should be before "telegramdesc"
(#153) Unexpected comment found. Auto-fixing will not work after this comment
(#154) The string key "aboutme" is not in the correct order, it should be before "followus"
(#156) The string key "addcontact" is not in the correct order, it should be before "personalinformation"
(#159) Unexpected comment found. Auto-fixing will not work after this comment
(#162) The string key "themesettings:defaultfont" is not in the correct order, it should be before "themesettings:fonttype"
(#165) The string key "themesettingg:successfullysaved" is not in the correct order, it should be before "themesettings:enableaccessibilitytoolbar"
(#167) Unexpected comment found. Auto-fixing will not work after this comment
(#168) The string key "accessibility:fontsize" is not in the correct order, it should be before "themesettingg:successfullysaved"
(#169) The string key "accessibility:decreasefont" is not in the correct order, it should be before "accessibility:fontsize"
(#171) The string key "accessibility:increasefont" is not in the correct order, it should be before "accessibility:resetfont"
(#173) The string key "accessibility:resetsitecolor" is not in the correct order, it should be before "accessibility:sitecolor"
(#178) Unexpected comment found. Auto-fixing will not work after this comment
(#182) The string key "privacy:metadata:preference:thememoovesettings_enableaccessibilitytoolbar" is not in the correct order, it should be before "privacy:metadata:preference:thememoovesettings_fonttype"
(#184) The string key "privacy:accessibilitystyles_fontsizeclass" is not in the correct order, it should be before "privacy:metadata:preference:thememoovesettings_enableaccessibilitytoolbar"
(#187) The string key "privacy:thememoovesettings_enableaccessibilitytoolbar" is not in the correct order, it should be before "privacy:thememoovesettings_fonttype"
(#190) The string key "redirectbtntext" is not in the correct order, it should be before "redirectmessage"
(#192) The string key "ourpartners" is not in the correct order, it should be before "redirectbtntext"
(#196) The string key "readspeaker_link" is not in the correct order, it should be before "readspeaker_text"
(#198) The string key "darkmodesettings" is not in the correct order, it should be before "readspeaker_link"
(#199) The string key "darkmode_enable" is not in the correct order, it should be before "darkmodesettings"

Javascript coding style problems

(0 errors, 5 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

public/theme/moove/amd/src/mylearning.js
(#130) Expected to return a value at the end of function. (consistent-return)
(#149) Comments should not begin with a lowercase character. (capitalized-comments)
(#149) Expected space or tab after '//' in comment. (spaced-comment)
(#150) The function binding is unnecessary. (no-extra-bind)
(#173) The function binding is unnecessary. (no-extra-bind)

CSS problems

(4 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

public/theme/moove/style/moodle.css
(#28818) "declaration-no-important" has already been disabled (CssSyntaxError)
public/theme/moove/scss/moove/_accessibilitystyles.scss
(#36) Unknown word (CssSyntaxError)
public/theme/moove/scss/moove/_general.scss
(#151) Unknown word (CssSyntaxError)
public/theme/moove/scss/moove/darkandlightvariables.scss
(#8) Unknown word (CssSyntaxError)

PHPDocs style problems

(1 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

public/theme/moove/classes/util/mylearning.php
(#33) Phpdocs for function mylearning::get_last_accessed_courses has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 19 warnings)

This section shows problems detected in mustache templates [More info]

public/theme/moove/templates/block_myoverview/view-cards.mustache
(#1) HTML Validation error, line 67: No space between attributes. ( <i class="icon fa fa-ellipsis-v fa-fw m-0" title="((+aria%3Acourseactions%2C+block_myoverview+)) Course 3 for "Statist)
(#1) HTML Validation error, line 67: Quote “"” in attribute name. Probable cause: Matching quote missing somewhere earlier. (e 3 for "Statistical and Computational Tools" " ari)
(#1) HTML Validation error, line 67: Quote “"” in attribute name. Probable cause: Matching quote missing somewhere earlier. (nal Tools" " aria-)
(#1) HTML Validation info, line 67: Attribute “tools"” is not serializable as XML 1.0. (l Tools" " aria-hidden="true"></i> )
(#1) HTML Validation info, line 67: Attribute “"” is not serializable as XML 1.0. (l Tools" " aria-hidden="true"></i> )
(#1) HTML Validation error, line 67: Attribute “statistical” not allowed on element “i” at this point. (l Tools" " aria-hidden="true"></i> )
(#1) HTML Validation error, line 67: Attribute “and” not allowed on element “i” at this point. (l Tools" " aria-hidden="true"></i> )
(#1) HTML Validation error, line 67: Attribute “computational” not allowed on element “i” at this point. (l Tools" " aria-hidden="true"></i> )
(#1) HTML Validation error, line 67: Attribute “tools"” not allowed on element “i” at this point. (l Tools" " aria-hidden="true"></i> )
(#1) HTML Validation error, line 67: Attribute “"” not allowed on element “i” at this point. (l Tools" " aria-hidden="true"></i> )
public/theme/moove/templates/core/loginform.mustache
(#1) HTML Validation info, line 47: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="username" value="guest" /> )
(#1) HTML Validation info, line 48: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="password" value="guest" /> )
(#1) ESLint did not run
public/theme/moove/templates/core/user_menu.mustache
(#1) ESLint did not run
public/theme/moove/templates/core_course/activity_navigation.mustache
(#1) HTML Validation error, line 19: Bad value “” for attribute “id” on element “form”: An ID must not be the empty string. (s=""> <form method="post" action="#" class="d-flex flex-wrap align-items-center" id=""> )
(#1) ESLint did not run
public/theme/moove/templates/drawer.mustache
(#1) HTML Validation error, line 2: Bad value “” for attribute “id” on element “div”: An ID must not be the empty string. (ad><body><div class=" d-print-none not-initialized" data-region="fixed-drawer" id="" data-preference="" data-state="" data-forceopen="0" data-close-on-resize="0"> <)
(#1) ESLint did not run
public/theme/moove/templates/drawers.mustache
(#1) HTML Validation info, line 5: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (itle> <link rel="shortcut icon" href="favicon.ico" /> )
(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (TYPE html><html ><head)
(#1) ESLint did not run
public/theme/moove/templates/footer.mustache
(#1) ESLint did not run
public/theme/moove/templates/frontpage.mustache
(#1) HTML Validation info, line 5: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (itle> <link rel="shortcut icon" href="favicon.ico" /> )
(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (TYPE html><html ><head)
(#1) ESLint did not run
public/theme/moove/templates/login.mustache
(#1) HTML Validation info, line 5: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (itle> <link rel="shortcut icon" href="favicon.ico" /> )
(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (TYPE html><html ><head)
(#1) ESLint did not run
public/theme/moove/templates/moove/accessibilitybar.mustache
(#1) ESLint did not run
public/theme/moove/templates/moove/conectime_partners_banner.mustache
(#1) Example context missing (@template section not found.)
public/theme/moove/templates/moove/conectime_services_and_support_content_banner.mustache
(#1) Example context missing (@template section not found.)
public/theme/moove/templates/moove/coursecard.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 2: An element with “role=listitem” must be contained in, or owned by, an element with “role=list” or “role=group”. (ad><body><div class="card dashboard-card dimmed" role="listitem" data-region="course-content" data-course-id=""> <)
public/theme/moove/templates/moove/darkmode.mustache
(#1) Example context missing (@template section not found.)
(#1) ESLint did not run
public/theme/moove/templates/moove/loginfooter.mustache
(#1) ESLint did not run
public/theme/moove/templates/moove/mylearning.mustache
(#1) Example context missing (@template section not found.)
(#1) ESLint did not run
public/theme/moove/templates/moove/mylearning_course.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 2: An element with “role=listitem” must be contained in, or owned by, an element with “role=list” or “role=group”. (ad><body><div class="content-item-container mylearning" data-region="mylearning-content-item-container" data-id="" role="listitem"> <)
(#1) HTML Validation error, line 6: Bad value “” for attribute “src” on element “img”: Must be non-empty. ( <img src="" alt=""> )
public/theme/moove/templates/navbar.mustache
(#1) ESLint did not run

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]