Overview

(1 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

: The patchset contains changes to upgrade.txt or UPGRADING.md files.

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(139 errors, 68 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

theme/moove/classes/core_h5p_renderer.php: (#62) Opening parenthesis of a multi-line function call must be the last content on the line; (#63) Multi-line function call not indented correctly; expected 8 spaces but found 12; (#63) Closing parenthesis of a multi-line function call must be on a line by itself
theme/moove/classes/mod_hvp_renderer.php: (#62) Opening parenthesis of a multi-line function call must be the last content on the line; (#63) Multi-line function call not indented correctly; expected 8 spaces but found 12; (#63) Closing parenthesis of a multi-line function call must be on a line by itself
theme/moove/classes/output/boostnavbar.php: (#29) Incorrect @package tag for class boostnavbar. Expected theme_moove, found theme_boost.; (#33) Opening brace must not be followed by a blank line; (#97) There must be a comment when fall-through is intentional in a non-empty case body; (#103) There must be a comment when fall-through is intentional in a non-empty case body; (#117) Empty FOREACH statement detected; (#119) Inline comments must end in full-stops, exclamation marks, or question marks; (#119) Line indented incorrectly; expected at least 16 spaces, found 0; (#119) Expected 1 space before comment text but found 16; use block comment if you need indentation; (#264) The first expression of a multi-line control structure must be on the line after the opening parenthesis; (#265) The closing parenthesis of a multi-line control structure must be on the line after the last expression; (#285) Long list syntax is not allowed; (#293) Long list syntax is not allowed; (#295) The first expression of a multi-line control structure must be on the line after the opening parenthesis; (#296) The closing parenthesis of a multi-line control structure must be on the line after the last expression; (#311) Expected 1 space after FUNCTION keyword; 0 found; (#312) Long list syntax is not allowed
theme/moove/classes/output/core/admin_renderer.php: (#100) Line exceeds 132 characters; contains 134 characters; (#119) Inline comments must start with a capital letter, digit or 3-dots sequence; (#119) This comment is 73% valid code; is this commented out code?; (#122) 98 slashes comments are not allowed; use "// Comment." instead; (#123) Inline comments must end in full-stops, exclamation marks, or question marks; (#123) 4 slashes comments are not allowed; use "// Comment." instead; (#123) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#125) 98 slashes comments are not allowed; use "// Comment." instead; (#125) Blank comments are not allowed
theme/moove/classes/output/core/course_renderer.php: (#86) Opening parenthesis of a multi-line function call must be the last content on the line; (#86) Only one argument is allowed per line in a multi-line function call; (#86) Only one argument is allowed per line in a multi-line function call; (#87) Multi-line function call not indented correctly; expected 16 spaces but found 20; (#87) Closing parenthesis of a multi-line function call must be on a line by itself; (#89) Opening parenthesis of a multi-line function call must be the last content on the line; (#90) Multi-line function call not indented correctly; expected 20 spaces but found 24; (#90) Closing parenthesis of a multi-line function call must be on a line by itself; (#103) Opening parenthesis of a multi-line function call must be the last content on the line; (#104) Opening parenthesis of a multi-line function call must be the last content on the line; (#105) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#105) Closing parenthesis of a multi-line function call must be on a line by itself; (#105) Only one argument is allowed per line in a multi-line function call; (#105) Closing parenthesis of a multi-line function call must be on a line by itself; (#126) Expected no spaces between $coursecount and the increment operator; 1 found
theme/moove/classes/output/core_course/activity_navigation.php: (#37) Opening brace must not be followed by a blank line
theme/moove/classes/output/core_renderer.php: (#119) Expected at least 1 space before "."; 0 found; (#119) Expected at least 1 space before "."; 0 found; (#119) Expected at least 1 space after "."; 0 found; (#119) Expected at least 1 space before "."; 0 found; (#119) Expected at least 1 space after "."; 0 found; (#119) Expected at least 1 space before "."; 0 found; (#119) Expected at least 1 space after "."; 0 found; (#191) Opening parenthesis of a multi-line function call must be the last content on the line; (#191) Only one argument is allowed per line in a multi-line function call; (#192) Multi-line function call not indented correctly; expected 8 spaces but found 12; (#192) Closing parenthesis of a multi-line function call must be on a line by itself; (#231) The first expression of a multi-line control structure must be on the line after the opening parenthesis; (#233) The closing parenthesis of a multi-line control structure must be on the line after the last expression; (#358) The first expression of a multi-line control structure must be on the line after the opening parenthesis; (#359) The closing parenthesis of a multi-line control structure must be on the line after the last expression; (#502) The first parameter of a multi-line function declaration must be on the line after the opening bracket; (#502) Multi-line function declarations must define one parameter per line; (#502) Multi-line function declarations must define one parameter per line; (#502) Multi-line function declarations must define one parameter per line; (#503) Multi-line function declaration not indented correctly; expected 8 spaces but found 37; (#503) The closing parenthesis of a multi-line function declaration must be on a new line; (#507) There must be no space before the colon in a CASE statement; (#511) Expected at least 1 space before "."; 0 found; (#511) Expected at least 1 space after "."; 0 found; (#511) Expected at least 1 space before "."; 0 found; (#511) Expected at least 1 space after "."; 0 found; (#511) Expected at least 1 space before "."; 0 found; (#511) Expected at least 1 space after "."; 0 found; (#516) There must be no space before the colon in a CASE statement; (#520) There must be no space before the colon in a CASE statement; (#528) There must be no space before the colon in a CASE statement; (#539) Expected at least 1 space before "."; 0 found; (#539) Expected at least 1 space after "."; 0 found; (#539) Expected at least 1 space before "."; 0 found; (#539) Expected at least 1 space after "."; 0 found
theme/moove/classes/privacy/provider.php: (#43) Opening brace must not be followed by a blank line
theme/moove/classes/util/course.php: (#65) Opening parenthesis of a multi-line function call must be the last content on the line; (#67) Multi-line function call not indented correctly; expected 16 spaces but found 20; (#67) Only one argument is allowed per line in a multi-line function call; (#67) Closing parenthesis of a multi-line function call must be on a line by itself; (#128) Opening parenthesis of a multi-line function call must be the last content on the line
theme/moove/classes/util/extras.php: (#143) The first expression of a multi-line control structure must be on the line after the opening parenthesis; (#143) Opening parenthesis of a multi-line function call must be the last content on the line; (#144) Multi-line function call not indented correctly; expected 12 spaces but found 20; (#144) Closing parenthesis of a multi-line function call must be on a line by itself; (#144) The closing parenthesis of a multi-line control structure must be on the line after the last expression; (#145) Opening parenthesis of a multi-line function call must be the last content on the line; (#150) The first expression of a multi-line control structure must be on the line after the opening parenthesis; (#151) The closing parenthesis of a multi-line control structure must be on the line after the last expression
theme/moove/config.php: (#34) Expected 1 space after FUNCTION keyword; 0 found
theme/moove/db/install.php: (#53) Expected 1 blank line at end of file; 3 found
theme/moove/lang/en/theme_moove.php: (#28) The string key "configtitle" is not in the correct order, it should be before "pluginname"; (#29) The string key "choosereadme" is not in the correct order, it should be before "configtitle"; (#33) The string key "prev_section" is not in the correct order, it should be before "region-side-pre"; (#34) The string key "next_section" is not in the correct order, it should be before "prev_section"; (#37) The string key "needsupport" is not in the correct order, it should be before "themedevelopedbyconectimepartner"; (#39) The string key "access" is not in the correct order, it should be before "pleasuretohelp"; (#41) The string key "next_activity" is not in the correct order, it should be before "prev_activity"; (#42) The string key "donthaveanaccount" is not in the correct order, it should be before "next_activity"; (#45) Unexpected comment found. Auto-fixing will not work after this comment; (#46) The string key "generalsettings" is not in the correct order, it should be before "signinwith"; (#49) The string key "favicon" is not in the correct order, it should be before "logodesc"; (#55) The string key "loginbgimg" is not in the correct order, it should be before "presetfiles_desc"; (#57) The string key "brandcolor" is not in the correct order, it should be before "loginbgimg_desc"; (#61) The string key "navbarbg" is not in the correct order, it should be before "secondarymenucolor_desc"; (#65) The string key "fontsite" is not in the correct order, it should be before "navbarbghover_desc"; (#67) The string key "enablecourseindex" is not in the correct order, it should be before "fontsite_desc"; (#69) The string key "enableclassicbreadcrumb" is not in the correct order, it should be before "enablecourseindex_desc"; (#72) Unexpected comment found. Auto-fixing will not work after this comment; (#73) The string key "advancedsettings" is not in the correct order, it should be before "enableclassicbreadcrumb_desc"; (#76) The string key "rawscss" is not in the correct order, it should be before "rawscsspre_desc"; (#78) The string key "googleanalytics" is not in the correct order, it should be before "rawscss_desc"; (#83) Unexpected comment found. Auto-fixing will not work after this comment; (#84) The string key "frontpagesettings" is not in the correct order, it should be before "hvpcss_desc"; (#85) The string key "displaymarketingboxes" is not in the correct order, it should be before "frontpagesettings"; (#88) The string key "marketingsectioncontent" is not in the correct order, it should be before "marketingsectionheading"; (#89) The string key "marketingicon" is not in the correct order, it should be before "marketingsectioncontent"; (#90) The string key "marketingheading" is not in the correct order, it should be before "marketingicon"; (#91) The string key "marketingcontent" is not in the correct order, it should be before "marketingheading"; (#93) The string key "disableteacherspic" is not in the correct order, it should be before "marketingcontent"; (#98) The string key "slidercount" is not in the correct order, it should be before "sliderfrontpageloggedindesc"; (#104) The string key "slidercaption" is not in the correct order, it should be before "slidertitledesc"; (#107) The string key "numbersfrontpage" is not in the correct order, it should be before "slidercaptiondesc"; (#109) The string key "numbersfrontpagecontent" is not in the correct order, it should be before "numbersfrontpagedesc"; (#111) The string key "numbersfrontpagecontentdefault" is not in the correct order, it should be before "numbersfrontpagecontentdesc"; (#116) The string key "numberscourses" is not in the correct order, it should be before "numbersusers"; (#118) The string key "faq" is not in the correct order, it should be before "numberscourses"; (#122) The string key "faqanswer" is not in the correct order, it should be before "faqquestion"; (#124) Unexpected comment found. Auto-fixing will not work after this comment; (#128) The string key "mobile" is not in the correct order, it should be before "websitedesc"; (#130) The string key "mail" is not in the correct order, it should be before "mobiledesc"; (#132) The string key "facebook" is not in the correct order, it should be before "maildesc"; (#136) The string key "linkedin" is not in the correct order, it should be before "twitterdesc"; (#140) The string key "instagram" is not in the correct order, it should be before "youtubedesc"; (#144) The string key "telegram" is not in the correct order, it should be before "whatsappdesc"; (#146) The string key "contactus" is not in the correct order, it should be before "telegramdesc"; (#149) Unexpected comment found. Auto-fixing will not work after this comment; (#150) The string key "aboutme" is not in the correct order, it should be before "followus"; (#152) The string key "addcontact" is not in the correct order, it should be before "personalinformation"; (#155) Unexpected comment found. Auto-fixing will not work after this comment; (#158) The string key "themesettings:defaultfont" is not in the correct order, it should be before "themesettings:fonttype"; (#161) The string key "themesettingg:successfullysaved" is not in the correct order, it should be before "themesettings:enableaccessibilitytoolbar"; (#163) Unexpected comment found. Auto-fixing will not work after this comment; (#164) The string key "accessibility:fontsize" is not in the correct order, it should be before "themesettingg:successfullysaved"; (#165) The string key "accessibility:decreasefont" is not in the correct order, it should be before "accessibility:fontsize"; (#167) The string key "accessibility:increasefont" is not in the correct order, it should be before "accessibility:resetfont"; (#169) The string key "accessibility:resetsitecolor" is not in the correct order, it should be before "accessibility:sitecolor"; (#174) Unexpected comment found. Auto-fixing will not work after this comment; (#178) The string key "privacy:metadata:preference:thememoovesettings_enableaccessibilitytoolbar" is not in the correct order, it should be before "privacy:metadata:preference:thememoovesettings_fonttype"; (#180) The string key "privacy:accessibilitystyles_fontsizeclass" is not in the correct order, it should be before "privacy:metadata:preference:thememoovesettings_enableaccessibilitytoolbar"; (#183) The string key "privacy:thememoovesettings_enableaccessibilitytoolbar" is not in the correct order, it should be before "privacy:thememoovesettings_fonttype"; (#186) The string key "redirectbtntext" is not in the correct order, it should be before "redirectmessage"
theme/moove/lib.php: (#115) Expected 1 space after FUNCTION keyword; 0 found; (#117) Expected at least 1 space after "."; 0 found; (#158) The first expression of a multi-line control structure must be on the line after the opening parenthesis; (#159) The closing parenthesis of a multi-line control structure must be on the line after the last expression; (#206) Expected at least 1 space before "."; 0 found; (#206) Expected at least 1 space after "."; 0 found; (#206) This comment is 50% valid code; is this commented out code?; (#233) Expected at least 1 space before "."; 0 found; (#233) Expected at least 1 space after "."; 0 found; (#233) Expected at least 1 space before "."; 0 found; (#233) Expected at least 1 space after "."; 0 found; (#234) Expected at least 1 space before "."; 0 found; (#234) Expected at least 1 space after "."; 0 found; (#234) Expected at least 1 space before "."; 0 found; (#234) Expected at least 1 space after "."; 0 found; (#235) Expected at least 1 space before "."; 0 found; (#235) Expected at least 1 space after "."; 0 found; (#235) Expected at least 1 space before "."; 0 found; (#235) Expected at least 1 space after "."; 0 found; (#236) Expected at least 1 space before "."; 0 found; (#236) Expected at least 1 space after "."; 0 found; (#236) Expected at least 1 space before "."; 0 found; (#236) Expected at least 1 space after "."; 0 found; (#238) Expected at least 1 space before "."; 0 found; (#238) Expected at least 1 space after "."; 0 found; (#242) Expected at least 1 space before "."; 0 found; (#242) Expected at least 1 space after "."; 0 found
theme/moove/settings.php: (#30) Blank line found at start of control structure; (#85) Opening parenthesis of a multi-line function call must be the last content on the line; (#85) Only one argument is allowed per line in a multi-line function call; (#85) Only one argument is allowed per line in a multi-line function call; (#85) Only one argument is allowed per line in a multi-line function call; (#85) Only one argument is allowed per line in a multi-line function call; (#86) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#86) Closing parenthesis of a multi-line function call must be on a line by itself; (#168) Opening parenthesis of a multi-line function call must be the last content on the line; (#169) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#169) Only one argument is allowed per line in a multi-line function call; (#169) Only one argument is allowed per line in a multi-line function call; (#169) Only one argument is allowed per line in a multi-line function call; (#169) Closing parenthesis of a multi-line function call must be on a line by itself; (#174) Opening parenthesis of a multi-line function call must be the last content on the line; (#174) Only one argument is allowed per line in a multi-line function call; (#175) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#175) Only one argument is allowed per line in a multi-line function call; (#175) Only one argument is allowed per line in a multi-line function call; (#175) Closing parenthesis of a multi-line function call must be on a line by itself; (#188) Line exceeds 132 characters; contains 153 characters

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

CSS problems

(3 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

theme/moove/style/moodle.css: (#26366) "declaration-no-important" has already been disabled (CssSyntaxError)
theme/moove/scss/moove/_accessibilitystyles.scss: (#36) Unknown word (CssSyntaxError)
theme/moove/scss/moove/_general.scss: (#108) Unknown word (CssSyntaxError)

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

Overview

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems