Prechecker results: error


Overview

(1 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

The patchset contains changes to upgrade.txt or UPGRADING.md files.

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(4 errors, 63 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

theme/moove/classes/output/boostnavbar.php
(#29) Incorrect @package tag for class boostnavbar. Expected theme_moove, found theme_boost.
(#117) Empty FOREACH statement detected
(#119) Inline comments must end in full-stops, exclamation marks, or question marks
(#119) Line indented incorrectly; expected at least 16 spaces, found 0
(#119) Expected 1 space before comment text but found 16; use block comment if you need indentation
theme/moove/lang/en/theme_moove.php
(#28) The string key "configtitle" is not in the correct order, it should be before "pluginname"
(#29) The string key "choosereadme" is not in the correct order, it should be before "configtitle"
(#33) The string key "prev_section" is not in the correct order, it should be before "region-side-pre"
(#34) The string key "next_section" is not in the correct order, it should be before "prev_section"
(#36) The string key "access" is not in the correct order, it should be before "themedevelopedby"
(#38) The string key "next_activity" is not in the correct order, it should be before "prev_activity"
(#39) The string key "donthaveanaccount" is not in the correct order, it should be before "next_activity"
(#42) Unexpected comment found. Auto-fixing will not work after this comment
(#43) The string key "generalsettings" is not in the correct order, it should be before "signinwith"
(#46) The string key "favicon" is not in the correct order, it should be before "logodesc"
(#52) The string key "loginbgimg" is not in the correct order, it should be before "presetfiles_desc"
(#54) The string key "brandcolor" is not in the correct order, it should be before "loginbgimg_desc"
(#58) The string key "navbarbg" is not in the correct order, it should be before "secondarymenucolor_desc"
(#62) The string key "fontsite" is not in the correct order, it should be before "navbarbghover_desc"
(#64) The string key "enablecourseindex" is not in the correct order, it should be before "fontsite_desc"
(#66) The string key "enableclassicbreadcrumb" is not in the correct order, it should be before "enablecourseindex_desc"
(#69) Unexpected comment found. Auto-fixing will not work after this comment
(#70) The string key "advancedsettings" is not in the correct order, it should be before "enableclassicbreadcrumb_desc"
(#73) The string key "rawscss" is not in the correct order, it should be before "rawscsspre_desc"
(#75) The string key "googleanalytics" is not in the correct order, it should be before "rawscss_desc"
(#80) Unexpected comment found. Auto-fixing will not work after this comment
(#81) The string key "frontpagesettings" is not in the correct order, it should be before "hvpcss_desc"
(#82) The string key "displaymarketingboxes" is not in the correct order, it should be before "frontpagesettings"
(#85) The string key "marketingsectioncontent" is not in the correct order, it should be before "marketingsectionheading"
(#86) The string key "marketingicon" is not in the correct order, it should be before "marketingsectioncontent"
(#87) The string key "marketingheading" is not in the correct order, it should be before "marketingicon"
(#88) The string key "marketingcontent" is not in the correct order, it should be before "marketingheading"
(#90) The string key "disableteacherspic" is not in the correct order, it should be before "marketingcontent"
(#95) The string key "slidercount" is not in the correct order, it should be before "sliderfrontpageloggedindesc"
(#101) The string key "slidercaption" is not in the correct order, it should be before "slidertitledesc"
(#104) The string key "numbersfrontpage" is not in the correct order, it should be before "slidercaptiondesc"
(#106) The string key "numbersfrontpagecontent" is not in the correct order, it should be before "numbersfrontpagedesc"
(#108) The string key "numbersfrontpagecontentdefault" is not in the correct order, it should be before "numbersfrontpagecontentdesc"
(#113) The string key "numberscourses" is not in the correct order, it should be before "numbersusers"
(#115) The string key "faq" is not in the correct order, it should be before "numberscourses"
(#119) The string key "faqanswer" is not in the correct order, it should be before "faqquestion"
(#121) Unexpected comment found. Auto-fixing will not work after this comment
(#125) The string key "mobile" is not in the correct order, it should be before "websitedesc"
(#127) The string key "mail" is not in the correct order, it should be before "mobiledesc"
(#129) The string key "facebook" is not in the correct order, it should be before "maildesc"
(#133) The string key "linkedin" is not in the correct order, it should be before "twitterdesc"
(#137) The string key "instagram" is not in the correct order, it should be before "youtubedesc"
(#141) The string key "telegram" is not in the correct order, it should be before "whatsappdesc"
(#143) The string key "contactus" is not in the correct order, it should be before "telegramdesc"
(#146) Unexpected comment found. Auto-fixing will not work after this comment
(#147) The string key "aboutme" is not in the correct order, it should be before "followus"
(#149) The string key "addcontact" is not in the correct order, it should be before "personalinformation"
(#152) Unexpected comment found. Auto-fixing will not work after this comment
(#155) The string key "themesettings:defaultfont" is not in the correct order, it should be before "themesettings:fonttype"
(#158) The string key "themesettingg:successfullysaved" is not in the correct order, it should be before "themesettings:enableaccessibilitytoolbar"
(#160) Unexpected comment found. Auto-fixing will not work after this comment
(#161) The string key "accessibility:fontsize" is not in the correct order, it should be before "themesettingg:successfullysaved"
(#162) The string key "accessibility:decreasefont" is not in the correct order, it should be before "accessibility:fontsize"
(#164) The string key "accessibility:increasefont" is not in the correct order, it should be before "accessibility:resetfont"
(#166) The string key "accessibility:resetsitecolor" is not in the correct order, it should be before "accessibility:sitecolor"
(#171) Unexpected comment found. Auto-fixing will not work after this comment
(#175) The string key "privacy:metadata:preference:thememoovesettings_enableaccessibilitytoolbar" is not in the correct order, it should be before "privacy:metadata:preference:thememoovesettings_fonttype"
(#177) The string key "privacy:accessibilitystyles_fontsizeclass" is not in the correct order, it should be before "privacy:metadata:preference:thememoovesettings_enableaccessibilitytoolbar"
(#180) The string key "privacy:thememoovesettings_enableaccessibilitytoolbar" is not in the correct order, it should be before "privacy:thememoovesettings_fonttype"
(#183) The string key "redirectbtntext" is not in the correct order, it should be before "redirectmessage"
theme/moove/lib.php
(#206) This comment is 50% valid code; is this commented out code?
theme/moove/settings.php
(#188) Line exceeds 132 characters; contains 153 characters

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(3 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

theme/moove/style/moodle.css
(#26285) "declaration-no-important" has already been disabled (CssSyntaxError)
theme/moove/scss/moove/_accessibilitystyles.scss
(#36) Unknown word (CssSyntaxError)
theme/moove/scss/moove/_general.scss
(#108) Unknown word (CssSyntaxError)

PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 36 warnings)

This section shows problems detected in mustache templates [More info]

theme/moove/templates/block_myoverview/course-action-menu.mustache
(#1) HTML Validation error, line 16: The “aria-controls” attribute must point to an element in the same document. (> <a class="dropdown-item hidden" href="#" data-action="add-favourite" data-course-id="" aria-controls="favorite-icon--would-be-a-uniqid" > )
(#1) HTML Validation error, line 26: The “aria-controls” attribute must point to an element in the same document. (> <a class="dropdown-item " href="#" data-action="remove-favourite" data-course-id="" aria-controls="favorite-icon--would-be-a-uniqid" > )
(#1) HTML Validation error, line 36: The “aria-controls” attribute must point to an element in the same document. (> <a class="dropdown-item hidden" href="#" data-action="show-course" data-course-id="" aria-controls="favorite-icon--would-be-a-uniqid" > )
(#1) HTML Validation error, line 46: The “aria-controls” attribute must point to an element in the same document. (> <a class="dropdown-item " href="#" data-action="hide-course" data-course-id="" aria-controls="favorite-icon--would-be-a-uniqid" > )
theme/moove/templates/core/loginform.mustache
(#1) HTML Validation info, line 34: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="username" value="guest" /> )
(#1) HTML Validation info, line 35: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="password" value="guest" /> )
theme/moove/templates/core_course/activity_navigation.mustache
(#1) HTML Validation error, line 19: Bad value “” for attribute “id” on element “form”: An ID must not be the empty string. (s=""> <form method="post" action="#" class="d-flex flex-wrap align-items-center" id=""> )
theme/moove/templates/core_course/coursecard.mustache
(#1) HTML Validation error, line 4: An element with “role=listitem” must be contained in, or owned by, an element with “role=list” or “role=group”. (ad><body><div class="card dashboard-card mx-1" role="listitem" data-region="course-content" data-course-id=""> <)
theme/moove/templates/course.mustache
(#1) HTML Validation info, line 5: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (itle> <link rel="shortcut icon" href="favicon.ico" /> )
(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (TYPE html><html ><head)
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( M.util.js_pending('theme_boost/loader');
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( M.util.js_pending('theme_boost/loader');
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( require(['theme_boost/loader', 'theme_boost/drawer'], function(Loader, Drawer) {
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( Drawer.init();
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( M.util.js_complete('theme_boost/loader');
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( }); ), Line: 18 Column: 4
theme/moove/templates/drawers.mustache
(#1) HTML Validation info, line 5: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (itle> <link rel="shortcut icon" href="favicon.ico" /> )
(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (TYPE html><html ><head)
theme/moove/templates/frontpage.mustache
(#1) HTML Validation info, line 5: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (itle> <link rel="shortcut icon" href="favicon.ico" /> )
(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (TYPE html><html ><head)
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( M.util.js_pending('theme_boost/loader');
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( M.util.js_pending('theme_boost/loader');
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( require(['theme_boost/loader', 'theme_boost/drawer'], function(Loader, Drawer) {
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( Drawer.init();
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( M.util.js_complete('theme_boost/loader');
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( });
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( require(['jquery'], function($) {
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( $('.carousel').carousel({
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( interval: 5000
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( });
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( }); ), Line: 17 Column: 8
theme/moove/templates/head.mustache
(#1) HTML Validation error, line 2: Start tag seen without seeing a doctype first. Expected “<!DOCTYPE html>”. (<html ><head)
(#1) HTML Validation error, line 4: Element “title” must not be empty. ( <title></title> <)
(#1) HTML Validation error, line 5: Bad value “” for attribute “href” on element “link”: Must be non-empty. (itle> <link rel="shortcut icon" href="" /> )
(#1) HTML Validation info, line 5: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (itle> <link rel="shortcut icon" href="" /> )
(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (<html ><head)
theme/moove/templates/incourse.mustache
(#1) HTML Validation info, line 5: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (itle> <link rel="shortcut icon" href="favicon.ico" /> )
(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (TYPE html><html ><head)
theme/moove/templates/loading-overlay.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 16: Attribute value missing. (> <a href=>((redi)
(#1) HTML Validation info, line 16: Attribute “href” without an explicit value seen. The attribute may be dropped by IE7. (> <a href=>((redi)
theme/moove/templates/login.mustache
(#1) HTML Validation info, line 5: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (itle> <link rel="shortcut icon" href="favicon.ico" /> )
(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (TYPE html><html ><head)
theme/moove/templates/moove_coursecard.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 2: An element with “role=listitem” must be contained in, or owned by, an element with “role=list” or “role=group”. (ad><body><div class="card dashboard-card dimmed" role="listitem" data-region="course-content" data-course-id=""> <)
theme/moove/templates/mypublic.mustache
(#1) HTML Validation info, line 5: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (itle> <link rel="shortcut icon" href="favicon.ico" /> )
(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (TYPE html><html ><head)
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( M.util.js_pending('theme_boost/loader');
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( M.util.js_pending('theme_boost/loader');
(#1) ESLint error [no-unused-vars]: 'Loader' is defined but never used. ( require(['theme_boost/loader'], function(Loader) {
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( require(['theme_boost/loader'], function(Loader) {
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( M.util.js_complete('theme_boost/loader');
(#1) ESLint error [linebreak-style]: Expected linebreaks to be 'LF' but found 'CRLF'. ( }); ), Line: 15 Column: 8

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]