Moodle plugins directory: Watershed Report Link

Comments

• 

  Dan Marsden

  Mon, Jun 13, 2016, 7:05 AM

  Hi Andrew,
  
  The plugin seems to allow Moodle's full session id to be disclosed - passed in a $_GET call and sent to the external service? - that looks pretty nasty to me. I'd also suggest renaming your config.php file to config-dist.php to help avoid people from adding their credentials into their local git repo and then accidentally sharing the repo (for example in github) I've reported those issues into your github tracker - It would also be good to run the moodle coding guideline tools over the code - Have you seen the travis-ci integration to help run these automatically? - see (https://moodle.org/mod/forum/discuss.php?d=323384)
• 

  Dan Marsden

  Mon, Jun 13, 2016, 7:06 AM

  it would also be good to add some more detail in the plugin description here and some screenshots of the reports that might be available.
• 

  Andrew Downes

  Tue, Jun 21, 2016, 7:11 PM

  These issues have now been resolved on the Github. The only thing is that the plugin makes use for PHP's error_log function which the code checker does not like for some reason.
  
  What's the next step? Should I push a new release here, or wait for you to review again first?
• 

  David Mudrák

  Tue, Jun 21, 2016, 8:19 PM

  Add a new version here and then use the "Request re-approval" button.

• 

  David Mudrák

  Wed, Aug 10, 2016, 7:54 PM

  Thanks Andrew for sharing another plugin with the community, and thanks Dan for the code peer-review. While attempting to install the report, I ran into a fatal error due to missing dependencies and reported the issue as #5 in your tracker. With the hope that issue will be fixed asap, I am going to approve the plugin now. You are cleared to land, welcome to the Plugins directory.

• 

  dave fay

  Fri, Sep 30, 2016, 5:14 AM

  Debug info:
  Error code: codingerror
  Stack trace:
  
  line 289 of /lib/ddl/sql_generator.php: coding_exception thrown
  line 221 of /lib/ddl/mysql_sql_generator.php: call to sql_generator->getCreateTableSQL()
  line 250 of /lib/ddl/sql_generator.php: call to mysql_sql_generator->getCreateTableSQL()
  line 415 of /lib/ddl/database_manager.php: call to sql_generator->getCreateStructureSQL()
  line 370 of /lib/ddl/database_manager.php: call to database_manager->install_from_xmldb_structure()
  line 514 of /lib/upgradelib.php: call to database_manager->install_from_xmldb_file()
  line 1742 of /lib/upgradelib.php: call to upgrade_plugins()
  line 683 of /admin/index.php: call to upgrade_noncore()
  
  that was what i saw when installed on moddle3.1
• 

  Andrew Downes

  Fri, Sep 30, 2016, 6:47 PM

  Hi Dave,
  
  I have replicated and fixed the error and pushed a new release. Can you download that new release and try again?
  
  Thanks for giving me the full stack trace, though ironically the useful bit of error message was the text immediately above what you copied
  
  Note that this plugin only works with Watershed LRS. Do you have a Watershed account that you're using this plugin with? See https://watershedlrs.com or mail andrew.downes@watershedlrs.com
  
  Andrew
• 

  Ganesh Ubhare

  Thu, Oct 18, 2018, 11:26 PM

  Hi Andrew,
  
  It seems the fix is still now working . I have tried to install the latest version and still getting the same error. See the details below
  
  Debug info:
  Error code: codingerror
  ×Stack trace:
  line 289 of \lib\ddl\sql_generator.php: coding_exception thrown
  line 224 of \lib\ddl\mysql_sql_generator.php: call to sql_generator->getCreateTableSQL()
  line 250 of \lib\ddl\sql_generator.php: call to mysql_sql_generator->getCreateTableSQL()
  line 415 of \lib\ddl\database_manager.php: call to sql_generator->getCreateStructureSQL()
  line 370 of \lib\ddl\database_manager.php: call to database_manager->install_from_xmldb_structure()
  line 514 of \lib\upgradelib.php: call to database_manager->install_from_xmldb_file()
  line 1742 of \lib\upgradelib.php: call to upgrade_plugins()
  line 683 of \admin\index.php: call to upgrade_noncore()
  
  Please can you fix this .
  
  Thanks