Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(55 errors, 72 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

report/simultaneous/adminlist.php
(#20) Incorrect @package tag for file adminlist.php. Expected report_simultaneous, found report.
(#31) Short array syntax must be used to define arrays
(#63) Expected 1 space before "=>"; 0 found
(#63) Expected 1 space after "=>"; 0 found
(#63) Expected 1 space before "=>"; 0 found
(#63) Expected 1 space after "=>"; 0 found
report/simultaneous/classes/event/report_viewed.php
(#82) Short array syntax must be used to define arrays
(#114) Missing docblock for function get_other_mapping
(#115) Short array syntax must be used to define arrays
report/simultaneous/classes/filter_form.php
(#36) Missing member variable doc comment
(#79) Missing docblock for function validation
report/simultaneous/classes/privacy/provider.php
(#41) There must not be a space before the colon in a return type declaration
report/simultaneous/db/access.php
(#27) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#33) Short array syntax must be used to define arrays
(#36) There should be a comma after the last array item in a multi-line array.
(#38) There should be a comma after the last array item in a multi-line array.
(#40) Short array syntax must be used to define arrays
(#44) Short array syntax must be used to define arrays
(#45) There should be a comma after the last array item in a multi-line array.
(#47) There should be a comma after the last array item in a multi-line array.
report/simultaneous/db/install.php
(#20) Incorrect @package tag for file install.php. Expected report_simultaneous, found report.
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#28) Missing docblock for function xmldb_report_simultaneous_install
report/simultaneous/index.php
(#20) Incorrect @package tag for file index.php. Expected report_simultaneous, found report.
(#38) Short array syntax must be used to define arrays
(#47) Short array syntax must be used to define arrays
(#51) Short array syntax must be used to define arrays
(#52) Short array syntax must be used to define arrays
(#87) Inline comments must end in full-stops, exclamation marks, or question marks
(#109) Inline comments must end in full-stops, exclamation marks, or question marks
(#166) Short array syntax must be used to define arrays
(#168) Short array syntax must be used to define arrays
(#172) There should be a comma after the last array item in a multi-line array.
(#173) There should be a comma after the last array item in a multi-line array.
(#193) Line exceeds 132 characters; contains 157 characters
(#224) Short array syntax must be used to define arrays
(#229) There should be a comma after the last array item in a multi-line array.
(#231) Short array syntax must be used to define arrays
(#248) This comment is 45% valid code; is this commented out code?
(#249) Inline comments must end in full-stops, exclamation marks, or question marks
(#249) No space found before comment text; expected "// $filterform->set_data($toform);" but found "//$filterform->set_data($toform);"
(#255) File must end with a newline character
report/simultaneous/lang/en/report_simultaneous.php
(#20) Incorrect @package tag for file report_simultaneous.php. Expected report_simultaneous, found report.
(#29) The string key "simultaneous:adminlisting" is not in the correct order, it should be before "simultaneous:view"
(#30) The string key "page-report-simultaneous-x" is not in the correct order, it should be before "simultaneous:adminlisting"
(#31) The string key "page-report-simultaneous-index" is not in the correct order, it should be before "page-report-simultaneous-x"
(#44) The string key "incourse_column" is not in the correct order, it should be before "totaltimeexceeded"
(#47) The string key "force_activity_time" is not in the correct order, it should be before "indicators"
(#57) The string key "messageactions_column" is not in the correct order, it should be before "messagesent_column_help"
report/simultaneous/lang/es/report_simultaneous.php
(#20) Incorrect @package tag for file report_simultaneous.php. Expected report_simultaneous, found report.
(#29) The string key "simultaneous:adminlisting" is not in the correct order, it should be before "simultaneous:view"
(#30) The string key "page-report-simultaneous-x" is not in the correct order, it should be before "simultaneous:adminlisting"
(#31) The string key "page-report-simultaneous-index" is not in the correct order, it should be before "page-report-simultaneous-x"
(#42) The string key "starttimebeforeendtime" is not in the correct order, it should be before "status_column_help"
(#44) The string key "incourse_column" is not in the correct order, it should be before "totaltimeexceeded"
(#55) The string key "messageactions_column" is not in the correct order, it should be before "messagesent_column_help"
report/simultaneous/lib.php
(#20) Incorrect @package tag for file lib.php. Expected report_simultaneous, found report.
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) Short array syntax must be used to define arrays
report/simultaneous/locallib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#67) Short array syntax must be used to define arrays
(#93) Short array syntax must be used to define arrays
(#121) Short array syntax must be used to define arrays
(#147) Short array syntax must be used to define arrays
(#179) Short array syntax must be used to define arrays
(#184) Short array syntax must be used to define arrays
(#197) Expected 1 space before ":"; 0 found
(#213) Line exceeds 132 characters; contains 145 characters
(#216) Short array syntax must be used to define arrays
(#219) Short array syntax must be used to define arrays
(#262) Short array syntax must be used to define arrays
(#264) Short array syntax must be used to define arrays
(#268) Whitespace found at end of line
(#294) Short array syntax must be used to define arrays
(#297) Short array syntax must be used to define arrays
(#323) Line exceeds 132 characters; contains 141 characters
(#326) Short array syntax must be used to define arrays
(#328) Whitespace found at end of line
(#329) Short array syntax must be used to define arrays
(#354) Missing docblock for function report_simultaneous_define_table
(#358) Short array syntax must be used to define arrays
(#363) Short array syntax must be used to define arrays
(#363) Inline comments must start with a capital letter, digit or 3-dots sequence
(#363) This comment is 46% valid code; is this commented out code?
(#363) No space found before comment text; expected "// , 'V1', 'V2', 'V3', 'V4', 'V5', 'V6');" but found "//, 'V1', 'V2', 'V3', 'V4', 'V5', 'V6');"
(#365) Expected 1 space before "=>"; 0 found
(#365) Expected 1 space after "=>"; 0 found
(#365) Expected 1 space before "=>"; 0 found
(#365) Expected 1 space after "=>"; 0 found
(#370) Whitespace found at end of line
(#374) Missing docblock for function report_simultaneous_create_table
(#390) Short array syntax must be used to define arrays
(#403) Short array syntax must be used to define arrays
(#409) There should be a comma after the last array item in a multi-line array.
(#431) Line exceeds 132 characters; contains 143 characters
(#435) Line exceeds 132 characters; contains 144 characters
(#439) Line exceeds 132 characters; contains 141 characters
(#455) Line exceeds 132 characters; contains 141 characters
(#468) Whitespace found at end of line
(#469) Short array syntax must be used to define arrays
(#470) Expected 1 space before "=>"; 0 found
(#471) Expected 1 space before "=>"; 0 found
(#472) Expected 1 space before "=>"; 0 found
(#473) Expected 1 space before "=>"; 0 found
(#474) Expected 1 space before "=>"; 0 found
(#475) Expected 1 space before "=>"; 0 found
(#485) Line exceeds 132 characters; contains 166 characters
(#493) Whitespace found at end of line
(#495) Short array syntax must be used to define arrays
(#516) Short array syntax must be used to define arrays
(#518) Short array syntax must be used to define arrays
(#525) Whitespace found at end of line
(#525) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#533) Short array syntax must be used to define arrays
(#533) Whitespace found at end of line
report/simultaneous/settings.php
(#27) Inline comments must end in full-stops, exclamation marks, or question marks
(#42) Variable "indicators_help" must not contain underscores.
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) Variable "indicators_help" must not contain underscores.
(#46) Variable "indicators_help" must not contain underscores.
(#46) Line exceeds 132 characters; contains 146 characters
(#48) Variable "indicators_help" must not contain underscores.
(#48) Variable "indicators_help" must not contain underscores.
(#51) Variable "indicators_help" must not contain underscores.
(#53) File must end with a newline character
report/simultaneous/version.php
(#20) Incorrect @package tag for file version.php. Expected report_simultaneous, found report.

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(9 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

report/simultaneous/locallib.php
(#139) Phpdocs for function report_simultaneous_get_users_with_activity has incomplete parameters list
(#172) Phpdocs for function report_simultaneous_get_users_with_multiple_ips has incomplete parameters list
(#211) Phpdocs for function report_simultaneous_get_users_with_activity_other has incomplete parameters list
(#255) Phpdocs for function report_simultaneous_get_users_with_messaging has incomplete parameters list
(#288) Phpdocs for function report_simultaneous_get_users_with_message_actions has incomplete parameters list
(#320) Phpdocs for function report_simultaneous_get_users_sent_message_to_conversations has incomplete parameters list
(#422) Phpdocs for function report_simultaneous_get_indicator has incomplete parameters list
(#460) Phpdocs for function report_simultaneous_get_indicators has incomplete parameters list
(#482) Phpdocs for function report_simultaneous_get_data has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(2 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

report/simultaneous/amd/build/simultaneous.min.js
Uncommitted change detected.
report/simultaneous/amd/build/simultaneous.min.js.map
Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]